shaba/libvirt-python
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt-python.git synced 2025-12-14 04:23:47 +03:00
Code Issues Projects Releases Activity

Fix memory leak in libvirt_virStreamRecv.

Browse Source 
The libvirt_virStreamRecv function uses a temporary allocated buffer to
receive data before copying the data into a Python byte array. But
there are some error paths where this buffer is not freed. This change
fixes that memory leak.

Signed-off-by: Chris Gunn <chrisgun@microsoft.com>
This commit is contained in:
Chris Gunn
2022-10-10 13:36:18 -07:00
parent d9b9517cc3
commit 9716b459ca
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libvirt-override.c
View File

@@ -7926,10 +7926,14 @@ libvirt_virStreamRecv(PyObject *self ATTRIBUTE_UNUSED,
buf[ret > -1 ? ret : 0] = '\0'; buf[ret > -1 ? ret : 0] = '\0';
DEBUG("StreamRecv ret=%d strlen=%d\n", ret, (int) strlen(buf)); DEBUG("StreamRecv ret=%d strlen=%d\n", ret, (int) strlen(buf));
if (ret == -2) if (ret == -2) {
VIR_FREE(buf);
return libvirt_intWrap(ret); return libvirt_intWrap(ret);
if (ret < 0) }
if (ret < 0) {
VIR_FREE(buf);
return VIR_PY_NONE; return VIR_PY_NONE;
}
rv = libvirt_charPtrSizeWrap((char *) buf, (Py_ssize_t) ret); rv = libvirt_charPtrSizeWrap((char *) buf, (Py_ssize_t) ret);
VIR_FREE(buf); VIR_FREE(buf);
return rv; return rv;