2012-07-23 10:02:14 +04:00
/*
* virsh - network . c : Commands to manage network
*
2018-12-12 19:58:31 +03:00
* Copyright ( C ) 2005 , 2007 - 2019 Red Hat , Inc .
2012-07-23 10:02:14 +04:00
*
* This library is free software ; you can redistribute it and / or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation ; either
* version 2.1 of the License , or ( at your option ) any later version .
*
* This library is distributed in the hope that it will be useful ,
* but WITHOUT ANY WARRANTY ; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the GNU
* Lesser General Public License for more details .
*
* You should have received a copy of the GNU Lesser General Public
2012-09-21 02:30:55 +04:00
* License along with this library . If not , see
2012-07-23 10:02:14 +04:00
* < http : //www.gnu.org/licenses/>.
*/
2012-08-21 01:43:25 +04:00
# include <config.h>
# include "virsh-network.h"
2021-09-26 11:57:38 +03:00
# include "virsh-util.h"
2012-07-23 10:02:14 +04:00
2012-08-21 01:43:25 +04:00
# include "internal.h"
2012-12-12 22:06:53 +04:00
# include "viralloc.h"
2013-05-09 22:59:04 +04:00
# include "virfile.h"
2016-01-08 13:50:55 +03:00
# include "virtime.h"
2012-09-04 19:55:20 +04:00
# include "conf/network_conf.h"
2018-09-21 17:17:13 +03:00
# include "vsh-table.h"
2019-04-01 13:14:26 +03:00
# include "virenum.h"
2012-08-21 01:43:25 +04:00
2018-05-15 14:18:21 +03:00
# define VIRSH_COMMON_OPT_NETWORK(_helpstr, cflags) \
2017-11-03 15:09:47 +03:00
{ . name = " network " , \
. type = VSH_OT_DATA , \
. flags = VSH_OFLAG_REQ , \
2018-05-15 14:18:21 +03:00
. help = _helpstr , \
2018-01-12 16:35:40 +03:00
. completer = virshNetworkNameCompleter , \
. completer_flags = cflags , \
2017-10-31 13:47:36 +03:00
}
2016-01-09 16:36:34 +03:00
2018-05-15 14:18:21 +03:00
# define VIRSH_COMMON_OPT_NETWORK_FULL(cflags) \
VIRSH_COMMON_OPT_NETWORK ( N_ ( " network name or uuid " ) , cflags )
2018-05-15 14:10:35 +03:00
# define VIRSH_COMMON_OPT_NETWORK_OT_STRING(_helpstr, cflags) \
{ . name = " network " , \
. type = VSH_OT_STRING , \
. help = _helpstr , \
. completer = virshNetworkNameCompleter , \
. completer_flags = cflags , \
}
# define VIRSH_COMMON_OPT_NETWORK_OT_STRING_FULL(cflags) \
VIRSH_COMMON_OPT_NETWORK_OT_STRING ( N_ ( " network name or uuid " ) , cflags )
2018-12-12 19:58:31 +03:00
# define VIRSH_COMMON_OPT_NETWORK_PORT(cflags) \
{ . name = " port " , \
. type = VSH_OT_DATA , \
. flags = VSH_OFLAG_REQ , \
. help = N_ ( " port UUID " ) , \
. completer = virshNetworkPortUUIDCompleter , \
. completer_flags = cflags , \
}
2012-08-21 01:43:25 +04:00
virNetworkPtr
2015-06-15 19:53:58 +03:00
virshCommandOptNetworkBy ( vshControl * ctl , const vshCmd * cmd ,
const char * * name , unsigned int flags )
2012-07-23 10:02:14 +04:00
{
virNetworkPtr network = NULL ;
const char * n = NULL ;
const char * optname = " network " ;
2021-03-11 10:16:13 +03:00
virshControl * priv = ctl - > privData ;
2012-08-21 01:43:25 +04:00
2020-08-03 18:27:58 +03:00
virCheckFlags ( VIRSH_BYUUID | VIRSH_BYNAME , NULL ) ;
2013-01-21 20:22:17 +04:00
if ( vshCommandOptStringReq ( ctl , cmd , optname , & n ) < 0 )
2012-07-23 10:02:14 +04:00
return NULL ;
vshDebug ( ctl , VSH_ERR_INFO , " %s: found option <%s>: %s \n " ,
cmd - > def - > name , optname , n ) ;
if ( name )
* name = n ;
/* try it by UUID */
2015-06-15 19:53:58 +03:00
if ( ( flags & VIRSH_BYUUID ) & & strlen ( n ) = = VIR_UUID_STRING_BUFLEN - 1 ) {
2012-07-23 10:02:14 +04:00
vshDebug ( ctl , VSH_ERR_DEBUG , " %s: <%s> trying as network UUID \n " ,
cmd - > def - > name , optname ) ;
2015-06-15 19:53:58 +03:00
network = virNetworkLookupByUUIDString ( priv - > conn , n ) ;
2012-07-23 10:02:14 +04:00
}
/* try it by NAME */
2015-06-15 19:53:58 +03:00
if ( ! network & & ( flags & VIRSH_BYNAME ) ) {
2012-07-23 10:02:14 +04:00
vshDebug ( ctl , VSH_ERR_DEBUG , " %s: <%s> trying as network NAME \n " ,
cmd - > def - > name , optname ) ;
2015-06-15 19:53:58 +03:00
network = virNetworkLookupByName ( priv - > conn , n ) ;
2012-07-23 10:02:14 +04:00
}
if ( ! network )
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " failed to get network '%1$s' " ) , n ) ;
2012-07-23 10:02:14 +04:00
return network ;
}
2018-12-12 19:58:31 +03:00
virNetworkPortPtr
virshCommandOptNetworkPort ( vshControl * ctl , const vshCmd * cmd ,
virNetworkPtr net ,
const char * * name )
{
virNetworkPortPtr port = NULL ;
const char * n = NULL ;
const char * optname = " port " ;
if ( vshCommandOptStringReq ( ctl , cmd , optname , & n ) < 0 )
return NULL ;
vshDebug ( ctl , VSH_ERR_INFO , " %s: found option <%s>: %s \n " ,
cmd - > def - > name , optname , n ) ;
if ( name )
* name = n ;
vshDebug ( ctl , VSH_ERR_DEBUG , " %s: <%s> trying as network UUID \n " ,
cmd - > def - > name , optname ) ;
port = virNetworkPortLookupByUUIDString ( net , n ) ;
if ( ! port )
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " failed to get network port '%1$s' " ) , n ) ;
2018-12-12 19:58:31 +03:00
return port ;
}
2012-07-23 10:02:14 +04:00
/*
* " net-autostart " command
*/
static const vshCmdInfo info_network_autostart [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " autostart a network " )
} ,
{ . name = " desc " ,
. data = N_ ( " Configure a network to be automatically started at boot. " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_autostart [ ] = {
2018-05-15 14:18:21 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( VIR_CONNECT_LIST_NETWORKS_PERSISTENT ) ,
2013-01-14 18:28:17 +04:00
{ . name = " disable " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " disable autostarting " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkAutostart ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2012-07-23 10:02:14 +04:00
const char * name ;
int autostart ;
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , & name ) ) )
2012-07-23 10:02:14 +04:00
return false ;
autostart = ! vshCommandOptBool ( cmd , " disable " ) ;
if ( virNetworkSetAutostart ( network , autostart ) < 0 ) {
if ( autostart )
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " failed to mark network %1$s as autostarted " ) , name ) ;
2012-07-23 10:02:14 +04:00
else
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " failed to unmark network %1$s as autostarted " ) , name ) ;
2012-07-23 10:02:14 +04:00
return false ;
}
if ( autostart )
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network %1$s marked as autostarted \n " ) , name ) ;
2012-07-23 10:02:14 +04:00
else
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network %1$s unmarked as autostarted \n " ) , name ) ;
2012-07-23 10:02:14 +04:00
return true ;
}
/*
* " net-create " command
*/
static const vshCmdInfo info_network_create [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " create a network from an XML file " )
} ,
{ . name = " desc " ,
. data = N_ ( " Create a network. " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_create [ ] = {
2016-01-09 16:36:29 +03:00
VIRSH_COMMON_OPT_FILE ( N_ ( " file containing an XML network description " ) ) ,
2021-09-15 14:07:31 +03:00
{ . name = " validate " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " validate the XML against the schema " )
} ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkCreate ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2012-07-23 10:02:14 +04:00
const char * from = NULL ;
2021-08-11 16:25:15 +03:00
g_autofree char * buffer = NULL ;
2021-09-15 14:07:31 +03:00
unsigned int flags = 0 ;
2021-03-11 10:16:13 +03:00
virshControl * priv = ctl - > privData ;
2012-07-23 10:02:14 +04:00
2013-01-21 20:22:17 +04:00
if ( vshCommandOptStringReq ( ctl , cmd , " file " , & from ) < 0 )
2012-07-23 10:02:14 +04:00
return false ;
2021-09-15 14:07:31 +03:00
if ( vshCommandOptBool ( cmd , " validate " ) )
flags | = VIR_NETWORK_CREATE_VALIDATE ;
virsh: use common namespacing
Convert the exported items in virsh.h to use a common 'vsh' prefix.
* tools/virsh.h (VIRSH_MAX_XML_FILE): Rename...
(VSH_MAX_XML_FILE): ...and parenthesize.
(DIFF_MSEC, CTRL_CLOSE_BRACKET): Delete.
(vshUsage, vshInit, vshDeinit, vshParseArgv): Remove prototype.
(editWriteToTempFile, editFile, editReadBackFile, prettyCapacity)
(virshReportError): Rename...
(vshEditWriteToTempFile, vshEditFile, vshEditReadBackFile)
(vshPrettyCapacity, vshReportError): ...into vsh namespace.
(jobWatchTimeoutFunc): Move to virsh-domain.c.
* tools/virsh.c (vshCommandRun): Inline former DIFF_MSEC.
(main): Inline former CTRL_CLOSE_BRACKET.
(vshUsage, vshInit, vshDeinit, vshParseArgv): Make static.
(prettyCapacity, virshReportError, editWriteToTempFile, editFile):
Fix naming, and adjust usage.
(vshAskReedit, vshCommandRun, vshEventLoop, vshInit): Adjust
usage.
* tools/virsh-domain.c (cmdAttachDevice, cmdCPUCompare)
(cmdCPUBaseline, cmdCreate, cmdDefine, cmdDetachDevice)
(cmdUpdateDevice, cmdDesc, cmdUndefine, cmdStart, cmdVcpucount)
(cmdAttachDevice, cmdDomjobinfo): Likewise.
* tools/virsh-edit.c (do): Likewise.
* tools/virsh-interface.c (cmdInterfaceDefine): Likewise.
* tools/virsh-network.c (cmdNetworkCreate, cmdNetworkDefine):
Likewise.
* tools/virsh-nodedev.c (cmdNodeDeviceCreate): Likewise.
* tools/virsh-nwfilter.c (cmdNWFilterDefine): Likewise.
* tools/virsh-pool.c (cmdPoolCreate, cmdPoolDefine)
(cmdPoolDiscoverSources, cmdPoolList): Likewise.
* tools/virsh-secret.c (cmdSecretDefine): Likewise.
* tools/virsh-snapshot.c (cmdSnapshotCreate, vshSnapshotCreate)
(vshLookupSnapshot, cmdSnapshotEdit, cmdSnapshotCurrent)
(vshGetSnapshotParent): Likewise.
* tools/virsh-volume.c (cmdVolCreate, cmdVolCreateFrom)
(cmdVolInfo, cmdVolList): Likewise.
2012-08-19 08:10:17 +04:00
if ( virFileReadAll ( from , VSH_MAX_XML_FILE , & buffer ) < 0 )
2012-07-23 10:02:14 +04:00
return false ;
2021-09-15 14:07:31 +03:00
if ( flags )
network = virNetworkCreateXMLFlags ( priv - > conn , buffer , flags ) ;
else
network = virNetworkCreateXML ( priv - > conn , buffer ) ;
2012-07-23 10:02:14 +04:00
2021-09-24 02:49:08 +03:00
if ( ! network ) {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " Failed to create network from %1$s " ) , from ) ;
2021-09-24 02:49:08 +03:00
return false ;
2012-07-23 10:02:14 +04:00
}
2021-09-24 02:49:08 +03:00
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network %1$s created from %2$s \n " ) ,
2021-09-24 02:49:08 +03:00
virNetworkGetName ( network ) , from ) ;
return true ;
2012-07-23 10:02:14 +04:00
}
/*
* " net-define " command
*/
static const vshCmdInfo info_network_define [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
2015-02-25 18:01:09 +03:00
. data = N_ ( " define an inactive persistent virtual network or modify "
" an existing persistent one from an XML file " )
2013-02-07 19:25:10 +04:00
} ,
{ . name = " desc " ,
2015-02-25 18:01:09 +03:00
. data = N_ ( " Define or modify a persistent virtual network. " )
2013-02-07 19:25:10 +04:00
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_define [ ] = {
2016-01-09 16:36:29 +03:00
VIRSH_COMMON_OPT_FILE ( N_ ( " file containing an XML network description " ) ) ,
2021-08-23 19:50:14 +03:00
{ . name = " validate " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " validate the XML against the schema " )
} ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkDefine ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2012-07-23 10:02:14 +04:00
const char * from = NULL ;
2021-08-11 16:25:15 +03:00
g_autofree char * buffer = NULL ;
2021-08-23 19:50:14 +03:00
unsigned int flags = 0 ;
2021-03-11 10:16:13 +03:00
virshControl * priv = ctl - > privData ;
2012-07-23 10:02:14 +04:00
2013-01-21 20:22:17 +04:00
if ( vshCommandOptStringReq ( ctl , cmd , " file " , & from ) < 0 )
2012-07-23 10:02:14 +04:00
return false ;
2021-08-23 19:50:14 +03:00
if ( vshCommandOptBool ( cmd , " validate " ) )
flags | = VIR_NETWORK_DEFINE_VALIDATE ;
virsh: use common namespacing
Convert the exported items in virsh.h to use a common 'vsh' prefix.
* tools/virsh.h (VIRSH_MAX_XML_FILE): Rename...
(VSH_MAX_XML_FILE): ...and parenthesize.
(DIFF_MSEC, CTRL_CLOSE_BRACKET): Delete.
(vshUsage, vshInit, vshDeinit, vshParseArgv): Remove prototype.
(editWriteToTempFile, editFile, editReadBackFile, prettyCapacity)
(virshReportError): Rename...
(vshEditWriteToTempFile, vshEditFile, vshEditReadBackFile)
(vshPrettyCapacity, vshReportError): ...into vsh namespace.
(jobWatchTimeoutFunc): Move to virsh-domain.c.
* tools/virsh.c (vshCommandRun): Inline former DIFF_MSEC.
(main): Inline former CTRL_CLOSE_BRACKET.
(vshUsage, vshInit, vshDeinit, vshParseArgv): Make static.
(prettyCapacity, virshReportError, editWriteToTempFile, editFile):
Fix naming, and adjust usage.
(vshAskReedit, vshCommandRun, vshEventLoop, vshInit): Adjust
usage.
* tools/virsh-domain.c (cmdAttachDevice, cmdCPUCompare)
(cmdCPUBaseline, cmdCreate, cmdDefine, cmdDetachDevice)
(cmdUpdateDevice, cmdDesc, cmdUndefine, cmdStart, cmdVcpucount)
(cmdAttachDevice, cmdDomjobinfo): Likewise.
* tools/virsh-edit.c (do): Likewise.
* tools/virsh-interface.c (cmdInterfaceDefine): Likewise.
* tools/virsh-network.c (cmdNetworkCreate, cmdNetworkDefine):
Likewise.
* tools/virsh-nodedev.c (cmdNodeDeviceCreate): Likewise.
* tools/virsh-nwfilter.c (cmdNWFilterDefine): Likewise.
* tools/virsh-pool.c (cmdPoolCreate, cmdPoolDefine)
(cmdPoolDiscoverSources, cmdPoolList): Likewise.
* tools/virsh-secret.c (cmdSecretDefine): Likewise.
* tools/virsh-snapshot.c (cmdSnapshotCreate, vshSnapshotCreate)
(vshLookupSnapshot, cmdSnapshotEdit, cmdSnapshotCurrent)
(vshGetSnapshotParent): Likewise.
* tools/virsh-volume.c (cmdVolCreate, cmdVolCreateFrom)
(cmdVolInfo, cmdVolList): Likewise.
2012-08-19 08:10:17 +04:00
if ( virFileReadAll ( from , VSH_MAX_XML_FILE , & buffer ) < 0 )
2012-07-23 10:02:14 +04:00
return false ;
2021-08-23 19:50:14 +03:00
if ( flags )
network = virNetworkDefineXMLFlags ( priv - > conn , buffer , flags ) ;
else
network = virNetworkDefineXML ( priv - > conn , buffer ) ;
2012-07-23 10:02:14 +04:00
2021-09-24 02:49:08 +03:00
if ( ! network ) {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " Failed to define network from %1$s " ) , from ) ;
2021-09-24 02:49:08 +03:00
return false ;
2012-07-23 10:02:14 +04:00
}
2021-09-24 02:49:08 +03:00
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network %1$s defined from %2$s \n " ) ,
2021-09-24 02:49:08 +03:00
virNetworkGetName ( network ) , from ) ;
return true ;
2012-07-23 10:02:14 +04:00
}
/*
* " net-destroy " command
*/
static const vshCmdInfo info_network_destroy [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " destroy (stop) a network " )
} ,
{ . name = " desc " ,
. data = N_ ( " Forcefully stop a given network. " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_destroy [ ] = {
2018-05-15 14:18:21 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( VIR_CONNECT_LIST_NETWORKS_ACTIVE ) ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkDestroy ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2012-07-23 10:02:14 +04:00
bool ret = true ;
const char * name ;
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , & name ) ) )
2012-07-23 10:02:14 +04:00
return false ;
if ( virNetworkDestroy ( network ) = = 0 ) {
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network %1$s destroyed \n " ) , name ) ;
2012-07-23 10:02:14 +04:00
} else {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " Failed to destroy network %1$s " ) , name ) ;
2012-07-23 10:02:14 +04:00
ret = false ;
}
return ret ;
}
2023-08-16 21:47:12 +03:00
/*
* " net-desc " command
*/
static const vshCmdInfo info_network_desc [ ] = {
{ . name = " help " ,
. data = N_ ( " show or set network's description or title " )
} ,
{ . name = " desc " ,
. data = N_ ( " Allows setting or modifying the description or title of a network. " )
} ,
{ . name = NULL }
} ;
static const vshCmdOptDef opts_network_desc [ ] = {
VIRSH_COMMON_OPT_NETWORK_FULL ( 0 ) ,
VIRSH_COMMON_OPT_LIVE ( N_ ( " modify/get running state " ) ) ,
VIRSH_COMMON_OPT_CONFIG ( N_ ( " modify/get persistent configuration " ) ) ,
VIRSH_COMMON_OPT_CURRENT ( N_ ( " modify/get current state configuration " ) ) ,
{ . name = " title " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " modify/get the title instead of description " )
} ,
{ . name = " edit " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " open an editor to modify the description " )
} ,
{ . name = " new-desc " ,
. type = VSH_OT_ARGV ,
. help = N_ ( " message " )
} ,
{ . name = NULL }
} ;
/* extract description or title from network xml */
static char *
virshGetNetworkDescription ( vshControl * ctl , virNetworkPtr net ,
bool title , unsigned int flags )
{
char * desc = NULL ;
g_autoptr ( xmlDoc ) doc = NULL ;
g_autoptr ( xmlXPathContext ) ctxt = NULL ;
int type ;
if ( title )
type = VIR_NETWORK_METADATA_TITLE ;
else
type = VIR_NETWORK_METADATA_DESCRIPTION ;
if ( ( desc = virNetworkGetMetadata ( net , type , NULL , flags ) ) ) {
return desc ;
} else {
int errCode = virGetLastErrorCode ( ) ;
if ( errCode = = VIR_ERR_NO_NETWORK_METADATA ) {
desc = g_strdup ( " " ) ;
vshResetLibvirtError ( ) ;
return desc ;
}
if ( errCode ! = VIR_ERR_NO_SUPPORT )
return desc ;
}
/* fall back to xml */
if ( virshNetworkGetXMLFromNet ( ctl , net , flags , & doc , & ctxt ) < 0 )
return NULL ;
if ( title )
desc = virXPathString ( " string(./title[1]) " , ctxt ) ;
else
desc = virXPathString ( " string(./description[1]) " , ctxt ) ;
if ( ! desc )
desc = g_strdup ( " " ) ;
return desc ;
}
static bool
cmdNetworkDesc ( vshControl * ctl , const vshCmd * cmd )
{
g_autoptr ( virshNetwork ) net = NULL ;
bool config = vshCommandOptBool ( cmd , " config " ) ;
bool live = vshCommandOptBool ( cmd , " live " ) ;
bool current = vshCommandOptBool ( cmd , " current " ) ;
bool title = vshCommandOptBool ( cmd , " title " ) ;
bool edit = vshCommandOptBool ( cmd , " edit " ) ;
int type ;
g_autofree char * descArg = NULL ;
const vshCmdOpt * opt = NULL ;
g_auto ( virBuffer ) buf = VIR_BUFFER_INITIALIZER ;
unsigned int flags = VIR_NETWORK_UPDATE_AFFECT_CURRENT ;
unsigned int queryflags = 0 ;
VSH_EXCLUSIVE_OPTIONS_VAR ( current , live ) ;
VSH_EXCLUSIVE_OPTIONS_VAR ( current , config ) ;
if ( config ) {
flags | = VIR_NETWORK_UPDATE_AFFECT_CONFIG ;
queryflags | = VIR_NETWORK_XML_INACTIVE ;
}
if ( live )
flags | = VIR_NETWORK_UPDATE_AFFECT_LIVE ;
if ( ! ( net = virshCommandOptNetwork ( ctl , cmd , NULL ) ) )
return false ;
if ( title )
type = VIR_NETWORK_METADATA_TITLE ;
else
type = VIR_NETWORK_METADATA_DESCRIPTION ;
while ( ( opt = vshCommandOptArgv ( ctl , cmd , opt ) ) )
virBufferAsprintf ( & buf , " %s " , opt - > data ) ;
virBufferTrim ( & buf , " " ) ;
descArg = virBufferContentAndReset ( & buf ) ;
if ( edit | | descArg ) {
g_autofree char * descNet = NULL ;
g_autofree char * descNew = NULL ;
if ( ! ( descNet = virshGetNetworkDescription ( ctl , net , title , queryflags ) ) )
return false ;
if ( ! descArg )
descArg = g_strdup ( descNet ) ;
if ( edit ) {
g_autoptr ( vshTempFile ) tmp = NULL ;
g_autofree char * desc_edited = NULL ;
char * tmpstr ;
/* Create and open the temporary file. */
if ( ! ( tmp = vshEditWriteToTempFile ( ctl , descArg ) ) )
return false ;
/* Start the editor. */
if ( vshEditFile ( ctl , tmp ) = = - 1 )
return false ;
/* Read back the edited file. */
if ( ! ( desc_edited = vshEditReadBackFile ( ctl , tmp ) ) )
return false ;
/* strip a possible newline at the end of file; some
* editors enforce a newline , this makes editing the title
* more convenient */
if ( title & &
( tmpstr = strrchr ( desc_edited , ' \n ' ) ) & &
* ( tmpstr + 1 ) = = ' \0 ' )
* tmpstr = ' \0 ' ;
/* Compare original XML with edited. Has it changed at all? */
if ( STREQ ( descNet , desc_edited ) ) {
if ( title )
vshPrintExtra ( ctl , " %s " , _ ( " Network title not changed \n " ) ) ;
else
vshPrintExtra ( ctl , " %s " , _ ( " Network description not changed \n " ) ) ;
return true ;
}
descNew = g_steal_pointer ( & desc_edited ) ;
} else {
descNew = g_steal_pointer ( & descArg ) ;
}
if ( virNetworkSetMetadata ( net , type , descNew , NULL , NULL , flags ) < 0 ) {
if ( title )
vshError ( ctl , " %s " , _ ( " Failed to set new network title " ) ) ;
else
vshError ( ctl , " %s " , _ ( " Failed to set new network description " ) ) ;
return false ;
}
if ( title )
vshPrintExtra ( ctl , " %s " , _ ( " Network title updated successfully " ) ) ;
else
vshPrintExtra ( ctl , " %s " , _ ( " Network description updated successfully " ) ) ;
} else {
g_autofree char * desc = virshGetNetworkDescription ( ctl , net , title , queryflags ) ;
if ( ! desc )
return false ;
if ( strlen ( desc ) > 0 ) {
vshPrint ( ctl , " %s " , desc ) ;
} else {
if ( title )
vshPrintExtra ( ctl , _ ( " No title for network: %1$s " ) , virNetworkGetName ( net ) ) ;
else
vshPrintExtra ( ctl , _ ( " No description for network: %1$s " ) , virNetworkGetName ( net ) ) ;
}
}
return true ;
}
/*
* " net-metadata " command
*/
static const vshCmdInfo info_network_metadata [ ] = {
{ . name = " help " ,
. data = N_ ( " show or set network's custom XML metadata " )
} ,
{ . name = " desc " ,
. data = N_ ( " Shows or modifies the XML metadata of a network. " )
} ,
{ . name = NULL }
} ;
static const vshCmdOptDef opts_network_metadata [ ] = {
VIRSH_COMMON_OPT_NETWORK_FULL ( 0 ) ,
{ . name = " uri " ,
. type = VSH_OT_DATA ,
. flags = VSH_OFLAG_REQ ,
. help = N_ ( " URI of the namespace " )
} ,
VIRSH_COMMON_OPT_LIVE ( N_ ( " modify/get running state " ) ) ,
VIRSH_COMMON_OPT_CONFIG ( N_ ( " modify/get persistent configuration " ) ) ,
VIRSH_COMMON_OPT_CURRENT ( N_ ( " modify/get current state configuration " ) ) ,
{ . name = " edit " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " use an editor to change the metadata " )
} ,
{ . name = " key " ,
. type = VSH_OT_STRING ,
. help = N_ ( " key to be used as a namespace identifier " ) ,
} ,
{ . name = " set " ,
. type = VSH_OT_STRING ,
. completer = virshCompleteEmpty ,
. help = N_ ( " new metadata to set " ) ,
} ,
{ . name = " remove " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " remove the metadata corresponding to an uri " )
} ,
{ . name = NULL }
} ;
/* helper to add new metadata using the --edit option */
static char *
virshNetworkGetEditMetadata ( vshControl * ctl G_GNUC_UNUSED ,
virNetworkPtr net ,
const char * uri ,
unsigned int flags )
{
char * ret ;
if ( ! ( ret = virNetworkGetMetadata ( net , VIR_NETWORK_METADATA_ELEMENT ,
uri , flags ) ) ) {
vshResetLibvirtError ( ) ;
ret = g_strdup ( " \n " ) ;
}
return ret ;
}
static bool
cmdNetworkMetadata ( vshControl * ctl , const vshCmd * cmd )
{
g_autoptr ( virshNetwork ) net = NULL ;
bool config = vshCommandOptBool ( cmd , " config " ) ;
bool live = vshCommandOptBool ( cmd , " live " ) ;
bool current = vshCommandOptBool ( cmd , " current " ) ;
bool edit = vshCommandOptBool ( cmd , " edit " ) ;
bool rem = vshCommandOptBool ( cmd , " remove " ) ;
const char * set = NULL ;
const char * uri = NULL ;
const char * key = NULL ;
unsigned int flags = VIR_NETWORK_UPDATE_AFFECT_CURRENT ;
bool ret = false ;
VSH_EXCLUSIVE_OPTIONS_VAR ( current , live ) ;
VSH_EXCLUSIVE_OPTIONS_VAR ( current , config ) ;
VSH_EXCLUSIVE_OPTIONS ( " edit " , " set " ) ;
VSH_EXCLUSIVE_OPTIONS ( " remove " , " set " ) ;
VSH_EXCLUSIVE_OPTIONS ( " remove " , " edit " ) ;
if ( config )
flags | = VIR_NETWORK_UPDATE_AFFECT_CONFIG ;
if ( live )
flags | = VIR_NETWORK_UPDATE_AFFECT_LIVE ;
if ( ! ( net = virshCommandOptNetwork ( ctl , cmd , NULL ) ) )
return false ;
if ( vshCommandOptStringReq ( ctl , cmd , " uri " , & uri ) < 0 | |
vshCommandOptStringReq ( ctl , cmd , " key " , & key ) < 0 | |
vshCommandOptStringReq ( ctl , cmd , " set " , & set ) < 0 )
return false ;
if ( ( set | | edit ) & & ! key ) {
vshError ( ctl , " %s " ,
_ ( " namespace key is required when modifying metadata " ) ) ;
return false ;
}
if ( set | | rem ) {
if ( virNetworkSetMetadata ( net , VIR_NETWORK_METADATA_ELEMENT ,
set , key , uri , flags ) )
return false ;
if ( rem )
vshPrintExtra ( ctl , " %s \n " , _ ( " Metadata removed " ) ) ;
else
vshPrintExtra ( ctl , " %s \n " , _ ( " Metadata modified " ) ) ;
} else if ( edit ) {
# define EDIT_GET_XML \
virshNetworkGetEditMetadata ( ctl , net , uri , flags )
# define EDIT_NOT_CHANGED \
do { \
vshPrintExtra ( ctl , " %s " , _ ( " Metadata not changed " ) ) ; \
ret = true ; \
goto edit_cleanup ; \
} while ( 0 )
# define EDIT_DEFINE \
( virNetworkSetMetadata ( net , VIR_NETWORK_METADATA_ELEMENT , doc_edited , \
key , uri , flags ) = = 0 )
# include "virsh-edit.c"
vshPrintExtra ( ctl , " %s \n " , _ ( " Metadata modified " ) ) ;
} else {
g_autofree char * data = NULL ;
2023-08-25 14:22:59 +03:00
2023-08-16 21:47:12 +03:00
/* get */
if ( ! ( data = virNetworkGetMetadata ( net , VIR_NETWORK_METADATA_ELEMENT ,
uri , flags ) ) )
return false ;
vshPrint ( ctl , " %s \n " , data ) ;
}
ret = true ;
cleanup :
return ret ;
}
2012-07-23 10:02:14 +04:00
/*
* " net-dumpxml " command
*/
static const vshCmdInfo info_network_dumpxml [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " network information in XML " )
} ,
{ . name = " desc " ,
. data = N_ ( " Output the network information as an XML dump to stdout. " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_dumpxml [ ] = {
2018-05-15 14:18:21 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( 0 ) ,
2013-01-14 18:28:17 +04:00
{ . name = " inactive " ,
. type = VSH_OT_BOOL ,
2016-06-15 09:54:40 +03:00
. help = N_ ( " show inactive defined XML " )
2013-01-14 18:28:17 +04:00
} ,
2022-06-16 18:29:54 +03:00
{ . name = " xpath " ,
. type = VSH_OT_STRING ,
virsh: Require --xpath for *dumpxml
Historically, the dumpxml command reject any unknown arguments,
for instance:
virsh dumpxml fedora xxx
However, after v8.5.0-rc1~31 the second argument ('xxx') is
treated as an XPath, but it's not that clearly visible.
Therefore, require the --xpath switch, like this:
virsh dumpxml fedora --xpath xxx
Yes, this breaks already released virsh, but I think we can argue
that the pool of users of this particular function is very small.
We also document the argument being mandatory:
dumpxml [--inactive] [--security-info] [--update-cpu] [--migratable]
[--xpath EXPRESSION] [--wrap] domain
The sooner we do this change, the better.
The same applies for other *dumpxml functions (net-dumpxml,
pool-dumpxml, vol-dumpxl to name a few).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2103524
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
2022-07-08 13:45:42 +03:00
. flags = VSH_OFLAG_REQ_OPT ,
2022-06-16 18:29:54 +03:00
. completer = virshCompleteEmpty ,
. help = N_ ( " xpath expression to filter the XML document " )
} ,
{ . name = " wrap " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " wrap xpath results in an common root element " ) ,
} ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkDumpXML ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2022-06-16 18:29:54 +03:00
g_autofree char * xml = NULL ;
2012-07-23 10:02:14 +04:00
unsigned int flags = 0 ;
2022-06-16 18:29:54 +03:00
bool wrap = vshCommandOptBool ( cmd , " wrap " ) ;
const char * xpath = NULL ;
2012-07-23 10:02:14 +04:00
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , NULL ) ) )
2012-07-23 10:02:14 +04:00
return false ;
2021-09-24 02:49:10 +03:00
if ( vshCommandOptBool ( cmd , " inactive " ) )
2012-07-23 10:02:14 +04:00
flags | = VIR_NETWORK_XML_INACTIVE ;
2022-06-16 18:29:54 +03:00
if ( vshCommandOptStringQuiet ( ctl , cmd , " xpath " , & xpath ) < 0 )
2021-09-24 02:49:10 +03:00
return false ;
2012-07-23 10:02:14 +04:00
2022-06-16 18:29:54 +03:00
if ( ! ( xml = virNetworkGetXMLDesc ( network , flags ) ) )
return false ;
return virshDumpXML ( ctl , xml , " network " , xpath , wrap ) ;
2012-07-23 10:02:14 +04:00
}
/*
* " net-info " command
*/
static const vshCmdInfo info_network_info [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " network information " )
} ,
{ . name = " desc " ,
. data = N_ ( " Returns basic information about the network " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_info [ ] = {
2018-05-15 14:18:21 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( 0 ) ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkInfo ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2012-07-23 10:02:14 +04:00
char uuid [ VIR_UUID_STRING_BUFLEN ] ;
int autostart ;
int persistent = - 1 ;
int active = - 1 ;
2023-02-01 18:08:22 +03:00
g_autofree char * bridge = NULL ;
2012-07-23 10:02:14 +04:00
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , NULL ) ) )
2012-07-23 10:02:14 +04:00
return false ;
2013-11-19 10:20:57 +04:00
vshPrint ( ctl , " %-15s %s \n " , _ ( " Name: " ) , virNetworkGetName ( network ) ) ;
2012-07-23 10:02:14 +04:00
if ( virNetworkGetUUIDString ( network , uuid ) = = 0 )
2013-11-19 10:20:57 +04:00
vshPrint ( ctl , " %-15s %s \n " , _ ( " UUID: " ) , uuid ) ;
2012-07-23 10:02:14 +04:00
active = virNetworkIsActive ( network ) ;
if ( active > = 0 )
vshPrint ( ctl , " %-15s %s \n " , _ ( " Active: " ) , active ? _ ( " yes " ) : _ ( " no " ) ) ;
persistent = virNetworkIsPersistent ( network ) ;
if ( persistent < 0 )
vshPrint ( ctl , " %-15s %s \n " , _ ( " Persistent: " ) , _ ( " unknown " ) ) ;
else
vshPrint ( ctl , " %-15s %s \n " , _ ( " Persistent: " ) , persistent ? _ ( " yes " ) : _ ( " no " ) ) ;
if ( virNetworkGetAutostart ( network , & autostart ) < 0 )
vshPrint ( ctl , " %-15s %s \n " , _ ( " Autostart: " ) , _ ( " no autostart " ) ) ;
else
vshPrint ( ctl , " %-15s %s \n " , _ ( " Autostart: " ) , autostart ? _ ( " yes " ) : _ ( " no " ) ) ;
bridge = virNetworkGetBridgeName ( network ) ;
if ( bridge )
vshPrint ( ctl , " %-15s %s \n " , _ ( " Bridge: " ) , bridge ) ;
return true ;
}
2012-09-04 19:55:20 +04:00
static int
2015-06-15 19:53:58 +03:00
virshNetworkSorter ( const void * a , const void * b )
2012-09-04 19:55:20 +04:00
{
virNetworkPtr * na = ( virNetworkPtr * ) a ;
virNetworkPtr * nb = ( virNetworkPtr * ) b ;
if ( * na & & ! * nb )
return - 1 ;
if ( ! * na )
return * nb ! = NULL ;
return vshStrcasecmp ( virNetworkGetName ( * na ) ,
virNetworkGetName ( * nb ) ) ;
}
2015-06-15 19:53:58 +03:00
struct virshNetworkList {
2012-09-04 19:55:20 +04:00
virNetworkPtr * nets ;
size_t nnets ;
} ;
static void
2021-03-11 10:16:13 +03:00
virshNetworkListFree ( struct virshNetworkList * list )
2012-09-04 19:55:20 +04:00
{
Convert 'int i' to 'size_t i' in tools/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
size_t i ;
2012-09-04 19:55:20 +04:00
2013-08-27 15:27:50 +04:00
if ( list & & list - > nets ) {
2012-09-04 19:55:20 +04:00
for ( i = 0 ; i < list - > nnets ; i + + ) {
2021-09-26 11:57:38 +03:00
virshNetworkFree ( list - > nets [ i ] ) ;
2012-09-04 19:55:20 +04:00
}
2021-02-03 22:32:55 +03:00
g_free ( list - > nets ) ;
2012-09-04 19:55:20 +04:00
}
2021-02-03 22:32:55 +03:00
g_free ( list ) ;
2012-09-04 19:55:20 +04:00
}
2021-03-11 10:16:13 +03:00
static struct virshNetworkList *
2015-06-15 19:53:58 +03:00
virshNetworkListCollect ( vshControl * ctl ,
unsigned int flags )
2012-09-04 19:55:20 +04:00
{
2021-03-11 10:16:13 +03:00
struct virshNetworkList * list = g_new0 ( struct virshNetworkList , 1 ) ;
Convert 'int i' to 'size_t i' in tools/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
size_t i ;
2012-09-04 19:55:20 +04:00
int ret ;
char * * names = NULL ;
virNetworkPtr net ;
bool success = false ;
size_t deleted = 0 ;
int persistent ;
int autostart ;
int nActiveNets = 0 ;
int nInactiveNets = 0 ;
int nAllNets = 0 ;
2021-03-11 10:16:13 +03:00
virshControl * priv = ctl - > privData ;
2012-09-04 19:55:20 +04:00
2012-09-13 12:56:07 +04:00
/* try the list with flags support (0.10.2 and later) */
2015-06-15 19:53:58 +03:00
if ( ( ret = virConnectListAllNetworks ( priv - > conn ,
2012-09-04 19:55:20 +04:00
& list - > nets ,
flags ) ) > = 0 ) {
list - > nnets = ret ;
goto finished ;
}
/* check if the command is actually supported */
2012-09-13 12:56:07 +04:00
if ( last_error & & last_error - > code = = VIR_ERR_NO_SUPPORT )
2012-09-04 19:55:20 +04:00
goto fallback ;
if ( last_error & & last_error - > code = = VIR_ERR_INVALID_ARG ) {
/* try the new API again but mask non-guaranteed flags */
unsigned int newflags = flags & ( VIR_CONNECT_LIST_NETWORKS_ACTIVE |
VIR_CONNECT_LIST_NETWORKS_INACTIVE ) ;
vshResetLibvirtError ( ) ;
2015-06-15 19:53:58 +03:00
if ( ( ret = virConnectListAllNetworks ( priv - > conn , & list - > nets ,
2012-09-04 19:55:20 +04:00
newflags ) ) > = 0 ) {
list - > nnets = ret ;
goto filter ;
}
}
/* there was an error during the first or second call */
vshError ( ctl , " %s " , _ ( " Failed to list networks " ) ) ;
goto cleanup ;
2014-03-25 10:53:59 +04:00
fallback :
2012-09-13 12:56:07 +04:00
/* fall back to old method (0.10.1 and older) */
2012-09-04 19:55:20 +04:00
vshResetLibvirtError ( ) ;
/* Get the number of active networks */
2012-09-11 14:48:19 +04:00
if ( ! VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_FILTERS_ACTIVE ) | |
VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_ACTIVE ) ) {
2015-06-15 19:53:58 +03:00
if ( ( nActiveNets = virConnectNumOfNetworks ( priv - > conn ) ) < 0 ) {
2012-09-04 19:55:20 +04:00
vshError ( ctl , " %s " , _ ( " Failed to get the number of active networks " ) ) ;
goto cleanup ;
}
}
/* Get the number of inactive networks */
2012-09-11 14:48:19 +04:00
if ( ! VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_FILTERS_ACTIVE ) | |
VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_INACTIVE ) ) {
2015-06-15 19:53:58 +03:00
if ( ( nInactiveNets = virConnectNumOfDefinedNetworks ( priv - > conn ) ) < 0 ) {
2012-09-04 19:55:20 +04:00
vshError ( ctl , " %s " , _ ( " Failed to get the number of inactive networks " ) ) ;
goto cleanup ;
}
}
nAllNets = nActiveNets + nInactiveNets ;
if ( nAllNets = = 0 )
return list ;
2020-10-05 19:50:09 +03:00
names = g_new0 ( char * , nAllNets ) ;
2012-09-04 19:55:20 +04:00
/* Retrieve a list of active network names */
2012-09-11 14:48:19 +04:00
if ( ! VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_FILTERS_ACTIVE ) | |
VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_ACTIVE ) ) {
2015-06-15 19:53:58 +03:00
if ( virConnectListNetworks ( priv - > conn ,
2012-09-04 19:55:20 +04:00
names , nActiveNets ) < 0 ) {
vshError ( ctl , " %s " , _ ( " Failed to list active networks " ) ) ;
goto cleanup ;
}
}
/* Add the inactive networks to the end of the name list */
2012-09-11 14:48:19 +04:00
if ( ! VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_FILTERS_ACTIVE ) | |
VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_ACTIVE ) ) {
2015-06-15 19:53:58 +03:00
if ( virConnectListDefinedNetworks ( priv - > conn ,
2012-09-04 19:55:20 +04:00
& names [ nActiveNets ] ,
nInactiveNets ) < 0 ) {
vshError ( ctl , " %s " , _ ( " Failed to list inactive networks " ) ) ;
goto cleanup ;
}
}
2020-10-05 19:50:09 +03:00
list - > nets = g_new0 ( virNetworkPtr , nAllNets ) ;
2012-09-04 19:55:20 +04:00
list - > nnets = 0 ;
/* get active networks */
for ( i = 0 ; i < nActiveNets ; i + + ) {
2015-06-15 19:53:58 +03:00
if ( ! ( net = virNetworkLookupByName ( priv - > conn , names [ i ] ) ) )
2012-09-04 19:55:20 +04:00
continue ;
list - > nets [ list - > nnets + + ] = net ;
}
/* get inactive networks */
for ( i = 0 ; i < nInactiveNets ; i + + ) {
2015-06-15 19:53:58 +03:00
if ( ! ( net = virNetworkLookupByName ( priv - > conn , names [ i ] ) ) )
2012-09-04 19:55:20 +04:00
continue ;
list - > nets [ list - > nnets + + ] = net ;
}
/* truncate networks that weren't found */
deleted = nAllNets - list - > nnets ;
2014-03-25 10:53:59 +04:00
filter :
2012-09-04 19:55:20 +04:00
/* filter list the list if the list was acquired by fallback means */
for ( i = 0 ; i < list - > nnets ; i + + ) {
net = list - > nets [ i ] ;
/* persistence filter */
2012-09-11 14:48:19 +04:00
if ( VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_FILTERS_PERSISTENT ) ) {
2012-09-04 19:55:20 +04:00
if ( ( persistent = virNetworkIsPersistent ( net ) ) < 0 ) {
vshError ( ctl , " %s " , _ ( " Failed to get network persistence info " ) ) ;
goto cleanup ;
}
2012-09-11 14:48:19 +04:00
if ( ! ( ( VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_PERSISTENT ) & & persistent ) | |
( VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_TRANSIENT ) & & ! persistent ) ) )
2012-09-04 19:55:20 +04:00
goto remove_entry ;
}
/* autostart filter */
2012-09-11 14:48:19 +04:00
if ( VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_FILTERS_AUTOSTART ) ) {
2012-09-04 19:55:20 +04:00
if ( virNetworkGetAutostart ( net , & autostart ) < 0 ) {
vshError ( ctl , " %s " , _ ( " Failed to get network autostart state " ) ) ;
goto cleanup ;
}
2012-09-11 14:48:19 +04:00
if ( ! ( ( VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_AUTOSTART ) & & autostart ) | |
( VSH_MATCH ( VIR_CONNECT_LIST_NETWORKS_NO_AUTOSTART ) & & ! autostart ) ) )
2012-09-04 19:55:20 +04:00
goto remove_entry ;
}
/* the pool matched all filters, it may stay */
continue ;
2014-03-25 10:53:59 +04:00
remove_entry :
2012-09-04 19:55:20 +04:00
/* the pool has to be removed as it failed one of the filters */
2021-09-26 11:57:38 +03:00
g_clear_pointer ( & list - > nets [ i ] , virshNetworkFree ) ;
2012-09-04 19:55:20 +04:00
deleted + + ;
}
2014-03-25 10:53:59 +04:00
finished :
2012-09-04 19:55:20 +04:00
/* sort the list */
if ( list - > nets & & list - > nnets )
qsort ( list - > nets , list - > nnets ,
2015-06-15 19:53:58 +03:00
sizeof ( * list - > nets ) , virshNetworkSorter ) ;
2012-09-04 19:55:20 +04:00
/* truncate the list if filter simulation deleted entries */
if ( deleted )
VIR_SHRINK_N ( list - > nets , list - > nnets , deleted ) ;
success = true ;
2014-03-25 10:53:59 +04:00
cleanup :
2012-09-04 19:55:20 +04:00
for ( i = 0 ; i < nAllNets ; i + + )
VIR_FREE ( names [ i ] ) ;
VIR_FREE ( names ) ;
if ( ! success ) {
2022-01-28 20:42:45 +03:00
g_clear_pointer ( & list , virshNetworkListFree ) ;
2012-09-04 19:55:20 +04:00
}
return list ;
}
2012-07-23 10:02:14 +04:00
/*
* " net-list " command
*/
static const vshCmdInfo info_network_list [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " list networks " )
} ,
{ . name = " desc " ,
. data = N_ ( " Returns list of networks. " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_list [ ] = {
2013-01-14 18:28:17 +04:00
{ . name = " inactive " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list inactive networks " )
} ,
{ . name = " all " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list inactive & active networks " )
} ,
{ . name = " persistent " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list persistent networks " )
} ,
{ . name = " transient " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list transient networks " )
} ,
{ . name = " autostart " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list networks with autostart enabled " )
} ,
{ . name = " no-autostart " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list networks with autostart disabled " )
} ,
2015-06-08 17:13:28 +03:00
{ . name = " uuid " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list uuid's only " )
} ,
{ . name = " name " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list network names only " )
} ,
{ . name = " table " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list table (default) " )
} ,
2023-08-16 21:47:12 +03:00
{ . name = " title " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " show network title " )
} ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
2017-11-03 15:09:47 +03:00
# define FILTER(NAME, FLAG) \
if ( vshCommandOptBool ( cmd , NAME ) ) \
2015-06-08 17:13:14 +03:00
flags | = ( FLAG )
2012-07-23 10:02:14 +04:00
static bool
2019-10-14 15:44:29 +03:00
cmdNetworkList ( vshControl * ctl , const vshCmd * cmd G_GNUC_UNUSED )
2012-07-23 10:02:14 +04:00
{
2021-03-11 10:16:13 +03:00
struct virshNetworkList * list = NULL ;
Convert 'int i' to 'size_t i' in tools/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
size_t i ;
2015-06-08 17:13:28 +03:00
bool ret = false ;
bool optName = vshCommandOptBool ( cmd , " name " ) ;
2023-08-16 21:47:12 +03:00
bool optTitle = vshCommandOptBool ( cmd , " title " ) ;
2015-06-08 17:13:28 +03:00
bool optTable = vshCommandOptBool ( cmd , " table " ) ;
bool optUUID = vshCommandOptBool ( cmd , " uuid " ) ;
char uuid [ VIR_UUID_STRING_BUFLEN ] ;
2012-09-04 19:55:20 +04:00
unsigned int flags = VIR_CONNECT_LIST_NETWORKS_ACTIVE ;
2021-08-11 16:12:02 +03:00
g_autoptr ( vshTable ) table = NULL ;
2012-07-23 10:02:14 +04:00
2015-06-08 17:13:14 +03:00
if ( vshCommandOptBool ( cmd , " inactive " ) )
2012-09-04 19:55:20 +04:00
flags = VIR_CONNECT_LIST_NETWORKS_INACTIVE ;
2012-07-23 10:02:14 +04:00
2015-06-08 17:13:14 +03:00
if ( vshCommandOptBool ( cmd , " all " ) )
2012-09-04 19:55:20 +04:00
flags = VIR_CONNECT_LIST_NETWORKS_ACTIVE |
VIR_CONNECT_LIST_NETWORKS_INACTIVE ;
2012-07-23 10:02:14 +04:00
2015-06-08 17:13:14 +03:00
FILTER ( " persistent " , VIR_CONNECT_LIST_NETWORKS_PERSISTENT ) ;
FILTER ( " transient " , VIR_CONNECT_LIST_NETWORKS_TRANSIENT ) ;
2012-07-23 10:02:14 +04:00
2015-06-08 17:13:14 +03:00
FILTER ( " autostart " , VIR_CONNECT_LIST_NETWORKS_AUTOSTART ) ;
FILTER ( " no-autostart " , VIR_CONNECT_LIST_NETWORKS_NO_AUTOSTART ) ;
2012-07-23 10:02:14 +04:00
2015-06-08 17:13:28 +03:00
if ( optTable + optName + optUUID > 1 ) {
vshError ( ctl , " %s " ,
_ ( " Only one argument from --table, --name and --uuid "
" may be specified. " ) ) ;
return false ;
}
if ( ! optUUID & & ! optName )
optTable = true ;
2015-06-15 19:53:58 +03:00
if ( ! ( list = virshNetworkListCollect ( ctl , flags ) ) )
2012-09-04 19:55:20 +04:00
return false ;
2015-06-08 17:13:28 +03:00
if ( optTable ) {
2023-08-16 21:47:12 +03:00
if ( optTitle )
table = vshTableNew ( _ ( " Name " ) , _ ( " State " ) , _ ( " Autostart " ) ,
_ ( " Persistent " ) , _ ( " Title " ) , NULL ) ;
else
table = vshTableNew ( _ ( " Name " ) , _ ( " State " ) , _ ( " Autostart " ) ,
_ ( " Persistent " ) , NULL ) ;
2018-09-21 17:17:13 +03:00
if ( ! table )
goto cleanup ;
2015-06-08 17:13:28 +03:00
}
2012-07-23 10:02:14 +04:00
2012-09-04 19:55:20 +04:00
for ( i = 0 ; i < list - > nnets ; i + + ) {
virNetworkPtr network = list - > nets [ i ] ;
const char * autostartStr ;
int is_autostart = 0 ;
2015-06-08 17:13:28 +03:00
if ( optTable ) {
if ( virNetworkGetAutostart ( network , & is_autostart ) < 0 )
autostartStr = _ ( " no autostart " ) ;
else
autostartStr = is_autostart ? _ ( " yes " ) : _ ( " no " ) ;
2023-08-16 21:47:12 +03:00
if ( optTitle ) {
g_autofree char * title = NULL ;
if ( ! ( title = virshGetNetworkDescription ( ctl , network , true , 0 ) ) )
goto cleanup ;
if ( vshTableRowAppend ( table ,
virNetworkGetName ( network ) ,
virNetworkIsActive ( network ) ?
_ ( " active " ) : _ ( " inactive " ) ,
autostartStr ,
virNetworkIsPersistent ( network ) ?
_ ( " yes " ) : _ ( " no " ) ,
title ,
NULL ) < 0 )
goto cleanup ;
} else {
if ( vshTableRowAppend ( table ,
virNetworkGetName ( network ) ,
virNetworkIsActive ( network ) ?
_ ( " active " ) : _ ( " inactive " ) ,
autostartStr ,
virNetworkIsPersistent ( network ) ?
_ ( " yes " ) : _ ( " no " ) ,
NULL ) < 0 )
goto cleanup ;
}
2015-06-08 17:13:28 +03:00
} else if ( optUUID ) {
2023-08-16 21:47:12 +03:00
2015-06-08 17:13:28 +03:00
if ( virNetworkGetUUIDString ( network , uuid ) < 0 ) {
vshError ( ctl , " %s " , _ ( " Failed to get network's UUID " ) ) ;
goto cleanup ;
}
vshPrint ( ctl , " %s \n " , uuid ) ;
} else if ( optName ) {
vshPrint ( ctl , " %s \n " , virNetworkGetName ( network ) ) ;
}
2012-07-23 10:02:14 +04:00
}
2012-09-04 19:55:20 +04:00
2018-09-21 17:17:13 +03:00
if ( optTable )
vshTablePrintToStdout ( table , ctl ) ;
2015-06-08 17:13:28 +03:00
ret = true ;
cleanup :
2015-06-15 19:53:58 +03:00
virshNetworkListFree ( list ) ;
2015-06-08 17:13:28 +03:00
return ret ;
2012-07-23 10:02:14 +04:00
}
2015-06-08 17:13:14 +03:00
# undef FILTER
2012-07-23 10:02:14 +04:00
/*
* " net-name " command
*/
static const vshCmdInfo info_network_name [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " convert a network UUID to network name " )
} ,
{ . name = " desc " ,
. data = " "
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_name [ ] = {
2013-01-14 18:28:17 +04:00
{ . name = " network " ,
. type = VSH_OT_DATA ,
. flags = VSH_OFLAG_REQ ,
2020-09-11 10:13:08 +03:00
. completer = virshNetworkUUIDCompleter ,
2013-01-14 18:28:17 +04:00
. help = N_ ( " network uuid " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkName ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2012-07-23 10:02:14 +04:00
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetworkBy ( ctl , cmd , NULL ,
VIRSH_BYUUID ) ) )
2012-07-23 10:02:14 +04:00
return false ;
vshPrint ( ctl , " %s \n " , virNetworkGetName ( network ) ) ;
return true ;
}
/*
* " net-start " command
*/
static const vshCmdInfo info_network_start [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " start a (previously defined) inactive network " )
} ,
{ . name = " desc " ,
. data = N_ ( " Start a network. " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_start [ ] = {
2018-05-15 14:18:21 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( VIR_CONNECT_LIST_NETWORKS_INACTIVE ) ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkStart ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2012-07-23 10:02:14 +04:00
bool ret = true ;
const char * name = NULL ;
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , & name ) ) )
2012-07-23 10:02:14 +04:00
return false ;
if ( virNetworkCreate ( network ) = = 0 ) {
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network %1$s started \n " ) , name ) ;
2012-07-23 10:02:14 +04:00
} else {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " Failed to start network %1$s " ) , name ) ;
2012-07-23 10:02:14 +04:00
ret = false ;
}
return ret ;
}
/*
* " net-undefine " command
*/
static const vshCmdInfo info_network_undefine [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
2014-08-19 06:59:51 +04:00
. data = N_ ( " undefine a persistent network " )
2013-02-07 19:25:10 +04:00
} ,
{ . name = " desc " ,
2014-08-19 06:59:51 +04:00
. data = N_ ( " Undefine the configuration for a persistent network. " )
2013-02-07 19:25:10 +04:00
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_undefine [ ] = {
2018-05-15 14:18:21 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( VIR_CONNECT_LIST_NETWORKS_PERSISTENT ) ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkUndefine ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2012-07-23 10:02:14 +04:00
bool ret = true ;
const char * name ;
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , & name ) ) )
2012-07-23 10:02:14 +04:00
return false ;
if ( virNetworkUndefine ( network ) = = 0 ) {
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network %1$s has been undefined \n " ) , name ) ;
2012-07-23 10:02:14 +04:00
} else {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " Failed to undefine network %1$s " ) , name ) ;
2012-07-23 10:02:14 +04:00
ret = false ;
}
return ret ;
}
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
/*
* " net-update " command
*/
static const vshCmdInfo info_network_update [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " update parts of an existing network's configuration " )
} ,
{ . name = " desc " ,
. data = " "
} ,
{ . name = NULL }
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
} ;
static const vshCmdOptDef opts_network_update [ ] = {
2018-05-15 14:18:21 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( 0 ) ,
2013-01-14 18:28:17 +04:00
{ . name = " command " ,
. type = VSH_OT_DATA ,
. flags = VSH_OFLAG_REQ ,
2022-01-10 14:41:03 +03:00
. completer = virshNetworkUpdateCommandCompleter ,
2013-01-14 18:28:17 +04:00
. help = N_ ( " type of update (add-first, add-last (add), delete, or modify) " )
} ,
{ . name = " section " ,
. type = VSH_OT_DATA ,
. flags = VSH_OFLAG_REQ ,
2022-01-10 14:44:23 +03:00
. completer = virshNetworkUpdateSectionCompleter ,
2013-01-14 18:28:17 +04:00
. help = N_ ( " which section of network configuration to update " )
} ,
{ . name = " xml " ,
. type = VSH_OT_DATA ,
. flags = VSH_OFLAG_REQ ,
2021-09-15 18:26:35 +03:00
. completer = virshCompletePathLocalExisting ,
2013-01-14 18:28:17 +04:00
. help = N_ ( " name of file containing xml (or, if it starts with '<', the complete "
" xml element itself) to add/modify, or to be matched for search " )
} ,
{ . name = " parent-index " ,
. type = VSH_OT_INT ,
. help = N_ ( " which parent object to search through " )
} ,
2016-01-09 16:36:26 +03:00
VIRSH_COMMON_OPT_CONFIG ( N_ ( " affect next network startup " ) ) ,
2016-01-09 16:36:27 +03:00
VIRSH_COMMON_OPT_LIVE ( N_ ( " affect running network " ) ) ,
2016-01-09 16:36:28 +03:00
VIRSH_COMMON_OPT_CURRENT ( N_ ( " affect current state of network " ) ) ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
} ;
2021-07-19 14:23:29 +03:00
VIR_ENUM_IMPL ( virshNetworkUpdateCommand ,
2019-03-16 21:20:32 +03:00
VIR_NETWORK_UPDATE_COMMAND_LAST ,
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
" none " , " modify " , " delete " , " add-last " , " add-first " ) ;
2021-07-19 14:23:29 +03:00
VIR_ENUM_IMPL ( virshNetworkSection ,
2019-03-16 21:20:32 +03:00
VIR_NETWORK_SECTION_LAST ,
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
" none " , " bridge " , " domain " , " ip " , " ip-dhcp-host " ,
" ip-dhcp-range " , " forward " , " forward-interface " ,
" forward-pf " , " portgroup " , " dns-host " , " dns-txt " ,
" dns-srv " ) ;
static bool
cmdNetworkUpdate ( vshControl * ctl , const vshCmd * cmd )
{
bool ret = false ;
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
const char * commandStr = NULL ;
const char * sectionStr = NULL ;
int command , section , parentIndex = - 1 ;
const char * xml = NULL ;
2021-08-11 16:25:15 +03:00
g_autofree char * xmlFromFile = NULL ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
bool config = vshCommandOptBool ( cmd , " config " ) ;
bool live = vshCommandOptBool ( cmd , " live " ) ;
2016-02-22 15:33:20 +03:00
unsigned int flags = VIR_NETWORK_UPDATE_AFFECT_CURRENT ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
2016-02-22 15:33:20 +03:00
VSH_EXCLUSIVE_OPTIONS ( " current " , " live " ) ;
VSH_EXCLUSIVE_OPTIONS ( " current " , " config " ) ;
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , NULL ) ) )
2013-08-26 14:51:08 +04:00
return false ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
2013-01-21 20:22:17 +04:00
if ( vshCommandOptStringReq ( ctl , cmd , " command " , & commandStr ) < 0 )
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
goto cleanup ;
if ( STREQ ( commandStr , " add " ) ) {
/* "add" is a synonym for "add-last" */
command = VIR_NETWORK_UPDATE_COMMAND_ADD_LAST ;
} else {
2021-07-19 14:23:29 +03:00
command = virshNetworkUpdateCommandTypeFromString ( commandStr ) ;
2022-01-10 14:59:29 +03:00
if ( command < = 0 ) {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " unrecognized command name '%1$s' " ) , commandStr ) ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
goto cleanup ;
}
}
2013-01-21 20:22:17 +04:00
if ( vshCommandOptStringReq ( ctl , cmd , " section " , & sectionStr ) < 0 )
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
goto cleanup ;
2013-01-21 20:22:17 +04:00
2021-07-19 14:23:29 +03:00
section = virshNetworkSectionTypeFromString ( sectionStr ) ;
2022-01-10 14:59:29 +03:00
if ( section < = 0 ) {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " unrecognized section name '%1$s' " ) , sectionStr ) ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
goto cleanup ;
}
2015-06-02 12:17:29 +03:00
if ( vshCommandOptInt ( ctl , cmd , " parent-index " , & parentIndex ) < 0 )
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
goto cleanup ;
/* The goal is to have a full xml element in the "xml"
* string . This is provided in the - - xml option , either directly
* ( detected by the first character being " < " ) , or indirectly by
* supplying a filename ( first character isn ' t " < " ) that contains
* the desired xml .
*/
2013-01-21 20:22:17 +04:00
if ( vshCommandOptStringReq ( ctl , cmd , " xml " , & xml ) < 0 )
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
goto cleanup ;
if ( * xml ! = ' < ' ) {
/* contents of xmldata is actually the name of a file that
* contains the xml .
*/
if ( virFileReadAll ( xml , VSH_MAX_XML_FILE , & xmlFromFile ) < 0 )
goto cleanup ;
/* NB: the original xml is just a const char * that points
* to a string owned by the vshCmd object , and will be freed
* by vshCommandFree , so it ' s safe to lose its pointer here .
*/
xml = xmlFromFile ;
}
2016-02-22 15:33:20 +03:00
if ( config )
flags | = VIR_NETWORK_UPDATE_AFFECT_CONFIG ;
if ( live )
flags | = VIR_NETWORK_UPDATE_AFFECT_LIVE ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
if ( virNetworkUpdate ( network , command ,
section , parentIndex , xml , flags ) < 0 ) {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " Failed to update network %1$s " ) ,
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
virNetworkGetName ( network ) ) ;
goto cleanup ;
}
if ( config ) {
if ( live )
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Updated network %1$s persistent config and live state " ) ,
2016-11-04 17:22:26 +03:00
virNetworkGetName ( network ) ) ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
else
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Updated network %1$s persistent config " ) ,
2016-11-04 17:22:26 +03:00
virNetworkGetName ( network ) ) ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
} else if ( live ) {
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Updated network %1$s live state " ) ,
2016-11-04 17:22:26 +03:00
virNetworkGetName ( network ) ) ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
} else if ( virNetworkIsActive ( network ) ) {
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Updated network %1$s live state " ) ,
2016-11-04 17:22:26 +03:00
virNetworkGetName ( network ) ) ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
} else {
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Updated network %1$s persistent config " ) ,
2016-11-04 17:22:26 +03:00
virNetworkGetName ( network ) ) ;
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
}
ret = true ;
2014-03-25 10:53:59 +04:00
cleanup :
virsh: new net-update command
This command uses the new virNetworkUpdate() API to modify an existing
network definition, and optionally have those modifications take
effect immediately without restarting the network.
An example usage:
virsh net-update mynet add-last ip-dhcp-host \
"<host mac='00:11:22:33:44:55' ip='192.168.122.45'/>" \
--live --config
If you like, you can instead put the xml into a file, and call like
this:
virsh net-update mynet add ip-dhcp-host /tmp/myxml.xml
--live --config
virsh will autodetect whether the argument is itself an xml element,
or if it's a file, by looking at the first character - the first
character of an xml element is always "<", and the first character of
a file is almost always *not* "<" (in the rare case that it is, the
user could specify "./<filename...").
A --parent-index option is also available (to give the index within a
list of parent objects, e.g. the index of the parent <ip> element when
updating ip-dhcp-host elements), but is optional and at least for now
will probably be used rarely.
--live, --config, and --current options - if you specify --live, only
the live state of the network will be updated. If you also specify
--config, then the persistent configuration will also be updated;
these two commands can be given separately, or both together. If you
don't specify either (you can optionally specify "--current" for the
same effect), then the "current" config will be updated (i.e. if the
network is active, then only its live config is affected, but if the
network is inactive, only the persistent config is affected).
2012-09-19 15:38:43 +04:00
vshReportError ( ctl ) ;
return ret ;
}
2012-07-23 10:02:14 +04:00
/*
* " net-uuid " command
*/
static const vshCmdInfo info_network_uuid [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " convert a network name to network UUID " )
} ,
{ . name = " desc " ,
. data = " "
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_uuid [ ] = {
2018-05-15 14:18:22 +03:00
VIRSH_COMMON_OPT_NETWORK ( N_ ( " network name " ) , 0 ) ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static bool
cmdNetworkUuid ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2012-07-23 10:02:14 +04:00
char uuid [ VIR_UUID_STRING_BUFLEN ] ;
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetworkBy ( ctl , cmd , NULL ,
VIRSH_BYNAME ) ) )
2012-07-23 10:02:14 +04:00
return false ;
if ( virNetworkGetUUIDString ( network , uuid ) ! = - 1 )
vshPrint ( ctl , " %s \n " , uuid ) ;
else
vshError ( ctl , " %s " , _ ( " failed to get network UUID " ) ) ;
return true ;
}
/*
* " net-edit " command
*/
static const vshCmdInfo info_network_edit [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " edit XML configuration for a network " )
} ,
{ . name = " desc " ,
. data = N_ ( " Edit the XML configuration for a network. " )
} ,
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
static const vshCmdOptDef opts_network_edit [ ] = {
2018-05-15 14:18:21 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( 0 ) ,
2013-01-14 18:28:17 +04:00
{ . name = NULL }
2012-07-23 10:02:14 +04:00
} ;
2015-06-15 19:53:58 +03:00
static char * virshNetworkGetXMLDesc ( virNetworkPtr network )
2012-07-23 10:02:14 +04:00
{
unsigned int flags = VIR_NETWORK_XML_INACTIVE ;
char * doc = virNetworkGetXMLDesc ( network , flags ) ;
if ( ! doc & & last_error - > code = = VIR_ERR_INVALID_ARG ) {
/* The server side libvirt doesn't support
* VIR_NETWORK_XML_INACTIVE , so retry without it .
*/
2012-07-25 15:41:49 +04:00
vshResetLibvirtError ( ) ;
2012-07-23 10:02:14 +04:00
flags & = ~ VIR_NETWORK_XML_INACTIVE ;
doc = virNetworkGetXMLDesc ( network , flags ) ;
}
return doc ;
}
static bool
cmdNetworkEdit ( vshControl * ctl , const vshCmd * cmd )
{
bool ret = false ;
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
g_autoptr ( virshNetwork ) network_edited = NULL ;
2021-03-11 10:16:13 +03:00
virshControl * priv = ctl - > privData ;
2012-07-23 10:02:14 +04:00
2015-06-15 19:53:58 +03:00
network = virshCommandOptNetwork ( ctl , cmd , NULL ) ;
2012-07-23 10:02:14 +04:00
if ( network = = NULL )
goto cleanup ;
2015-06-15 19:53:58 +03:00
# define EDIT_GET_XML virshNetworkGetXMLDesc(network)
2017-11-03 15:09:47 +03:00
# define EDIT_NOT_CHANGED \
do { \
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network %1$s XML configuration not changed. \n " ) , \
2017-11-03 15:09:47 +03:00
virNetworkGetName ( network ) ) ; \
ret = true ; \
goto edit_cleanup ; \
2014-11-14 17:57:17 +03:00
} while ( 0 )
2012-07-23 10:02:14 +04:00
# define EDIT_DEFINE \
2015-06-15 19:53:58 +03:00
( network_edited = virNetworkDefineXML ( priv - > conn , doc_edited ) )
2012-07-23 10:02:14 +04:00
# include "virsh-edit.c"
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network %1$s XML configuration edited. \n " ) ,
2016-11-04 17:22:26 +03:00
virNetworkGetName ( network_edited ) ) ;
2012-07-23 10:02:14 +04:00
ret = true ;
cleanup :
return ret ;
}
2012-07-23 11:19:04 +04:00
2014-02-15 04:19:32 +04:00
/*
* " net-event " command
*/
2019-01-20 19:04:56 +03:00
VIR_ENUM_DECL ( virshNetworkEvent ) ;
2015-06-15 19:53:58 +03:00
VIR_ENUM_IMPL ( virshNetworkEvent ,
virsh: use more compact VIR_ENUM_IMPL
Dan Berrange suggested that using VIR_ENUM_IMPL is more compact
than open-coding switch statements, and still just as forceful
at making us remember to update lists if we add enum values
in the future. Make this change throughout virsh.
Sure enough, doing this change caught that we missed at least
VIR_STORAGE_VOL_NETDIR.
* tools/virsh-domain-monitor.c (vshDomainIOErrorToString)
(vshDomainControlStateToString, vshDomainStateToString)
(vshDomainStateReasonToString): Change switch to enum lookup.
(cmdDomControl, cmdDominfo): Update caller.
* tools/virsh-domain.c (vshDomainVcpuStateToString)
(vshDomainEventToString, vshDomainEventDetailToString): Change
switch to enum lookup.
(vshDomainBlockJobToString, vshDomainJobToString): New functions.
(cmdVcpuinfo, cmdBlockJob, cmdDomjobinfo, cmdEvent): Update
callers.
* tools/virsh-network.c (vshNetworkEventToString): Change switch
to enum lookup.
* tools/virsh-pool.c (vshStoragePoolStateToString): New function.
(cmdPoolList, cmdPoolInfo): Update callers.
* tools/virsh-volume.c (vshVolumeTypeToString): Change switch to
enum lookup.
(cmdVolInfo, cmdVolList): Update callers.
Signed-off-by: Eric Blake <eblake@redhat.com>
2014-02-21 23:55:06 +04:00
VIR_NETWORK_EVENT_LAST ,
N_ ( " Defined " ) ,
N_ ( " Undefined " ) ,
N_ ( " Started " ) ,
2019-01-20 19:30:15 +03:00
N_ ( " Stopped " ) ) ;
virsh: use more compact VIR_ENUM_IMPL
Dan Berrange suggested that using VIR_ENUM_IMPL is more compact
than open-coding switch statements, and still just as forceful
at making us remember to update lists if we add enum values
in the future. Make this change throughout virsh.
Sure enough, doing this change caught that we missed at least
VIR_STORAGE_VOL_NETDIR.
* tools/virsh-domain-monitor.c (vshDomainIOErrorToString)
(vshDomainControlStateToString, vshDomainStateToString)
(vshDomainStateReasonToString): Change switch to enum lookup.
(cmdDomControl, cmdDominfo): Update caller.
* tools/virsh-domain.c (vshDomainVcpuStateToString)
(vshDomainEventToString, vshDomainEventDetailToString): Change
switch to enum lookup.
(vshDomainBlockJobToString, vshDomainJobToString): New functions.
(cmdVcpuinfo, cmdBlockJob, cmdDomjobinfo, cmdEvent): Update
callers.
* tools/virsh-network.c (vshNetworkEventToString): Change switch
to enum lookup.
* tools/virsh-pool.c (vshStoragePoolStateToString): New function.
(cmdPoolList, cmdPoolInfo): Update callers.
* tools/virsh-volume.c (vshVolumeTypeToString): Change switch to
enum lookup.
(cmdVolInfo, cmdVolList): Update callers.
Signed-off-by: Eric Blake <eblake@redhat.com>
2014-02-21 23:55:06 +04:00
2014-02-15 04:19:32 +04:00
static const char *
2015-06-15 19:53:58 +03:00
virshNetworkEventToString ( int event )
2014-02-15 04:19:32 +04:00
{
2015-06-15 19:53:58 +03:00
const char * str = virshNetworkEventTypeToString ( event ) ;
virsh: use more compact VIR_ENUM_IMPL
Dan Berrange suggested that using VIR_ENUM_IMPL is more compact
than open-coding switch statements, and still just as forceful
at making us remember to update lists if we add enum values
in the future. Make this change throughout virsh.
Sure enough, doing this change caught that we missed at least
VIR_STORAGE_VOL_NETDIR.
* tools/virsh-domain-monitor.c (vshDomainIOErrorToString)
(vshDomainControlStateToString, vshDomainStateToString)
(vshDomainStateReasonToString): Change switch to enum lookup.
(cmdDomControl, cmdDominfo): Update caller.
* tools/virsh-domain.c (vshDomainVcpuStateToString)
(vshDomainEventToString, vshDomainEventDetailToString): Change
switch to enum lookup.
(vshDomainBlockJobToString, vshDomainJobToString): New functions.
(cmdVcpuinfo, cmdBlockJob, cmdDomjobinfo, cmdEvent): Update
callers.
* tools/virsh-network.c (vshNetworkEventToString): Change switch
to enum lookup.
* tools/virsh-pool.c (vshStoragePoolStateToString): New function.
(cmdPoolList, cmdPoolInfo): Update callers.
* tools/virsh-volume.c (vshVolumeTypeToString): Change switch to
enum lookup.
(cmdVolInfo, cmdVolList): Update callers.
Signed-off-by: Eric Blake <eblake@redhat.com>
2014-02-21 23:55:06 +04:00
return str ? _ ( str ) : _ ( " unknown " ) ;
2014-02-15 04:19:32 +04:00
}
2015-06-15 19:53:58 +03:00
struct virshNetEventData {
2014-02-15 04:19:32 +04:00
vshControl * ctl ;
bool loop ;
2016-01-08 13:50:55 +03:00
bool timestamp ;
2014-02-15 04:19:32 +04:00
int count ;
2019-03-05 06:17:38 +03:00
virshNetworkEventCallback * cb ;
2014-02-15 04:19:32 +04:00
} ;
2015-06-15 19:53:58 +03:00
typedef struct virshNetEventData virshNetEventData ;
2014-02-15 04:19:32 +04:00
2019-01-20 19:04:56 +03:00
VIR_ENUM_DECL ( virshNetworkEventId ) ;
2015-06-15 19:53:58 +03:00
VIR_ENUM_IMPL ( virshNetworkEventId ,
2014-02-15 04:19:32 +04:00
VIR_NETWORK_EVENT_ID_LAST ,
2019-01-20 19:30:15 +03:00
" lifecycle " ) ;
2014-02-15 04:19:32 +04:00
static void
2019-10-14 15:44:29 +03:00
vshEventLifecyclePrint ( virConnectPtr conn G_GNUC_UNUSED ,
2014-02-15 04:19:32 +04:00
virNetworkPtr net ,
int event ,
2019-10-14 15:44:29 +03:00
int detail G_GNUC_UNUSED ,
2014-02-15 04:19:32 +04:00
void * opaque )
{
2015-06-15 19:53:58 +03:00
virshNetEventData * data = opaque ;
2014-02-15 04:19:32 +04:00
if ( ! data - > loop & & data - > count )
return ;
2016-01-08 13:50:55 +03:00
if ( data - > timestamp ) {
char timestamp [ VIR_TIME_STRING_BUFLEN ] ;
if ( virTimeStringNowRaw ( timestamp ) < 0 )
timestamp [ 0 ] = ' \0 ' ;
2023-03-09 17:54:42 +03:00
vshPrint ( data - > ctl , _ ( " %1$s: event 'lifecycle' for network %2$s: %3$s \n " ) ,
2016-01-08 13:50:55 +03:00
timestamp ,
virNetworkGetName ( net ) , virshNetworkEventToString ( event ) ) ;
} else {
2023-03-09 17:54:42 +03:00
vshPrint ( data - > ctl , _ ( " event 'lifecycle' for network %1$s: %2$s \n " ) ,
2016-01-08 13:50:55 +03:00
virNetworkGetName ( net ) , virshNetworkEventToString ( event ) ) ;
}
2014-02-15 04:19:32 +04:00
data - > count + + ;
if ( ! data - > loop )
vshEventDone ( data - > ctl ) ;
}
2019-03-05 06:17:38 +03:00
virshNetworkEventCallback virshNetworkEventCallbacks [ ] = {
{ " lifecycle " ,
VIR_NETWORK_EVENT_CALLBACK ( vshEventLifecyclePrint ) , } ,
} ;
2020-01-09 13:39:55 +03:00
G_STATIC_ASSERT ( VIR_NETWORK_EVENT_ID_LAST = = G_N_ELEMENTS ( virshNetworkEventCallbacks ) ) ;
2019-03-05 06:17:38 +03:00
2014-02-15 04:19:32 +04:00
static const vshCmdInfo info_network_event [ ] = {
2014-03-31 17:05:33 +04:00
{ . name = " help " ,
2014-02-15 04:19:32 +04:00
. data = N_ ( " Network Events " )
} ,
{ . name = " desc " ,
. data = N_ ( " List event types, or wait for network events to occur " )
} ,
{ . name = NULL }
} ;
static const vshCmdOptDef opts_network_event [ ] = {
2018-05-15 14:18:20 +03:00
VIRSH_COMMON_OPT_NETWORK_OT_STRING ( N_ ( " filter by network name or uuid " ) , 0 ) ,
2014-02-15 04:19:32 +04:00
{ . name = " event " ,
2014-12-11 05:46:15 +03:00
. type = VSH_OT_STRING ,
2019-03-05 06:17:39 +03:00
. completer = virshNetworkEventNameCompleter ,
2014-02-15 04:19:32 +04:00
. help = N_ ( " which event type to wait for " )
} ,
{ . name = " loop " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " loop until timeout or interrupt, rather than one-shot " )
} ,
{ . name = " timeout " ,
. type = VSH_OT_INT ,
. help = N_ ( " timeout seconds " )
} ,
{ . name = " list " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list valid event types " )
} ,
2016-01-08 13:50:55 +03:00
{ . name = " timestamp " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " show timestamp for each printed event " )
} ,
2014-02-15 04:19:32 +04:00
{ . name = NULL }
} ;
static bool
cmdNetworkEvent ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) net = NULL ;
2014-02-15 04:19:32 +04:00
bool ret = false ;
int eventId = - 1 ;
int timeout = 0 ;
2015-06-15 19:53:58 +03:00
virshNetEventData data ;
2014-02-15 04:19:32 +04:00
const char * eventName = NULL ;
int event ;
2021-03-11 10:16:13 +03:00
virshControl * priv = ctl - > privData ;
2014-02-15 04:19:32 +04:00
if ( vshCommandOptBool ( cmd , " list " ) ) {
size_t i ;
for ( i = 0 ; i < VIR_NETWORK_EVENT_ID_LAST ; i + + )
2019-03-05 06:17:38 +03:00
vshPrint ( ctl , " %s \n " , virshNetworkEventCallbacks [ i ] . name ) ;
2014-02-15 04:19:32 +04:00
return true ;
}
2015-12-03 15:42:35 +03:00
if ( vshCommandOptStringReq ( ctl , cmd , " event " , & eventName ) < 0 )
2014-02-15 04:19:32 +04:00
return false ;
if ( ! eventName ) {
2016-09-06 14:14:34 +03:00
vshError ( ctl , " %s " , _ ( " either --list or --event <type> is required " ) ) ;
2014-02-15 04:19:32 +04:00
return false ;
}
2019-03-05 06:17:38 +03:00
for ( event = 0 ; event < VIR_NETWORK_EVENT_ID_LAST ; event + + )
if ( STREQ ( eventName , virshNetworkEventCallbacks [ event ] . name ) )
break ;
if ( event = = VIR_NETWORK_EVENT_ID_LAST ) {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " unknown event type %1$s " ) , eventName ) ;
2014-02-15 04:19:32 +04:00
return false ;
}
data . ctl = ctl ;
data . loop = vshCommandOptBool ( cmd , " loop " ) ;
2016-01-08 13:50:55 +03:00
data . timestamp = vshCommandOptBool ( cmd , " timestamp " ) ;
2014-02-15 04:19:32 +04:00
data . count = 0 ;
2019-03-05 06:17:38 +03:00
data . cb = & virshNetworkEventCallbacks [ event ] ;
2014-02-15 04:19:32 +04:00
if ( vshCommandOptTimeoutToMs ( ctl , cmd , & timeout ) < 0 )
return false ;
if ( vshCommandOptBool ( cmd , " network " ) )
2015-06-15 19:53:58 +03:00
net = virshCommandOptNetwork ( ctl , cmd , NULL ) ;
2014-02-15 04:19:32 +04:00
if ( vshEventStart ( ctl , timeout ) < 0 )
goto cleanup ;
2015-06-15 19:53:58 +03:00
if ( ( eventId = virConnectNetworkEventRegisterAny ( priv - > conn , net , event ,
2019-03-05 06:17:38 +03:00
data . cb - > cb ,
2014-02-15 04:19:32 +04:00
& data , NULL ) ) < 0 )
goto cleanup ;
switch ( vshEventWait ( ctl ) ) {
case VSH_EVENT_INTERRUPT :
vshPrint ( ctl , " %s " , _ ( " event loop interrupted \n " ) ) ;
break ;
case VSH_EVENT_TIMEOUT :
vshPrint ( ctl , " %s " , _ ( " event loop timed out \n " ) ) ;
break ;
case VSH_EVENT_DONE :
break ;
default :
goto cleanup ;
}
2023-03-09 17:54:42 +03:00
vshPrint ( ctl , _ ( " events received: %1$d \n " ) , data . count ) ;
2014-02-15 04:19:32 +04:00
if ( data . count )
ret = true ;
2014-03-25 10:53:59 +04:00
cleanup :
2014-02-15 04:19:32 +04:00
vshEventCleanup ( ctl ) ;
if ( eventId > = 0 & &
2015-06-15 19:53:58 +03:00
virConnectNetworkEventDeregisterAny ( priv - > conn , eventId ) < 0 )
2014-02-15 04:19:32 +04:00
ret = false ;
return ret ;
}
2014-06-24 01:01:52 +04:00
/*
* " net-dhcp-leases " command
*/
static const vshCmdInfo info_network_dhcp_leases [ ] = {
{ . name = " help " ,
. data = N_ ( " print lease info for a given network " )
} ,
{ . name = " desc " ,
. data = N_ ( " Print lease info for a given network " )
} ,
{ . name = NULL }
} ;
static const vshCmdOptDef opts_network_dhcp_leases [ ] = {
2020-09-11 10:13:15 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( VIR_CONNECT_LIST_NETWORKS_ACTIVE ) ,
2014-06-24 01:01:52 +04:00
{ . name = " mac " ,
2014-12-11 05:46:15 +03:00
. type = VSH_OT_STRING ,
2014-06-24 01:01:52 +04:00
. flags = VSH_OFLAG_NONE ,
2020-11-10 12:51:00 +03:00
. help = N_ ( " MAC address " ) ,
. completer = virshNetworkDhcpMacCompleter ,
2014-06-24 01:01:52 +04:00
} ,
{ . name = NULL }
} ;
static int
2015-06-15 19:53:58 +03:00
virshNetworkDHCPLeaseSorter ( const void * a , const void * b )
2014-06-24 01:01:52 +04:00
{
virNetworkDHCPLeasePtr * lease1 = ( virNetworkDHCPLeasePtr * ) a ;
virNetworkDHCPLeasePtr * lease2 = ( virNetworkDHCPLeasePtr * ) b ;
if ( * lease1 & & ! * lease2 )
return - 1 ;
if ( ! * lease1 )
return * lease2 ! = NULL ;
2019-10-17 11:10:10 +03:00
return vshStrcasecmp ( ( * lease1 ) - > mac , ( * lease2 ) - > mac ) ;
2014-06-24 01:01:52 +04:00
}
static bool
cmdNetworkDHCPLeases ( vshControl * ctl , const vshCmd * cmd )
{
const char * name = NULL ;
const char * mac = NULL ;
virNetworkDHCPLeasePtr * leases = NULL ;
int nleases = 0 ;
bool ret = false ;
size_t i ;
unsigned int flags = 0 ;
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2021-08-11 16:12:02 +03:00
g_autoptr ( vshTable ) table = NULL ;
2014-06-24 01:01:52 +04:00
2015-12-03 15:42:35 +03:00
if ( vshCommandOptStringReq ( ctl , cmd , " mac " , & mac ) < 0 )
2014-06-24 01:01:52 +04:00
return false ;
2015-06-15 19:53:58 +03:00
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , & name ) ) )
2014-06-24 01:01:52 +04:00
return false ;
2014-06-26 18:08:34 +04:00
if ( ( nleases = virNetworkGetDHCPLeases ( network , mac , & leases , flags ) ) < 0 ) {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " Failed to get leases info for %1$s " ) , name ) ;
2014-06-24 01:01:52 +04:00
goto cleanup ;
}
/* Sort the list according to MAC Address/IAID */
2015-06-15 19:53:58 +03:00
qsort ( leases , nleases , sizeof ( * leases ) , virshNetworkDHCPLeaseSorter ) ;
2014-06-24 01:01:52 +04:00
2018-09-21 17:17:13 +03:00
table = vshTableNew ( _ ( " Expiry Time " ) , _ ( " MAC address " ) , _ ( " Protocol " ) ,
_ ( " IP address " ) , _ ( " Hostname " ) , _ ( " Client ID or DUID " ) ,
NULL ) ;
if ( ! table )
goto cleanup ;
2014-06-24 01:01:52 +04:00
for ( i = 0 ; i < nleases ; i + + ) {
2014-09-04 23:08:49 +04:00
const char * typestr = NULL ;
2019-10-15 16:16:31 +03:00
g_autofree char * cidr_format = NULL ;
2014-06-24 01:01:52 +04:00
virNetworkDHCPLeasePtr lease = leases [ i ] ;
2020-01-09 17:07:15 +03:00
g_autoptr ( GDateTime ) then = g_date_time_new_from_unix_local ( lease - > expirytime ) ;
g_autofree char * thenstr = NULL ;
thenstr = g_date_time_format ( then , " %Y-%m-%d %H:%M:%S " ) ;
2014-06-24 01:01:52 +04:00
2014-09-04 23:08:49 +04:00
if ( lease - > type = = VIR_IP_ADDR_TYPE_IPV4 )
typestr = " ipv4 " ;
else if ( lease - > type = = VIR_IP_ADDR_TYPE_IPV6 )
typestr = " ipv6 " ;
2014-06-24 01:01:52 +04:00
2019-10-22 16:26:14 +03:00
cidr_format = g_strdup_printf ( " %s/%d " , lease - > ipaddr , lease - > prefix ) ;
2014-06-24 01:01:52 +04:00
2018-09-21 17:17:13 +03:00
if ( vshTableRowAppend ( table ,
2020-01-09 17:07:15 +03:00
thenstr ,
2019-02-12 19:11:11 +03:00
NULLSTR_MINUS ( lease - > mac ) ,
NULLSTR_MINUS ( typestr ) ,
NULLSTR_MINUS ( cidr_format ) ,
NULLSTR_MINUS ( lease - > hostname ) ,
NULLSTR_MINUS ( lease - > clientid ) ,
2018-09-21 17:17:13 +03:00
NULL ) < 0 )
goto cleanup ;
2014-06-24 01:01:52 +04:00
}
2018-09-21 17:17:13 +03:00
vshTablePrintToStdout ( table , ctl ) ;
2014-06-24 01:01:52 +04:00
ret = true ;
cleanup :
if ( leases ) {
for ( i = 0 ; i < nleases ; i + + )
virNetworkDHCPLeaseFree ( leases [ i ] ) ;
VIR_FREE ( leases ) ;
}
return ret ;
}
2018-12-12 19:58:31 +03:00
/*
* " net-port-create " command
*/
static const vshCmdInfo info_network_port_create [ ] = {
{ . name = " help " ,
. data = N_ ( " create a network port from an XML file " )
} ,
{ . name = " desc " ,
. data = N_ ( " Create a network port. " )
} ,
{ . name = NULL }
} ;
static const vshCmdOptDef opts_network_port_create [ ] = {
2020-09-11 10:13:16 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( VIR_CONNECT_LIST_NETWORKS_ACTIVE ) ,
2018-12-12 19:58:31 +03:00
VIRSH_COMMON_OPT_FILE ( N_ ( " file containing an XML network port description " ) ) ,
2021-08-26 15:23:57 +03:00
{ . name = " validate " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " validate the XML against the schema " )
} ,
2018-12-12 19:58:31 +03:00
{ . name = NULL }
} ;
static bool
cmdNetworkPortCreate ( vshControl * ctl , const vshCmd * cmd )
{
virNetworkPortPtr port = NULL ;
const char * from = NULL ;
bool ret = false ;
2023-02-01 18:08:22 +03:00
g_autofree char * buffer = NULL ;
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2021-08-26 15:23:57 +03:00
unsigned int flags = 0 ;
2018-12-12 19:58:31 +03:00
network = virshCommandOptNetwork ( ctl , cmd , NULL ) ;
if ( network = = NULL )
goto cleanup ;
if ( vshCommandOptStringReq ( ctl , cmd , " file " , & from ) < 0 )
goto cleanup ;
2021-08-26 15:23:57 +03:00
if ( vshCommandOptBool ( cmd , " validate " ) )
flags | = VIR_NETWORK_PORT_CREATE_VALIDATE ;
2020-09-16 10:17:34 +03:00
if ( virFileReadAll ( from , VSH_MAX_XML_FILE , & buffer ) < 0 ) {
vshSaveLibvirtError ( ) ;
2018-12-12 19:58:31 +03:00
goto cleanup ;
2020-09-16 10:17:34 +03:00
}
2018-12-12 19:58:31 +03:00
2021-08-26 15:23:57 +03:00
port = virNetworkPortCreateXML ( network , buffer , flags ) ;
2018-12-12 19:58:31 +03:00
if ( port ! = NULL ) {
char uuidstr [ VIR_UUID_STRING_BUFLEN ] ;
virNetworkPortGetUUIDString ( port , uuidstr ) ;
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network port %1$s created from %2$s \n " ) ,
2018-12-12 19:58:31 +03:00
uuidstr , from ) ;
} else {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " Failed to create network from %1$s " ) , from ) ;
2018-12-12 19:58:31 +03:00
goto cleanup ;
}
ret = true ;
cleanup :
if ( port )
virNetworkPortFree ( port ) ;
return ret ;
}
/*
* " net-port-dumpxml " command
*/
static const vshCmdInfo info_network_port_dumpxml [ ] = {
{ . name = " help " ,
. data = N_ ( " network port information in XML " )
} ,
{ . name = " desc " ,
. data = N_ ( " Output the network port information as an XML dump to stdout. " )
} ,
{ . name = NULL }
} ;
static const vshCmdOptDef opts_network_port_dumpxml [ ] = {
2020-09-11 10:13:16 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( VIR_CONNECT_LIST_NETWORKS_ACTIVE ) ,
2018-12-12 19:58:31 +03:00
VIRSH_COMMON_OPT_NETWORK_PORT ( 0 ) ,
2022-06-16 18:29:54 +03:00
{ . name = " xpath " ,
. type = VSH_OT_STRING ,
virsh: Require --xpath for *dumpxml
Historically, the dumpxml command reject any unknown arguments,
for instance:
virsh dumpxml fedora xxx
However, after v8.5.0-rc1~31 the second argument ('xxx') is
treated as an XPath, but it's not that clearly visible.
Therefore, require the --xpath switch, like this:
virsh dumpxml fedora --xpath xxx
Yes, this breaks already released virsh, but I think we can argue
that the pool of users of this particular function is very small.
We also document the argument being mandatory:
dumpxml [--inactive] [--security-info] [--update-cpu] [--migratable]
[--xpath EXPRESSION] [--wrap] domain
The sooner we do this change, the better.
The same applies for other *dumpxml functions (net-dumpxml,
pool-dumpxml, vol-dumpxl to name a few).
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2103524
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
2022-07-08 13:45:42 +03:00
. flags = VSH_OFLAG_REQ_OPT ,
2022-06-16 18:29:54 +03:00
. completer = virshCompleteEmpty ,
. help = N_ ( " xpath expression to filter the XML document " )
} ,
{ . name = " wrap " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " wrap xpath results in an common root element " ) ,
} ,
2018-12-12 19:58:31 +03:00
{ . name = NULL }
} ;
static bool
cmdNetworkPortDumpXML ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2018-12-12 19:58:31 +03:00
virNetworkPortPtr port = NULL ;
bool ret = true ;
2022-06-16 18:29:54 +03:00
g_autofree char * xml = NULL ;
2018-12-12 19:58:31 +03:00
unsigned int flags = 0 ;
2022-06-16 18:29:54 +03:00
bool wrap = vshCommandOptBool ( cmd , " wrap " ) ;
const char * xpath = NULL ;
2018-12-12 19:58:31 +03:00
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , NULL ) ) )
goto cleanup ;
if ( ! ( port = virshCommandOptNetworkPort ( ctl , cmd , network , NULL ) ) )
goto cleanup ;
2022-06-16 18:29:54 +03:00
if ( vshCommandOptStringQuiet ( ctl , cmd , " xpath " , & xpath ) < 0 )
return false ;
2018-12-12 19:58:31 +03:00
2022-06-16 18:29:54 +03:00
if ( ! ( xml = virNetworkPortGetXMLDesc ( port , flags ) ) )
goto cleanup ;
ret = virshDumpXML ( ctl , xml , " network-port " , xpath , wrap ) ;
2018-12-12 19:58:31 +03:00
cleanup :
if ( port )
virNetworkPortFree ( port ) ;
return ret ;
}
/*
* " net-port-delete " command
*/
static const vshCmdInfo info_network_port_delete [ ] = {
{ . name = " help " ,
2019-09-03 19:47:29 +03:00
. data = N_ ( " delete the specified network port " )
2018-12-12 19:58:31 +03:00
} ,
{ . name = " desc " ,
2019-09-03 19:47:29 +03:00
. data = N_ ( " Delete the specified network port. " )
2018-12-12 19:58:31 +03:00
} ,
{ . name = NULL }
} ;
static const vshCmdOptDef opts_network_port_delete [ ] = {
2020-09-11 10:13:16 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( VIR_CONNECT_LIST_NETWORKS_ACTIVE ) ,
2018-12-12 19:58:31 +03:00
VIRSH_COMMON_OPT_NETWORK_PORT ( 0 ) ,
{ . name = NULL }
} ;
static bool
cmdNetworkPortDelete ( vshControl * ctl , const vshCmd * cmd )
{
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2018-12-12 19:58:31 +03:00
virNetworkPortPtr port = NULL ;
bool ret = true ;
char uuidstr [ VIR_UUID_STRING_BUFLEN ] ;
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , NULL ) ) )
goto cleanup ;
if ( ! ( port = virshCommandOptNetworkPort ( ctl , cmd , network , NULL ) ) )
goto cleanup ;
if ( virNetworkPortGetUUIDString ( port , uuidstr ) < 0 )
goto cleanup ;
if ( virNetworkPortDelete ( port , 0 ) < 0 ) {
2023-03-09 17:54:42 +03:00
vshError ( ctl , _ ( " Failed to delete network port %1$s " ) , uuidstr ) ;
2018-12-12 19:58:31 +03:00
goto cleanup ;
} else {
2023-03-09 17:54:42 +03:00
vshPrintExtra ( ctl , _ ( " Network port %1$s deleted \n " ) , uuidstr ) ;
2018-12-12 19:58:31 +03:00
}
ret = true ;
cleanup :
if ( port )
virNetworkPortFree ( port ) ;
return ret ;
}
static int
virshNetworkPortSorter ( const void * a , const void * b )
{
virNetworkPortPtr * na = ( virNetworkPortPtr * ) a ;
virNetworkPortPtr * nb = ( virNetworkPortPtr * ) b ;
unsigned char uuida [ VIR_UUID_BUFLEN ] ;
unsigned char uuidb [ VIR_UUID_BUFLEN ] ;
if ( * na & & ! * nb )
return - 1 ;
if ( ! * na )
return * nb ! = NULL ;
if ( virNetworkPortGetUUID ( * na , uuida ) < 0 | |
virNetworkPortGetUUID ( * nb , uuidb ) < 0 )
return - 1 ;
return memcmp ( uuida , uuidb , VIR_UUID_BUFLEN ) ;
}
struct virshNetworkPortList {
virNetworkPortPtr * ports ;
size_t nports ;
} ;
static void
2021-03-11 10:16:13 +03:00
virshNetworkPortListFree ( struct virshNetworkPortList * list )
2018-12-12 19:58:31 +03:00
{
size_t i ;
if ( list & & list - > ports ) {
for ( i = 0 ; i < list - > nports ; i + + ) {
if ( list - > ports [ i ] )
virNetworkPortFree ( list - > ports [ i ] ) ;
}
2021-02-03 22:32:55 +03:00
g_free ( list - > ports ) ;
2018-12-12 19:58:31 +03:00
}
2021-02-03 22:32:55 +03:00
g_free ( list ) ;
2018-12-12 19:58:31 +03:00
}
2021-03-11 10:16:13 +03:00
static struct virshNetworkPortList *
2018-12-12 19:58:31 +03:00
virshNetworkPortListCollect ( vshControl * ctl ,
const vshCmd * cmd ,
unsigned int flags )
{
2021-03-11 10:16:13 +03:00
struct virshNetworkPortList * list = g_new0 ( struct virshNetworkPortList , 1 ) ;
2018-12-12 19:58:31 +03:00
int ret ;
2021-09-26 11:57:38 +03:00
g_autoptr ( virshNetwork ) network = NULL ;
2018-12-12 19:58:31 +03:00
bool success = false ;
if ( ! ( network = virshCommandOptNetwork ( ctl , cmd , NULL ) ) )
goto cleanup ;
if ( ( ret = virNetworkListAllPorts ( network ,
& list - > ports ,
flags ) ) < 0 )
goto cleanup ;
list - > nports = ret ;
/* sort the list */
if ( list - > ports & & list - > nports )
qsort ( list - > ports , list - > nports ,
sizeof ( * list - > ports ) , virshNetworkPortSorter ) ;
success = true ;
cleanup :
if ( ! success ) {
2022-01-28 20:42:45 +03:00
g_clear_pointer ( & list , virshNetworkPortListFree ) ;
2018-12-12 19:58:31 +03:00
}
return list ;
}
/*
* " net-list " command
*/
static const vshCmdInfo info_network_port_list [ ] = {
{ . name = " help " ,
. data = N_ ( " list network ports " )
} ,
{ . name = " desc " ,
. data = N_ ( " Returns list of network ports. " )
} ,
{ . name = NULL }
} ;
static const vshCmdOptDef opts_network_port_list [ ] = {
2020-09-11 10:13:16 +03:00
VIRSH_COMMON_OPT_NETWORK_FULL ( VIR_CONNECT_LIST_NETWORKS_ACTIVE ) ,
2018-12-12 19:58:31 +03:00
{ . name = " uuid " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list uuid's only " )
} ,
{ . name = " table " ,
. type = VSH_OT_BOOL ,
. help = N_ ( " list table (default) " )
} ,
{ . name = NULL }
} ;
static bool
cmdNetworkPortList ( vshControl * ctl , const vshCmd * cmd )
{
2021-03-11 10:16:13 +03:00
struct virshNetworkPortList * list = NULL ;
2018-12-12 19:58:31 +03:00
size_t i ;
bool ret = false ;
bool optTable = vshCommandOptBool ( cmd , " table " ) ;
bool optUUID = vshCommandOptBool ( cmd , " uuid " ) ;
char uuid [ VIR_UUID_STRING_BUFLEN ] ;
unsigned int flags = 0 ;
2021-08-11 16:12:02 +03:00
g_autoptr ( vshTable ) table = NULL ;
2018-12-12 19:58:31 +03:00
if ( optTable + optUUID > 1 ) {
vshError ( ctl , " %s " ,
_ ( " Only one argument from --table and --uuid "
" may be specified. " ) ) ;
return false ;
}
if ( ! optUUID )
optTable = true ;
if ( ! ( list = virshNetworkPortListCollect ( ctl , cmd , flags ) ) )
return false ;
if ( optTable ) {
table = vshTableNew ( _ ( " UUID " ) , NULL ) ;
if ( ! table )
goto cleanup ;
}
for ( i = 0 ; i < list - > nports ; i + + ) {
virNetworkPortPtr port = list - > ports [ i ] ;
if ( virNetworkPortGetUUIDString ( port , uuid ) < 0 ) {
vshError ( ctl , " %s " , _ ( " Failed to get network's UUID " ) ) ;
goto cleanup ;
}
if ( optTable ) {
if ( vshTableRowAppend ( table , uuid , NULL ) < 0 )
goto cleanup ;
} else if ( optUUID ) {
vshPrint ( ctl , " %s \n " , uuid ) ;
}
}
if ( optTable )
vshTablePrintToStdout ( table , ctl ) ;
ret = true ;
cleanup :
virshNetworkPortListFree ( list ) ;
return ret ;
}
2012-08-21 01:43:25 +04:00
const vshCmdDef networkCmds [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " net-autostart " ,
. handler = cmdNetworkAutostart ,
. opts = opts_network_autostart ,
. info = info_network_autostart ,
. flags = 0
} ,
{ . name = " net-create " ,
. handler = cmdNetworkCreate ,
. opts = opts_network_create ,
. info = info_network_create ,
. flags = 0
} ,
{ . name = " net-define " ,
. handler = cmdNetworkDefine ,
. opts = opts_network_define ,
. info = info_network_define ,
. flags = 0
} ,
2023-08-16 21:47:12 +03:00
{ . name = " net-desc " ,
. handler = cmdNetworkDesc ,
. opts = opts_network_desc ,
. info = info_network_desc ,
. flags = 0
} ,
2013-02-07 19:25:10 +04:00
{ . name = " net-destroy " ,
. handler = cmdNetworkDestroy ,
. opts = opts_network_destroy ,
. info = info_network_destroy ,
. flags = 0
} ,
2014-06-24 01:01:52 +04:00
{ . name = " net-dhcp-leases " ,
. handler = cmdNetworkDHCPLeases ,
. opts = opts_network_dhcp_leases ,
. info = info_network_dhcp_leases ,
. flags = 0 ,
} ,
2013-02-07 19:25:10 +04:00
{ . name = " net-dumpxml " ,
. handler = cmdNetworkDumpXML ,
. opts = opts_network_dumpxml ,
. info = info_network_dumpxml ,
. flags = 0
} ,
{ . name = " net-edit " ,
. handler = cmdNetworkEdit ,
. opts = opts_network_edit ,
. info = info_network_edit ,
. flags = 0
} ,
2014-02-15 04:19:32 +04:00
{ . name = " net-event " ,
. handler = cmdNetworkEvent ,
. opts = opts_network_event ,
. info = info_network_event ,
. flags = 0
} ,
2013-02-07 19:25:10 +04:00
{ . name = " net-info " ,
. handler = cmdNetworkInfo ,
. opts = opts_network_info ,
. info = info_network_info ,
. flags = 0
} ,
{ . name = " net-list " ,
. handler = cmdNetworkList ,
. opts = opts_network_list ,
. info = info_network_list ,
. flags = 0
} ,
2023-08-16 21:47:12 +03:00
{ . name = " net-metadata " ,
. handler = cmdNetworkMetadata ,
. opts = opts_network_metadata ,
. info = info_network_metadata ,
. flags = 0
} ,
2013-02-07 19:25:10 +04:00
{ . name = " net-name " ,
. handler = cmdNetworkName ,
. opts = opts_network_name ,
. info = info_network_name ,
. flags = 0
} ,
{ . name = " net-start " ,
. handler = cmdNetworkStart ,
. opts = opts_network_start ,
. info = info_network_start ,
. flags = 0
} ,
{ . name = " net-undefine " ,
. handler = cmdNetworkUndefine ,
. opts = opts_network_undefine ,
. info = info_network_undefine ,
. flags = 0
} ,
{ . name = " net-update " ,
. handler = cmdNetworkUpdate ,
. opts = opts_network_update ,
. info = info_network_update ,
. flags = 0
} ,
{ . name = " net-uuid " ,
. handler = cmdNetworkUuid ,
. opts = opts_network_uuid ,
. info = info_network_uuid ,
. flags = 0
} ,
2018-12-12 19:58:31 +03:00
{ . name = " net-port-list " ,
. handler = cmdNetworkPortList ,
. opts = opts_network_port_list ,
. info = info_network_port_list ,
. flags = 0
} ,
{ . name = " net-port-create " ,
. handler = cmdNetworkPortCreate ,
. opts = opts_network_port_create ,
. info = info_network_port_create ,
. flags = 0
} ,
{ . name = " net-port-dumpxml " ,
. handler = cmdNetworkPortDumpXML ,
. opts = opts_network_port_dumpxml ,
. info = info_network_port_dumpxml ,
. flags = 0
} ,
{ . name = " net-port-delete " ,
. handler = cmdNetworkPortDelete ,
. opts = opts_network_port_delete ,
. info = info_network_port_delete ,
. flags = 0
} ,
2013-02-07 19:25:10 +04:00
{ . name = NULL }
2012-07-23 11:19:04 +04:00
} ;