2011-09-20 02:34:10 +04:00
# 'git shortlog --help' and look for mailmap for the format of each line
# Email consolidation:
2011-04-21 03:00:30 +04:00
# <Preferred address in AUTHORS> <other alias used by same author>
2010-05-28 13:27:12 +04:00
<bozzolan@gmail.com> <redshift@gmx.com>
<charles_duffy@messageone.com> <charles@dyfis.net>
2014-12-21 02:12:00 +03:00
<claudio.bley@gmail.com> <cbley@av-test.de>
2010-05-28 13:27:12 +04:00
<dfj@redhat.com> <dfj@dfj.bne.redhat.com>
2015-03-20 15:16:01 +03:00
<dpkshetty@gmail.com> <deepakcs@linux.vnet.ibm.com>
<dpkshetty@gmail.com> <deepakcs@redhat.com>
2010-05-28 13:27:12 +04:00
<eblake@redhat.com> <ebb9@byu.net>
<gdolley@arpnetworks.com> <gdolley@ucla.edu>
<gerhard.stenzel@de.ibm.com> <gstenzel@linux.vnet.ibm.com>
<jamie@canonical.com> <jamie@ubuntu.com>
<laine@redhat.com> <laine@laine.org>
<meyering@redhat.com> <jim@meyering.net>
<socketpair@gmail.com> <socketpair gmail com>
2010-08-10 18:13:22 +04:00
<soren@linux2go.dk> <soren@ubuntu.com>
2011-09-02 02:13:34 +04:00
<jfehlig@suse.com> <jfehlig@novell.com>
<jfehlig@suse.com> <jfehlig@linux-ypgk.site>
2010-07-09 13:35:39 +04:00
<jclift@redhat.com> <justin@salasaga.org>
2010-07-23 13:43:45 +04:00
<berrange@redhat.com> <dan@berrange.com>
2010-08-10 18:13:22 +04:00
<soren@linux2go.dk> <soren@canonical.com>
2011-04-14 13:22:35 +04:00
<cfergeau@redhat.com> <teuf@gnome.org>
2011-04-21 03:00:30 +04:00
<wency@cn.fujitsu.com> <wency cn fujitsu com>
2011-05-21 00:18:09 +04:00
<cardoe@cardoe.com> <cardoe@gentoo.org>
2011-05-13 14:11:47 +04:00
<fsimonce@redhat.com> <federico.simoncelli@gmail.com>
2011-06-14 15:35:48 +04:00
<marcandre.lureau@redhat.com> <marcandre.lureau@gmail.com>
2011-06-30 12:22:20 +04:00
<supriyak@linux.vnet.ibm.com> <supriyak@in.ibm.com>
2011-10-03 13:58:55 +04:00
<neil@aldur.co.uk> <neil@brightbox.co.uk>
2011-11-11 19:22:23 +04:00
<stefanb@us.ibm.com> <stefanb@linux.vnet.ibm.com>
2012-08-10 01:31:58 +04:00
<stefanb@us.ibm.com> <stefannb@linux.vnet.ibm.com>
2012-07-02 22:55:26 +04:00
<josh.durgin@inktank.com> <joshd@hq.newdream.net>
<josh.durgin@inktank.com> <josh.durgin@dreamhost.com>
2012-07-30 12:42:59 +04:00
<gerd@egidy.de> <lists@egidy.de>
<gerd@egidy.de> <gerd.von.egidy@intra2net.com>
network: fix dnsmasq/radvd binding to IPv6 on recent kernels
I hit this problem recently when trying to create a bridge with an IPv6
address on a 3.2 kernel: dnsmasq (and, further, radvd) would not bind to
the given address, waiting 20s and then giving up with -EADDRNOTAVAIL
(resp. exiting immediately with "error parsing or activating the config
file", without libvirt noticing it, BTW). This can be reproduced with (I
think) any kernel >= 2.6.39 and the following XML (to be used with
"virsh net-create"):
<network>
<name>test-bridge</name>
<bridge name='testbr0' />
<ip family='ipv6' address='fd00::1' prefix='64'>
</ip>
</network>
(it happens even when you have an IPv4, too)
The problem is that since commit [1] (which, ironically, was made to
“help IPv6 autoconfiguration”) the linux bridge code makes bridges
behave like “real” devices regarding carrier detection. This makes the
bridges created by libvirt, which are started without any up devices,
stay with the NO-CARRIER flag set, and thus prevents DAD (Duplicate
address detection) from happening, thus letting the IPv6 address flagged
as “tentative”. Such addresses cannot be bound to (see RFC 2462), so
dnsmasq fails binding to it (for radvd, it detects that "interface XXX
is not RUNNING", thus that "interface XXX does not exist, ignoring the
interface" (sic)). It seems that this behavior was enhanced somehow with
commit [2] by avoiding setting NO-CARRIER on empty bridges, but I
couldn't reproduce this behavior on my kernel. Anyway, with the “dummy
tap to set MAC address” trick, this wouldn't work.
To fix this, the idea is to get the bridge's attached device to be up so
that DAD can happen (deactivating DAD altogether is not a good idea, I
think). Currently, libvirt creates a dummy TAP device to set the MAC
address of the bridge, keeping it down. But even if we set this device
up, it is not RUNNING as soon as the tap file descriptor attached to it
is closed, thus still preventing DAD. So, we must modify the API a bit,
so that we can get the fd, keep the tap device persistent, run the
daemons, and close it after DAD has taken place. After that, the bridge
will be flagged NO-CARRIER again, but the daemons will be running, even
if not happy about the device's state (but we don't really care about
the bridge's daemons doing anything when no up interface is connected to
it).
Other solutions that I envisioned were:
* Keeping the *-nic interface up: this would waste an fd for each
bridge during all its life. May be acceptable, I don't really
know.
* Stop using the dummy tap trick, and set the MAC address directly
on the bridge: it is possible since quite some time it seems,
even if then there is the problem of the bridge not being
RUNNING when empty, contrary to what [2] says, so this will need
fixing (and this fix only happened in 3.1, so it wouldn't work
for 2.6.39)
* Using the --interface option of dnsmasq, but I saw somewhere
that it's not used by libvirt for backward compatibility. I am
not sure this would solve this problem, though, as I don't know
how dnsmasq binds itself to it with this option.
This is why this patch does what's described earlier.
This patch also makes radvd start even if the interface is
“missing” (i.e. it is not RUNNING), as it daemonizes before binding to
it, and thus sometimes does it after the interface has been brought down
by us (by closing the tap fd), and then originally stops. This also
makes it stop yelling about it in the logs when the interface is down at
a later time.
[1]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=1faa4356a3bd89ea11fb92752d897cff3a20ec0e
[2]
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=b64b73d7d0c480f75684519c6134e79d50c1b341
2012-09-26 23:02:20 +04:00
<benoar@dolka.fr> <benjamin.cama@telecom-bretagne.eu>
2012-10-15 13:07:49 +04:00
<zhlcindy@linux.vnet.ibm.com> <zhlcindy@gmail.com>
2012-10-13 03:50:19 +04:00
<serge.hallyn@canonical.com> <serue@us.ibm.com>
<pritesh.kothari@sun.com> <Pritesh.Kothari@Sun.COM>
2011-09-20 02:34:10 +04:00
# Name consolidation:
# Preferred author spelling <preferred email>
Alex Jia <ajia@redhat.com>
2012-07-09 22:08:52 +04:00
Royce Lv <lvroyce@linux.vnet.ibm.com>
2012-07-19 01:34:53 +04:00
Daniel J Walsh <dwalsh@redhat.com>
2012-07-26 18:05:51 +04:00
Ján Tomko <jtomko@redhat.com>
2012-07-30 12:42:59 +04:00
Gerd von Egidy <gerd@egidy.de>
2012-10-13 03:50:19 +04:00
MATSUDA Daiki <matsudadik@intellilink.co.jp>
Tang Chen <tangchen@cn.fujitsu.com>
Peng Zhou <ailvpeng25@gmail.com>
Dirk Herrendoerfer <d.herrendoerfer@herrendoerfer.name>
Thibault VINCENT <thibault.vincent@smartjog.com>
Aurelien Rougemont <beorn@binaries.fr>
Serge E. Hallyn <serge.hallyn@canonical.com>
Henrik Persson E <henrik.e.persson@ericsson.com>
Philipp Hahn <hahn@univention.de>
Marco Bozzolan <bozzolan@gmail.com>
Marco Bozzolan <redshift@gmx.com>
Pritesh Kothari <pritesh.kothari@sun.com>
2014-10-06 18:23:47 +04:00
Wang Yufei (James) <james.wangyufei@huawei.com>
2015-03-20 15:16:01 +03:00
Deepak C Shetty <dpkshetty@gmail.com>
2018-01-25 12:42:14 +03:00
Daniel P. Berrangé <berrange@redhat.com>