2012-07-23 10:15:55 +04:00
/*
2012-08-21 02:56:03 +04:00
* virsh - nwfilter . c : Commands to manage network filters
2012-07-23 10:15:55 +04:00
*
2013-05-09 22:59:04 +04:00
* Copyright ( C ) 2005 , 2007 - 2013 Red Hat , Inc .
2012-07-23 10:15:55 +04:00
*
* This library is free software ; you can redistribute it and / or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation ; either
* version 2.1 of the License , or ( at your option ) any later version .
*
* This library is distributed in the hope that it will be useful ,
* but WITHOUT ANY WARRANTY ; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the GNU
* Lesser General Public License for more details .
*
* You should have received a copy of the GNU Lesser General Public
2012-09-21 02:30:55 +04:00
* License along with this library . If not , see
2012-07-23 10:15:55 +04:00
* < http : //www.gnu.org/licenses/>.
*
* Daniel Veillard < veillard @ redhat . com >
* Karel Zak < kzak @ redhat . com >
* Daniel P . Berrange < berrange @ redhat . com >
*
*/
2012-08-21 02:56:03 +04:00
# include <config.h>
# include "virsh-nwfilter.h"
2012-07-23 10:15:55 +04:00
2012-08-21 02:56:03 +04:00
# include <libxml/parser.h>
# include <libxml/tree.h>
# include <libxml/xpath.h>
# include <libxml/xmlsave.h>
# include "internal.h"
2012-12-04 16:04:07 +04:00
# include "virbuffer.h"
2012-12-12 22:06:53 +04:00
# include "viralloc.h"
2013-05-09 22:59:04 +04:00
# include "virfile.h"
2012-12-13 21:44:57 +04:00
# include "virutil.h"
2012-12-13 22:13:21 +04:00
# include "virxml.h"
2012-08-21 02:56:03 +04:00
virNWFilterPtr
2012-07-23 10:15:55 +04:00
vshCommandOptNWFilterBy ( vshControl * ctl , const vshCmd * cmd ,
2012-08-21 02:56:03 +04:00
const char * * name , unsigned int flags )
2012-07-23 10:15:55 +04:00
{
virNWFilterPtr nwfilter = NULL ;
const char * n = NULL ;
const char * optname = " nwfilter " ;
2012-08-21 02:56:03 +04:00
virCheckFlags ( VSH_BYUUID | VSH_BYNAME , NULL ) ;
2012-08-21 00:29:27 +04:00
if ( ! vshCmdHasOption ( ctl , cmd , optname ) )
2012-07-23 10:15:55 +04:00
return NULL ;
2013-01-21 21:18:41 +04:00
if ( vshCommandOptStringReq ( ctl , cmd , optname , & n ) < 0 )
2012-07-23 10:15:55 +04:00
return NULL ;
vshDebug ( ctl , VSH_ERR_INFO , " %s: found option <%s>: %s \n " ,
cmd - > def - > name , optname , n ) ;
if ( name )
* name = n ;
/* try it by UUID */
2012-08-21 02:56:03 +04:00
if ( ( flags & VSH_BYUUID ) & & strlen ( n ) = = VIR_UUID_STRING_BUFLEN - 1 ) {
2012-07-23 10:15:55 +04:00
vshDebug ( ctl , VSH_ERR_DEBUG , " %s: <%s> trying as nwfilter UUID \n " ,
cmd - > def - > name , optname ) ;
nwfilter = virNWFilterLookupByUUIDString ( ctl - > conn , n ) ;
}
/* try it by NAME */
2012-08-21 02:56:03 +04:00
if ( ! nwfilter & & ( flags & VSH_BYNAME ) ) {
2012-07-23 10:15:55 +04:00
vshDebug ( ctl , VSH_ERR_DEBUG , " %s: <%s> trying as nwfilter NAME \n " ,
cmd - > def - > name , optname ) ;
nwfilter = virNWFilterLookupByName ( ctl - > conn , n ) ;
}
if ( ! nwfilter )
vshError ( ctl , _ ( " failed to get nwfilter '%s' " ) , n ) ;
return nwfilter ;
}
/*
* " nwfilter-define " command
*/
static const vshCmdInfo info_nwfilter_define [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " define or update a network filter from an XML file " )
} ,
{ . name = " desc " ,
. data = N_ ( " Define a new network filter or update an existing one. " )
} ,
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static const vshCmdOptDef opts_nwfilter_define [ ] = {
2013-01-14 18:32:22 +04:00
{ . name = " file " ,
. type = VSH_OT_DATA ,
. flags = VSH_OFLAG_REQ ,
. help = N_ ( " file containing an XML network filter description " )
} ,
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static bool
cmdNWFilterDefine ( vshControl * ctl , const vshCmd * cmd )
{
virNWFilterPtr nwfilter ;
const char * from = NULL ;
bool ret = true ;
char * buffer ;
2013-01-21 21:18:41 +04:00
if ( vshCommandOptStringReq ( ctl , cmd , " file " , & from ) < 0 )
2012-07-23 10:15:55 +04:00
return false ;
virsh: use common namespacing
Convert the exported items in virsh.h to use a common 'vsh' prefix.
* tools/virsh.h (VIRSH_MAX_XML_FILE): Rename...
(VSH_MAX_XML_FILE): ...and parenthesize.
(DIFF_MSEC, CTRL_CLOSE_BRACKET): Delete.
(vshUsage, vshInit, vshDeinit, vshParseArgv): Remove prototype.
(editWriteToTempFile, editFile, editReadBackFile, prettyCapacity)
(virshReportError): Rename...
(vshEditWriteToTempFile, vshEditFile, vshEditReadBackFile)
(vshPrettyCapacity, vshReportError): ...into vsh namespace.
(jobWatchTimeoutFunc): Move to virsh-domain.c.
* tools/virsh.c (vshCommandRun): Inline former DIFF_MSEC.
(main): Inline former CTRL_CLOSE_BRACKET.
(vshUsage, vshInit, vshDeinit, vshParseArgv): Make static.
(prettyCapacity, virshReportError, editWriteToTempFile, editFile):
Fix naming, and adjust usage.
(vshAskReedit, vshCommandRun, vshEventLoop, vshInit): Adjust
usage.
* tools/virsh-domain.c (cmdAttachDevice, cmdCPUCompare)
(cmdCPUBaseline, cmdCreate, cmdDefine, cmdDetachDevice)
(cmdUpdateDevice, cmdDesc, cmdUndefine, cmdStart, cmdVcpucount)
(cmdAttachDevice, cmdDomjobinfo): Likewise.
* tools/virsh-edit.c (do): Likewise.
* tools/virsh-interface.c (cmdInterfaceDefine): Likewise.
* tools/virsh-network.c (cmdNetworkCreate, cmdNetworkDefine):
Likewise.
* tools/virsh-nodedev.c (cmdNodeDeviceCreate): Likewise.
* tools/virsh-nwfilter.c (cmdNWFilterDefine): Likewise.
* tools/virsh-pool.c (cmdPoolCreate, cmdPoolDefine)
(cmdPoolDiscoverSources, cmdPoolList): Likewise.
* tools/virsh-secret.c (cmdSecretDefine): Likewise.
* tools/virsh-snapshot.c (cmdSnapshotCreate, vshSnapshotCreate)
(vshLookupSnapshot, cmdSnapshotEdit, cmdSnapshotCurrent)
(vshGetSnapshotParent): Likewise.
* tools/virsh-volume.c (cmdVolCreate, cmdVolCreateFrom)
(cmdVolInfo, cmdVolList): Likewise.
2012-08-19 08:10:17 +04:00
if ( virFileReadAll ( from , VSH_MAX_XML_FILE , & buffer ) < 0 )
2012-07-23 10:15:55 +04:00
return false ;
nwfilter = virNWFilterDefineXML ( ctl - > conn , buffer ) ;
VIR_FREE ( buffer ) ;
if ( nwfilter ! = NULL ) {
vshPrint ( ctl , _ ( " Network filter %s defined from %s \n " ) ,
virNWFilterGetName ( nwfilter ) , from ) ;
virNWFilterFree ( nwfilter ) ;
} else {
vshError ( ctl , _ ( " Failed to define network filter from %s " ) , from ) ;
ret = false ;
}
return ret ;
}
/*
* " nwfilter-undefine " command
*/
static const vshCmdInfo info_nwfilter_undefine [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " undefine a network filter " )
} ,
{ . name = " desc " ,
. data = N_ ( " Undefine a given network filter. " )
} ,
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static const vshCmdOptDef opts_nwfilter_undefine [ ] = {
2013-01-14 18:32:22 +04:00
{ . name = " nwfilter " ,
. type = VSH_OT_DATA ,
. flags = VSH_OFLAG_REQ ,
. help = N_ ( " network filter name or uuid " )
} ,
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static bool
cmdNWFilterUndefine ( vshControl * ctl , const vshCmd * cmd )
{
virNWFilterPtr nwfilter ;
bool ret = true ;
const char * name ;
if ( ! ( nwfilter = vshCommandOptNWFilter ( ctl , cmd , & name ) ) )
return false ;
if ( virNWFilterUndefine ( nwfilter ) = = 0 ) {
vshPrint ( ctl , _ ( " Network filter %s undefined \n " ) , name ) ;
} else {
vshError ( ctl , _ ( " Failed to undefine network filter %s " ) , name ) ;
ret = false ;
}
virNWFilterFree ( nwfilter ) ;
return ret ;
}
/*
* " nwfilter-dumpxml " command
*/
static const vshCmdInfo info_nwfilter_dumpxml [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " network filter information in XML " )
} ,
{ . name = " desc " ,
. data = N_ ( " Output the network filter information as an XML dump to stdout. " )
} ,
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static const vshCmdOptDef opts_nwfilter_dumpxml [ ] = {
2013-01-14 18:32:22 +04:00
{ . name = " nwfilter " ,
. type = VSH_OT_DATA ,
. flags = VSH_OFLAG_REQ ,
. help = N_ ( " network filter name or uuid " )
} ,
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static bool
cmdNWFilterDumpXML ( vshControl * ctl , const vshCmd * cmd )
{
virNWFilterPtr nwfilter ;
bool ret = true ;
char * dump ;
if ( ! ( nwfilter = vshCommandOptNWFilter ( ctl , cmd , NULL ) ) )
return false ;
dump = virNWFilterGetXMLDesc ( nwfilter , 0 ) ;
if ( dump ! = NULL ) {
vshPrint ( ctl , " %s " , dump ) ;
VIR_FREE ( dump ) ;
} else {
ret = false ;
}
virNWFilterFree ( nwfilter ) ;
return ret ;
}
2012-09-05 10:02:07 +04:00
static int
vshNWFilterSorter ( const void * a , const void * b )
{
virNWFilterPtr * fa = ( virNWFilterPtr * ) a ;
virNWFilterPtr * fb = ( virNWFilterPtr * ) b ;
if ( * fa & & ! * fb )
return - 1 ;
if ( ! * fa )
return * fb ! = NULL ;
return vshStrcasecmp ( virNWFilterGetName ( * fa ) ,
virNWFilterGetName ( * fb ) ) ;
}
struct vshNWFilterList {
virNWFilterPtr * filters ;
size_t nfilters ;
} ;
typedef struct vshNWFilterList * vshNWFilterListPtr ;
static void
vshNWFilterListFree ( vshNWFilterListPtr list )
{
Convert 'int i' to 'size_t i' in tools/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
size_t i ;
2012-09-05 10:02:07 +04:00
2013-08-27 15:27:50 +04:00
if ( list & & list - > filters ) {
2012-09-05 10:02:07 +04:00
for ( i = 0 ; i < list - > nfilters ; i + + ) {
if ( list - > filters [ i ] )
virNWFilterFree ( list - > filters [ i ] ) ;
}
VIR_FREE ( list - > filters ) ;
}
VIR_FREE ( list ) ;
}
static vshNWFilterListPtr
vshNWFilterListCollect ( vshControl * ctl ,
unsigned int flags )
{
vshNWFilterListPtr list = vshMalloc ( ctl , sizeof ( * list ) ) ;
Convert 'int i' to 'size_t i' in tools/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
size_t i ;
2012-09-05 10:02:07 +04:00
int ret ;
virNWFilterPtr filter ;
bool success = false ;
size_t deleted = 0 ;
int nfilters = 0 ;
char * * names = NULL ;
/* try the list with flags support (0.10.2 and later) */
if ( ( ret = virConnectListAllNWFilters ( ctl - > conn ,
& list - > filters ,
flags ) ) > = 0 ) {
list - > nfilters = ret ;
goto finished ;
}
/* check if the command is actually supported */
if ( last_error & & last_error - > code = = VIR_ERR_NO_SUPPORT ) {
vshResetLibvirtError ( ) ;
goto fallback ;
}
/* there was an error during the call */
vshError ( ctl , " %s " , _ ( " Failed to list node filters " ) ) ;
goto cleanup ;
2014-03-25 10:53:59 +04:00
fallback :
2012-09-05 10:02:07 +04:00
/* fall back to old method (0.9.13 and older) */
vshResetLibvirtError ( ) ;
nfilters = virConnectNumOfNWFilters ( ctl - > conn ) ;
if ( nfilters < 0 ) {
vshError ( ctl , " %s " , _ ( " Failed to count network filters " ) ) ;
goto cleanup ;
}
if ( nfilters = = 0 )
return list ;
names = vshMalloc ( ctl , sizeof ( char * ) * nfilters ) ;
nfilters = virConnectListNWFilters ( ctl - > conn , names , nfilters ) ;
if ( nfilters < 0 ) {
vshError ( ctl , " %s " , _ ( " Failed to list network filters " ) ) ;
goto cleanup ;
}
list - > filters = vshMalloc ( ctl , sizeof ( virNWFilterPtr ) * nfilters ) ;
list - > nfilters = 0 ;
/* get the network filters */
2013-05-21 11:44:53 +04:00
for ( i = 0 ; i < nfilters ; i + + ) {
2012-09-05 10:02:07 +04:00
if ( ! ( filter = virNWFilterLookupByName ( ctl - > conn , names [ i ] ) ) )
continue ;
list - > filters [ list - > nfilters + + ] = filter ;
}
/* truncate network filters that weren't found */
deleted = nfilters - list - > nfilters ;
2014-03-25 10:53:59 +04:00
finished :
2012-09-05 10:02:07 +04:00
/* sort the list */
if ( list - > filters & & list - > nfilters )
qsort ( list - > filters , list - > nfilters ,
sizeof ( * list - > filters ) , vshNWFilterSorter ) ;
/* truncate the list for not found filter objects */
if ( deleted )
VIR_SHRINK_N ( list - > filters , list - > nfilters , deleted ) ;
success = true ;
2014-03-25 10:53:59 +04:00
cleanup :
Convert 'int i' to 'size_t i' in tools/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
for ( i = 0 ; nfilters ! = - 1 & & i < nfilters ; i + + )
2012-09-05 10:02:07 +04:00
VIR_FREE ( names [ i ] ) ;
VIR_FREE ( names ) ;
if ( ! success ) {
vshNWFilterListFree ( list ) ;
list = NULL ;
}
return list ;
}
2012-07-23 10:15:55 +04:00
/*
* " nwfilter-list " command
*/
static const vshCmdInfo info_nwfilter_list [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " list network filters " )
} ,
{ . name = " desc " ,
. data = N_ ( " Returns list of network filters. " )
} ,
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static const vshCmdOptDef opts_nwfilter_list [ ] = {
2013-01-14 18:32:22 +04:00
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static bool
cmdNWFilterList ( vshControl * ctl , const vshCmd * cmd ATTRIBUTE_UNUSED )
{
Convert 'int i' to 'size_t i' in tools/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
size_t i ;
2012-07-23 10:15:55 +04:00
char uuid [ VIR_UUID_STRING_BUFLEN ] ;
2012-09-05 10:02:07 +04:00
vshNWFilterListPtr list = NULL ;
2012-07-23 10:15:55 +04:00
2012-09-05 10:02:07 +04:00
if ( ! ( list = vshNWFilterListCollect ( ctl , 0 ) ) )
2012-07-23 10:15:55 +04:00
return false ;
2013-11-12 20:30:48 +04:00
vshPrintExtra ( ctl , " %-36s %-20s \n " , _ ( " UUID " ) , _ ( " Name " ) ) ;
vshPrintExtra ( ctl , " --------------------------------- "
" --------------------------------- \n " ) ;
2012-07-23 10:15:55 +04:00
2012-09-05 10:02:07 +04:00
for ( i = 0 ; i < list - > nfilters ; i + + ) {
virNWFilterPtr nwfilter = list - > filters [ i ] ;
2012-07-23 10:15:55 +04:00
virNWFilterGetUUIDString ( nwfilter , uuid ) ;
2013-11-12 20:30:48 +04:00
vshPrint ( ctl , " %-36s %-20s \n " ,
2012-07-23 10:15:55 +04:00
uuid ,
virNWFilterGetName ( nwfilter ) ) ;
}
2012-09-05 10:02:07 +04:00
vshNWFilterListFree ( list ) ;
2012-07-23 10:15:55 +04:00
return true ;
}
/*
* " nwfilter-edit " command
*/
static const vshCmdInfo info_nwfilter_edit [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " help " ,
. data = N_ ( " edit XML configuration for a network filter " )
} ,
{ . name = " desc " ,
. data = N_ ( " Edit the XML configuration for a network filter. " )
} ,
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static const vshCmdOptDef opts_nwfilter_edit [ ] = {
2013-01-14 18:32:22 +04:00
{ . name = " nwfilter " ,
. type = VSH_OT_DATA ,
. flags = VSH_OFLAG_REQ ,
. help = N_ ( " network filter name or uuid " )
} ,
{ . name = NULL }
2012-07-23 10:15:55 +04:00
} ;
static bool
cmdNWFilterEdit ( vshControl * ctl , const vshCmd * cmd )
{
bool ret = false ;
virNWFilterPtr nwfilter = NULL ;
virNWFilterPtr nwfilter_edited = NULL ;
nwfilter = vshCommandOptNWFilter ( ctl , cmd , NULL ) ;
if ( nwfilter = = NULL )
goto cleanup ;
# define EDIT_GET_XML virNWFilterGetXMLDesc(nwfilter, 0)
# define EDIT_NOT_CHANGED \
vshPrint ( ctl , _ ( " Network filter %s XML " \
" configuration not changed. \n " ) , \
virNWFilterGetName ( nwfilter ) ) ; \
ret = true ; goto edit_cleanup ;
# define EDIT_DEFINE \
( nwfilter_edited = virNWFilterDefineXML ( ctl - > conn , doc_edited ) )
# define EDIT_FREE \
if ( nwfilter_edited ) \
virNWFilterFree ( nwfilter ) ;
# include "virsh-edit.c"
vshPrint ( ctl , _ ( " Network filter %s XML configuration edited. \n " ) ,
virNWFilterGetName ( nwfilter_edited ) ) ;
ret = true ;
2014-03-25 10:53:59 +04:00
cleanup :
2012-07-23 10:15:55 +04:00
if ( nwfilter )
virNWFilterFree ( nwfilter ) ;
if ( nwfilter_edited )
virNWFilterFree ( nwfilter_edited ) ;
return ret ;
}
2012-07-23 11:19:04 +04:00
2012-08-21 02:56:03 +04:00
const vshCmdDef nwfilterCmds [ ] = {
2013-02-07 19:25:10 +04:00
{ . name = " nwfilter-define " ,
. handler = cmdNWFilterDefine ,
. opts = opts_nwfilter_define ,
. info = info_nwfilter_define ,
. flags = 0
} ,
{ . name = " nwfilter-dumpxml " ,
. handler = cmdNWFilterDumpXML ,
. opts = opts_nwfilter_dumpxml ,
. info = info_nwfilter_dumpxml ,
. flags = 0
} ,
{ . name = " nwfilter-edit " ,
. handler = cmdNWFilterEdit ,
. opts = opts_nwfilter_edit ,
. info = info_nwfilter_edit ,
. flags = 0
} ,
{ . name = " nwfilter-list " ,
. handler = cmdNWFilterList ,
. opts = opts_nwfilter_list ,
. info = info_nwfilter_list ,
. flags = 0
} ,
{ . name = " nwfilter-undefine " ,
. handler = cmdNWFilterUndefine ,
. opts = opts_nwfilter_undefine ,
. info = info_nwfilter_undefine ,
. flags = 0
} ,
{ . name = NULL }
2012-07-23 11:19:04 +04:00
} ;