2008-01-29 21:15:54 +03:00
# include <config.h>
2007-11-26 15:03:34 +03:00
2007-07-19 01:34:22 +04:00
# include <stdio.h>
2007-11-26 15:03:34 +03:00
# include <stdlib.h>
# include <unistd.h>
2007-07-19 01:34:22 +04:00
# include <string.h>
# include <sys/types.h>
# include <fcntl.h>
2007-11-26 15:03:34 +03:00
# ifdef WITH_QEMU
2010-03-09 21:22:22 +03:00
# include "internal.h"
# include "testutils.h"
# include "qemu / qemu_conf.h"
2011-07-11 21:29:09 +04:00
# include "qemu / qemu_domain.h"
2010-03-09 21:22:22 +03:00
# include "testutilsqemu.h"
2007-07-19 01:34:22 +04:00
2008-01-14 17:04:33 +03:00
static struct qemud_driver driver ;
2007-07-19 01:34:22 +04:00
2011-04-25 02:25:10 +04:00
static int
testCompareXMLToXMLFiles ( const char * inxml , const char * outxml )
{
char * inXmlData = NULL ;
char * outXmlData = NULL ;
2007-07-19 01:34:22 +04:00
char * actual = NULL ;
int ret = - 1 ;
2010-07-25 02:18:18 +04:00
virDomainDefPtr def = NULL ;
2007-07-19 01:34:22 +04:00
2011-04-25 02:25:10 +04:00
if ( virtTestLoadFile ( inxml , & inXmlData ) < 0 )
2010-07-25 02:18:18 +04:00
goto fail ;
2011-04-25 02:25:10 +04:00
if ( virtTestLoadFile ( outxml , & outXmlData ) < 0 )
2007-07-19 01:34:22 +04:00
goto fail ;
2010-07-25 02:18:18 +04:00
if ( ! ( def = virDomainDefParseString ( driver . caps , inXmlData ,
2011-07-11 21:29:09 +04:00
QEMU_EXPECTED_VIRT_TYPES ,
VIR_DOMAIN_XML_INACTIVE ) ) )
2007-07-19 01:34:22 +04:00
goto fail ;
2011-05-26 15:52:08 +04:00
if ( ! ( actual = virDomainDefFormat ( def , VIR_DOMAIN_XML_SECURE ) ) )
2007-07-19 01:34:22 +04:00
goto fail ;
2010-07-25 02:18:18 +04:00
if ( STRNEQ ( outXmlData , actual ) ) {
virtTestDifference ( stderr , outXmlData , actual ) ;
2007-07-19 01:34:22 +04:00
goto fail ;
}
ret = 0 ;
fail :
2011-04-25 02:25:10 +04:00
free ( inXmlData ) ;
free ( outXmlData ) ;
2007-07-19 01:34:22 +04:00
free ( actual ) ;
2010-07-25 02:18:18 +04:00
virDomainDefFree ( def ) ;
2007-07-19 01:34:22 +04:00
return ret ;
}
2010-07-25 02:18:18 +04:00
struct testInfo {
const char * name ;
int different ;
} ;
2011-04-25 02:25:10 +04:00
static int
testCompareXMLToXMLHelper ( const void * data )
{
2010-07-25 02:18:18 +04:00
const struct testInfo * info = data ;
2011-04-25 02:25:10 +04:00
char * xml_in = NULL ;
char * xml_out = NULL ;
int ret = - 1 ;
2010-07-25 02:18:18 +04:00
2011-04-25 02:25:10 +04:00
if ( virAsprintf ( & xml_in , " %s/qemuxml2argvdata/qemuxml2argv-%s.xml " ,
abs_srcdir , info - > name ) < 0 | |
virAsprintf ( & xml_out , " %s/qemuxml2xmloutdata/qemuxml2xmlout-%s.xml " ,
abs_srcdir , info - > name ) < 0 )
goto cleanup ;
2010-07-25 02:18:18 +04:00
if ( info - > different ) {
ret = testCompareXMLToXMLFiles ( xml_in , xml_out ) ;
} else {
ret = testCompareXMLToXMLFiles ( xml_in , xml_in ) ;
}
2011-04-25 02:25:10 +04:00
cleanup :
free ( xml_in ) ;
free ( xml_out ) ;
2010-07-25 02:18:18 +04:00
return ret ;
2007-07-19 01:34:22 +04:00
}
2008-05-29 19:31:49 +04:00
static int
2011-04-29 20:21:20 +04:00
mymain ( void )
2007-07-19 01:34:22 +04:00
{
int ret = 0 ;
2008-02-27 07:35:08 +03:00
2008-05-29 19:31:49 +04:00
if ( ( driver . caps = testQemuCapsInit ( ) ) = = NULL )
return ( EXIT_FAILURE ) ;
2008-02-27 07:35:08 +03:00
2010-07-25 02:18:18 +04:00
# define DO_TEST_FULL(name, is_different) \
do { \
const struct testInfo info = { name , is_different } ; \
if ( virtTestRun ( " QEMU XML-2-XML " name , \
1 , testCompareXMLToXMLHelper , & info ) < 0 ) \
ret = - 1 ; \
} while ( 0 )
2010-03-09 21:22:22 +03:00
# define DO_TEST(name) \
2010-07-25 02:18:18 +04:00
DO_TEST_FULL ( name , 0 )
# define DO_TEST_DIFFERENT(name) \
DO_TEST_FULL ( name , 1 )
/* Unset or set all envvars here that are copied in qemudBuildCommandLine
* using ADD_ENV_COPY , otherwise these tests may fail due to unexpected
* values for these envvars */
setenv ( " PATH " , " /bin " , 1 ) ;
2008-04-26 00:46:13 +04:00
DO_TEST ( " minimal " ) ;
DO_TEST ( " boot-cdrom " ) ;
DO_TEST ( " boot-network " ) ;
DO_TEST ( " boot-floppy " ) ;
2010-07-26 18:28:58 +04:00
DO_TEST ( " boot-multi " ) ;
DO_TEST ( " boot-menu-disable " ) ;
2011-01-13 13:46:43 +03:00
DO_TEST ( " boot-order " ) ;
2008-05-15 20:21:11 +04:00
DO_TEST ( " bootloader " ) ;
2008-04-26 00:46:13 +04:00
DO_TEST ( " clock-utc " ) ;
DO_TEST ( " clock-localtime " ) ;
2012-01-27 17:49:52 +04:00
DO_TEST ( " cpu-kvmclock " ) ;
DO_TEST ( " cpu-host-kvmclock " ) ;
DO_TEST ( " kvmclock " ) ;
Support configuration of huge pages in guests
Add option to domain XML for
<memoryBacking>
<hugepages/>
</memoryBacking>
* configure.in: Add check for mntent.h
* qemud/libvirtd_qemu.aug, qemud/test_libvirtd_qemu.aug, src/qemu.conf
Add 'hugetlbfs_mount' config parameter
* src/qemu_conf.c, src/qemu_conf.h: Check for -mem-path flag in QEMU,
and pass it when hugepages are requested.
Load hugetlbfs_mount config parameter, search for mount if not given.
* src/qemu_driver.c: Free hugetlbfs_mount/path parameter in driver shutdown.
Create directory for QEMU hugepage usage, chowning if required.
* docs/formatdomain.html.in: Document memoryBacking/hugepages elements
* docs/schemas/domain.rng: Add memoryBacking/hugepages elements to schema
* src/util.c, src/util.h, src/libvirt_private.syms: Add virFileFindMountPoint
helper API
* tests/qemuhelptest.c: Add -mem-path constants
* tests/qemuxml2argvtest.c, tests/qemuxml2xmltest.c: Add tests for hugepage
handling
* tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml,
tests/qemuxml2argvdata/qemuxml2argv-hugepages.args: Data files for
hugepage tests
2009-08-25 18:05:18 +04:00
DO_TEST ( " hugepages " ) ;
2010-04-21 18:28:21 +04:00
DO_TEST ( " disk-aio " ) ;
2008-04-26 00:46:13 +04:00
DO_TEST ( " disk-cdrom " ) ;
DO_TEST ( " disk-floppy " ) ;
DO_TEST ( " disk-many " ) ;
2008-05-15 20:05:41 +04:00
DO_TEST ( " disk-xenvbd " ) ;
2008-08-08 19:03:00 +04:00
DO_TEST ( " disk-usb " ) ;
2009-12-22 19:53:20 +03:00
DO_TEST ( " disk-virtio " ) ;
2009-11-16 21:08:29 +03:00
DO_TEST ( " floppy-drive-fat " ) ;
DO_TEST ( " disk-drive-fat " ) ;
2009-01-23 19:22:20 +03:00
DO_TEST ( " disk-drive-fmt-qcow " ) ;
2009-01-30 20:15:39 +03:00
DO_TEST ( " disk-drive-cache-v1-wt " ) ;
DO_TEST ( " disk-drive-cache-v1-wb " ) ;
DO_TEST ( " disk-drive-cache-v1-none " ) ;
2010-07-25 02:18:18 +04:00
DO_TEST ( " disk-scsi-device " ) ;
2012-01-13 16:23:55 +04:00
DO_TEST ( " disk-scsi-vscsi " ) ;
2012-01-13 16:23:56 +04:00
DO_TEST ( " disk-scsi-virtio-scsi " ) ;
conf: add <listen> subelement to domain <graphics> element
Once it's plugged in, the <listen> element will be an optional
replacement for the "listen" attribute that graphics elements already
have. If the <listen> element is type='address', it will have an
attribute called 'address' which will contain an IP address or dns
name that the guest's display server should listen on. If, however,
type='network', the <listen> element should have an attribute called
'network' that will be set to the name of a network configuration to
get the IP address from.
* docs/schemas/domain.rng: updated to allow the <listen> element
* docs/formatdomain.html.in: document the <listen> element and its
attributes.
* src/conf/domain_conf.[hc]:
1) The domain parser, formatter, and data structure are modified to
support 0 or more <listen> subelements to each <graphics>
element. The old style "legacy" listen attribute is also still
accepted, and will be stored internally just as if it were a
separate <listen> element. On output (i.e. format), the address
attribute of the first <listen> element of type 'address' will be
duplicated in the legacy "listen" attribute of the <graphic>
element.
2) The "listenAddr" attribute has been removed from the unions in
virDomainGRaphicsDef for graphics types vnc, rdp, and spice.
This attribute is now in the <listen> subelement (aka
virDomainGraphicsListenDef)
3) Helper functions were written to provide simple access
(both Get and Set) to the listen elements and their attributes.
* src/libvirt_private.syms: export the listen helper functions
* src/qemu/qemu_command.c, src/qemu/qemu_hotplug.c,
src/qemu/qemu_migration.c, src/vbox/vbox_tmpl.c,
src/vmx/vmx.c, src/xenxs/xen_sxpr.c, src/xenxs/xen_xm.c
Modify all these files to use the listen helper functions rather
than directly referencing the (now missing) listenAddr
attribute. There can be multiple <listen> elements to a single
<graphics>, but the drivers all currently only support one, so all
replacements of direct access with a helper function indicate index
"0".
* tests/* - only 3 of these are new files added explicitly to test the
new <listen> element. All the others have been modified to reflect
the fact that any legacy "listen" attributes passed in to the domain
parse will be saved in a <listen> element (i.e. one of the
virDomainGraphicsListenDefs), and during the domain format function,
both the <listen> element as well as the legacy attributes will be
output.
2011-07-07 08:20:28 +04:00
DO_TEST ( " graphics-listen-network " ) ;
2008-04-26 00:46:13 +04:00
DO_TEST ( " graphics-vnc " ) ;
2009-07-06 17:59:19 +04:00
DO_TEST ( " graphics-vnc-sasl " ) ;
DO_TEST ( " graphics-vnc-tls " ) ;
2008-04-26 00:46:13 +04:00
DO_TEST ( " graphics-sdl " ) ;
2008-12-11 14:44:30 +03:00
DO_TEST ( " graphics-sdl-fullscreen " ) ;
2010-03-05 20:12:52 +03:00
DO_TEST ( " graphics-spice " ) ;
2011-05-31 17:52:05 +04:00
DO_TEST ( " graphics-spice-compression " ) ;
qemu: Support vram for video of qxl type
For qemu names the primary vga as "qxl-vga":
1) if vram is specified for 2nd qxl device:
-vga qxl -global qxl-vga.vram_size=$SIZE \
-device qxl,id=video1,vram_size=$SIZE,...
2) if vram is not specified for 2nd qxl device, (use the default
set by global):
-vga qxl -global qxl-vga.vram_size=$SIZE \
-device qxl,id=video1,...
For qemu names all qxl devices as "qxl":
1) if vram is specified for 2nd qxl device:
-vga qxl -global qxl.vram_size=$SIZE \
-device qxl,id=video1,vram_size=$SIZE ...
2) if vram is not specified for 2nd qxl device:
-vga qxl -global qxl-vga.vram_size=$SIZE \
-device qxl,id=video1,...
"-global" is the only way to define vram_size for the primary qxl
device, regardless of how qemu names it, (It's not good a good
way, as original idea of "-global" is to set a global default for
a driver property, but to specify vram for first qxl device, we
have to use it).
For other qxl devices, as they are represented by "-device", could
specify it directly and seperately for each, and it overrides the
default set by "-global" if specified.
v1 - v2:
* modify "virDomainVideoDefaultRAM" so that it returns 16M as the
default vram_size for qxl device.
* vram_size * 1024 (qemu accepts bytes for vram_size).
* apply default vram_size for qxl device for which vram_size is
not specified.
* modify "graphics-spice" tests (more sensiable vram_size)
* Add an argument of virDomainDefPtr type for qemuBuildVideoDevStr,
to use virDomainVideoDefaultRAM in qemuBuildVideoDevStr).
v2 - v3:
* Modify default video memory size for qxl device from 16M to 24M
* Update codes to be consistent with changes on qemu_capabilities.*
2011-03-06 17:00:27 +03:00
DO_TEST ( " graphics-spice-qxl-vga " ) ;
2008-04-26 00:46:13 +04:00
DO_TEST ( " input-usbmouse " ) ;
DO_TEST ( " input-usbtablet " ) ;
2008-05-15 20:11:40 +04:00
DO_TEST ( " input-xen " ) ;
2008-04-26 00:46:13 +04:00
DO_TEST ( " misc-acpi " ) ;
DO_TEST ( " misc-no-reboot " ) ;
DO_TEST ( " net-user " ) ;
2008-04-30 16:30:55 +04:00
DO_TEST ( " net-virtio " ) ;
Add txmode attribute to interface XML for virtio backend
This is in response to:
https://bugzilla.redhat.com/show_bug.cgi?id=629662
Explanation
qemu's virtio-net-pci driver allows setting the algorithm used for tx
packets to either "bh" or "timer". This is done by adding ",tx=bh" or
",tx=timer" to the "-device virtio-net-pci" commandline option.
'bh' stands for 'bottom half'; when this is set, packet tx is all done
in an iothread in the bottom half of the driver. (In libvirt, this
option is called the more descriptive "iothread".)
'timer' means that tx work is done in qemu, and if there is more tx
data than can be sent at the present time, a timer is set before qemu
moves on to do other things; when the timer fires, another attempt is
made to send more data. (libvirt retains the name "timer" for this
option.)
The resulting difference, according to the qemu developer who added
the option is:
bh makes tx more asynchronous and reduces latency, but potentially
causes more processor bandwidth contention since the cpu doing the
tx isn't necessarily the cpu where the guest generated the
packets.
Solution
This patch provides a libvirt domain xml knob to change the option on
the qemu commandline, by adding a new attribute "txmode" to the
<driver> element that can be placed inside any <interface> element in
a domain definition. It's use would be something like this:
<interface ...>
...
<model type='virtio'/>
<driver txmode='iothread'/>
...
</interface>
I chose to put this setting as an attribute to <driver> rather than as
a sub-element to <tune> because it is specific to the virtio-net
driver, not something that is generally usable by all network drivers.
(note that this is the same placement as the "driver name=..."
attribute used to choose kernel vs. userland backend for the
virtio-net driver.)
Actually adding the tx=xxx option to the qemu commandline is only done
if the version of qemu being used advertises it in the output of
qemu -device virtio-net-pci,?
If a particular txmode is requested in the XML, and the option isn't
listed in that help output, an UNSUPPORTED_CONFIG error is logged, and
the domain fails to start.
2011-02-03 23:20:01 +03:00
DO_TEST ( " net-virtio-device " ) ;
2009-01-30 20:17:58 +03:00
DO_TEST ( " net-eth " ) ;
DO_TEST ( " net-eth-ifname " ) ;
2011-06-26 12:09:00 +04:00
DO_TEST ( " net-virtio-network-portgroup " ) ;
2008-07-11 23:34:11 +04:00
DO_TEST ( " sound " ) ;
2011-07-22 18:07:29 +04:00
DO_TEST ( " net-bandwidth " ) ;
2008-04-26 00:46:13 +04:00
DO_TEST ( " serial-vc " ) ;
DO_TEST ( " serial-pty " ) ;
DO_TEST ( " serial-dev " ) ;
DO_TEST ( " serial-file " ) ;
DO_TEST ( " serial-unix " ) ;
DO_TEST ( " serial-tcp " ) ;
DO_TEST ( " serial-udp " ) ;
DO_TEST ( " serial-tcp-telnet " ) ;
DO_TEST ( " serial-many " ) ;
DO_TEST ( " parallel-tcp " ) ;
DO_TEST ( " console-compat " ) ;
Allow multiple consoles per virtual guest
While Xen only has a single paravirt console, UML, and
QEMU both support multiple paravirt consoles. The LXC
driver can also be trivially made to support multiple
consoles. This patch extends the XML to allow multiple
<console> elements in the XML. It also makes the UML
and QEMU drivers support this config.
* src/conf/domain_conf.c, src/conf/domain_conf.h: Allow
multiple <console> devices
* src/lxc/lxc_driver.c, src/xen/xen_driver.c,
src/xenxs/xen_sxpr.c, src/xenxs/xen_xm.c: Update for
internal API changes
* src/security/security_selinux.c, src/security/virt-aa-helper.c:
Only label consoles that aren't a copy of the serial device
* src/qemu/qemu_command.c, src/qemu/qemu_driver.c,
src/qemu/qemu_process.c, src/uml/uml_conf.c,
src/uml/uml_driver.c: Support multiple console devices
* tests/qemuxml2xmltest.c, tests/qemuxml2argvtest.c: Extra
tests for multiple virtio consoles. Set QEMU_CAPS_CHARDEV
for all console /channel tests
* tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-auto.args,
tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.args
tests/qemuxml2argvdata/qemuxml2argv-console-virtio.args: Update
for correct chardev syntax
* tests/qemuxml2argvdata/qemuxml2argv-console-virtio-many.args,
tests/qemuxml2argvdata/qemuxml2argv-console-virtio-many.xml: New
test file
2011-02-23 21:27:23 +03:00
DO_TEST ( " console-virtio-many " ) ;
2009-11-05 17:31:03 +03:00
DO_TEST ( " channel-guestfwd " ) ;
2010-02-18 19:52:03 +03:00
DO_TEST ( " channel-virtio " ) ;
2007-07-19 01:34:22 +04:00
2008-08-08 18:27:05 +04:00
DO_TEST ( " hostdev-usb-address " ) ;
2009-01-12 18:09:19 +03:00
DO_TEST ( " hostdev-pci-address " ) ;
2008-08-08 18:27:05 +04:00
2010-04-27 14:01:32 +04:00
DO_TEST ( " encrypted-disk " ) ;
2010-10-12 18:43:39 +04:00
DO_TEST ( " memtune " ) ;
2011-02-08 09:59:38 +03:00
DO_TEST ( " blkiotune " ) ;
2011-11-08 15:00:34 +04:00
DO_TEST ( " blkiotune-device " ) ;
2011-03-29 17:44:14 +04:00
DO_TEST ( " cputune " ) ;
2010-04-27 14:01:32 +04:00
2010-09-30 01:58:47 +04:00
DO_TEST ( " smp " ) ;
2010-12-09 21:25:11 +03:00
DO_TEST ( " lease " ) ;
2011-08-13 10:32:45 +04:00
DO_TEST ( " event_idx " ) ;
qemu: add new disk device='lun' for bus='virtio' & type='block'
In the past, generic SCSI commands issued from a guest to a virtio
disk were always passed through to the underlying disk by qemu, and
the kernel would also pass them on.
As a result of CVE-2011-4127 (see:
http://seclists.org/oss-sec/2011/q4/536), qemu now honors its
scsi=on|off device option for virtio-blk-pci (which enables/disables
passthrough of generic SCSI commands), and the kernel will only allow
the commands for physical devices (not for partitions or logical
volumes). The default behavior of qemu is still to allow sending
generic SCSI commands to physical disks that are presented to a guest
as virtio-blk-pci devices, but libvirt prefers to disable those
commands in the standard virtio block devices, enabling it only when
specifically requested (hopefully indicating that the requester
understands what they're asking for). For this purpose, a new libvirt
disk device type (device='lun') has been created.
device='lun' is identical to the default device='disk', except that:
1) It is only allowed if bus='virtio', type='block', and the qemu
version is "new enough" to support it ("new enough" == qemu 0.11 or
better), otherwise the domain will fail to start and a
CONFIG_UNSUPPORTED error will be logged).
2) The option "scsi=on" will be added to the -device arg to allow
SG_IO commands (if device !='lun', "scsi=off" will be added to the
-device arg so that SG_IO commands are specifically forbidden).
Guests which continue to use disk device='disk' (the default) will no
longer be able to use SG_IO commands on the disk; those that have
their disk device changed to device='lun' will still be able to use SG_IO
commands.
*docs/formatdomain.html.in - document the new device attribute value.
*docs/schemas/domaincommon.rng - allow it in the RNG
*tests/* - update the args of several existing tests to add scsi=off, and
add one new test that will test scsi=on.
*src/conf/domain_conf.c - update domain XML parser and formatter
*src/qemu/qemu_(command|driver|hotplug).c - treat
VIR_DOMAIN_DISK_DEVICE_LUN *almost* identically to
VIR_DOMAIN_DISK_DEVICE_DISK, except as indicated above.
Note that no support for this new device value was added to any
hypervisor drivers other than qemu, because it's unclear what it might
mean (if anything) to those drivers.
2012-01-05 07:48:38 +04:00
DO_TEST ( " virtio-lun " ) ;
2010-09-30 01:58:47 +04:00
2011-09-02 19:09:14 +04:00
DO_TEST ( " usb-redir " ) ;
2011-11-15 13:02:50 +04:00
DO_TEST ( " blkdeviotune " ) ;
2011-09-02 19:09:14 +04:00
2011-12-23 04:47:46 +04:00
DO_TEST ( " seclabel-dynamic-baselabel " ) ;
2011-12-23 04:47:50 +04:00
DO_TEST ( " seclabel-dynamic-override " ) ;
2011-12-23 04:47:46 +04:00
DO_TEST ( " seclabel-static " ) ;
2010-07-25 02:18:18 +04:00
/* These tests generate different XML */
DO_TEST_DIFFERENT ( " balloon-device-auto " ) ;
DO_TEST_DIFFERENT ( " channel-virtio-auto " ) ;
DO_TEST_DIFFERENT ( " console-compat-auto " ) ;
DO_TEST_DIFFERENT ( " disk-scsi-device-auto " ) ;
2010-07-14 21:02:04 +04:00
DO_TEST_DIFFERENT ( " console-virtio " ) ;
2011-04-14 20:05:14 +04:00
DO_TEST_DIFFERENT ( " serial-target-port-auto " ) ;
conf: add <listen> subelement to domain <graphics> element
Once it's plugged in, the <listen> element will be an optional
replacement for the "listen" attribute that graphics elements already
have. If the <listen> element is type='address', it will have an
attribute called 'address' which will contain an IP address or dns
name that the guest's display server should listen on. If, however,
type='network', the <listen> element should have an attribute called
'network' that will be set to the name of a network configuration to
get the IP address from.
* docs/schemas/domain.rng: updated to allow the <listen> element
* docs/formatdomain.html.in: document the <listen> element and its
attributes.
* src/conf/domain_conf.[hc]:
1) The domain parser, formatter, and data structure are modified to
support 0 or more <listen> subelements to each <graphics>
element. The old style "legacy" listen attribute is also still
accepted, and will be stored internally just as if it were a
separate <listen> element. On output (i.e. format), the address
attribute of the first <listen> element of type 'address' will be
duplicated in the legacy "listen" attribute of the <graphic>
element.
2) The "listenAddr" attribute has been removed from the unions in
virDomainGRaphicsDef for graphics types vnc, rdp, and spice.
This attribute is now in the <listen> subelement (aka
virDomainGraphicsListenDef)
3) Helper functions were written to provide simple access
(both Get and Set) to the listen elements and their attributes.
* src/libvirt_private.syms: export the listen helper functions
* src/qemu/qemu_command.c, src/qemu/qemu_hotplug.c,
src/qemu/qemu_migration.c, src/vbox/vbox_tmpl.c,
src/vmx/vmx.c, src/xenxs/xen_sxpr.c, src/xenxs/xen_xm.c
Modify all these files to use the listen helper functions rather
than directly referencing the (now missing) listenAddr
attribute. There can be multiple <listen> elements to a single
<graphics>, but the drivers all currently only support one, so all
replacements of direct access with a helper function indicate index
"0".
* tests/* - only 3 of these are new files added explicitly to test the
new <listen> element. All the others have been modified to reflect
the fact that any legacy "listen" attributes passed in to the domain
parse will be saved in a <listen> element (i.e. one of the
virDomainGraphicsListenDefs), and during the domain format function,
both the <listen> element as well as the legacy attributes will be
output.
2011-07-07 08:20:28 +04:00
DO_TEST_DIFFERENT ( " graphics-listen-network2 " ) ;
2011-12-21 17:27:16 +04:00
DO_TEST_DIFFERENT ( " graphics-spice-timeout " ) ;
2010-07-25 02:18:18 +04:00
2012-01-24 06:26:18 +04:00
DO_TEST_DIFFERENT ( " metadata " ) ;
2008-02-27 07:35:08 +03:00
virCapabilitiesFree ( driver . caps ) ;
2007-07-19 01:34:22 +04:00
2008-05-29 19:31:49 +04:00
return ( ret = = 0 ? EXIT_SUCCESS : EXIT_FAILURE ) ;
2007-07-19 01:34:22 +04:00
}
2008-05-29 19:31:49 +04:00
VIRT_TEST_MAIN ( mymain )
2007-11-26 15:03:34 +03:00
# else
2011-12-02 00:47:34 +04:00
# include "testutils.h"
2007-11-26 15:03:34 +03:00
2011-07-28 19:48:12 +04:00
int
main ( void )
{
return EXIT_AM_SKIP ;
}
2007-11-26 15:03:34 +03:00
# endif /* WITH_QEMU */