shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-09 01:18:00 +03:00
Code Releases Activity
ecffc91d02
libvirt/tests/qemuxmlconfdata/q35-pci-force-address.x86_64-latest.args

41 lines
1.8 KiB
Plaintext
Raw Normal View History

conf: Explain some code in more detail The code is entirely correct, but it still managed to trip me up when I first ran into it because I did not realize right away that VIR_PCI_CONNECT_TYPES_ENDPOINT was not a single flag, but rather a mask including both VIR_PCI_CONNECT_TYPE_PCI_DEVICE and VIR_PCI_CONNECT_TYPE_PCIE_DEVICE. In order to save the next distracted traveler in PCI Address Land some time, document this fact with a comment. Add a test case for the behavior as well.
2016-10-12 18:02:37 +03:00
LC_ALL=C \
PATH=/bin \
tests: Drop more QEMU driver config overrides These are allegedly necessary to keep the output consistent, but now that we're using a privileged config for the driver we get the desired behavior out of the box, and as a bonus the paths match what you would actually see on a regular host. Signed-off-by: Andrea Bolognani <abologna@redhat.com> Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
2023-03-02 21:05:53 +03:00
HOME=/var/lib/libvirt/qemu/domain--1-q35-test \
conf: Explain some code in more detail The code is entirely correct, but it still managed to trip me up when I first ran into it because I did not realize right away that VIR_PCI_CONNECT_TYPES_ENDPOINT was not a single flag, but rather a mask including both VIR_PCI_CONNECT_TYPE_PCI_DEVICE and VIR_PCI_CONNECT_TYPE_PCIE_DEVICE. In order to save the next distracted traveler in PCI Address Land some time, document this fact with a comment. Add a test case for the behavior as well.
2016-10-12 18:02:37 +03:00
USER=test \
LOGNAME=test \
tests: Drop more QEMU driver config overrides These are allegedly necessary to keep the output consistent, but now that we're using a privileged config for the driver we get the desired behavior out of the box, and as a bonus the paths match what you would actually see on a regular host. Signed-off-by: Andrea Bolognani <abologna@redhat.com> Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
2023-03-02 21:05:53 +03:00
XDG_DATA_HOME=/var/lib/libvirt/qemu/domain--1-q35-test/.local/share \
XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain--1-q35-test/.cache \
XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-q35-test/.config \
tests: unify qemu binary paths for all qemu related tests Our test data used a lot of different qemu binary paths and some of them were based on downstream systems. Note that there is one file where I had to add "accel=kvm" because the qemuargv2xml code parses "/usr/bin/kvm" as virt type="kvm". Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
2017-04-06 19:19:48 +03:00
/usr/bin/qemu-system-x86_64 \
qemu: command: Always assume support for '-name guest=' and '-name debug-threads=on' All QEMU versions we support have these and it's very unlikely that they will be removed. Remove the capability checks. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Martin Kletzander <mkletzan@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-08-10 17:39:38 +03:00
-name guest=q35-test,debug-threads=on \
conf: Explain some code in more detail The code is entirely correct, but it still managed to trip me up when I first ran into it because I did not realize right away that VIR_PCI_CONNECT_TYPES_ENDPOINT was not a single flag, but rather a mask including both VIR_PCI_CONNECT_TYPE_PCI_DEVICE and VIR_PCI_CONNECT_TYPE_PCIE_DEVICE. In order to save the next distracted traveler in PCI Address Land some time, document this fact with a comment. Add a test case for the behavior as well.
2016-10-12 18:02:37 +03:00
-S \
qemuxml2argvtest: Enable JSON syntax for -device, -object, and -netdev for all fake-caps tests To minimize upcoming churn in test data when they will be converted to latest capabilities enable JSON syntax for -device, -object, and -netdev for all fake caps test files. Doing this should also help git track renames of the files better as there will be more of consistent context present. We can do this safely as internally we generate JSON first and then back-convert it into the old-style commandline if given qemu doesn't support it. This means that all generated content will be the same. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-08-31 11:56:28 +03:00
-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-q35-test/master-key.aes"}' \
testutilsqemu: Always populate default ram id, default cpu, ACPI support for fake machines Enable a few defaults that will decrease churn when converting tests to real capabilities. Since the fake machines are added only for x86_64 at this point we can assume that ACPI is present via -machine. In case of the default ram id assume the same. Additionally the logic was broken as fake capabilities don't have a version so the default RAM was never actually populated into fake caps tests. For CPU we add 'qemu64' as that is the default picked by qemu. We also assume that qemu requires an explicit backend for -numa, which is the case for modern machines. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-08-31 12:36:01 +03:00
-machine q35,usb=off,dump-guest-core=off,memory-backend=pc.ram,acpi=off \
qemu: Switch to -accel We currently use -machine accel=XXX which is just a syntax sugar for -accel XXX. The former doesn't allow specifying arguments for accelerator, because all arguments passed to -machine are treated as arguments of machine itself. The -accel argument was introduced in QEMU commit v2.9.0-rc0~70^2~19 and since our minimum required version is newer (2.11.0) we can safely assume its existence and use it without any capability. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/233 Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Tested-by: Kashyap Chamarthy <kchamart@redhat.com> Reviewed-by: Peter Krempa <pkrempa@redhat.com>
2021-11-05 11:38:10 +03:00
-accel tcg \
testutilsqemu: Always populate default ram id, default cpu, ACPI support for fake machines Enable a few defaults that will decrease churn when converting tests to real capabilities. Since the fake machines are added only for x86_64 at this point we can assume that ACPI is present via -machine. In case of the default ram id assume the same. Additionally the logic was broken as fake capabilities don't have a version so the default RAM was never actually populated into fake caps tests. For CPU we add 'qemu64' as that is the default picked by qemu. We also assume that qemu requires an explicit backend for -numa, which is the case for modern machines. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-08-31 12:36:01 +03:00
-cpu qemu64 \
qemu_command: Always use modern syntax of '-m' Specify the memory size by using '-m size=2048k' instead of just '-m 2'. The new syntax is used when memory hotplug is enabled. To preserve memory sizing, if memory hotplug is disabled the size is rounded down to the nearest mebibyte. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-06-21 17:31:46 +03:00
-m size=2097152k \
testutilsqemu: Always populate default ram id, default cpu, ACPI support for fake machines Enable a few defaults that will decrease churn when converting tests to real capabilities. Since the fake machines are added only for x86_64 at this point we can assume that ACPI is present via -machine. In case of the default ram id assume the same. Additionally the logic was broken as fake capabilities don't have a version so the default RAM was never actually populated into fake caps tests. For CPU we add 'qemu64' as that is the default picked by qemu. We also assume that qemu requires an explicit backend for -numa, which is the case for modern machines. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-08-31 12:36:01 +03:00
-object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":2147483648}' \
qemu: command: Always assume QEMU_CAPS_OVERCOMMIT Starting with qemu-3.1 we always have the '-overcommit' argument and use it instead of '-realtime'. Remove the capability check and fix all fake-caps tests. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2022-02-10 14:57:26 +03:00
-overcommit mem-lock=off \
conf: Explain some code in more detail The code is entirely correct, but it still managed to trip me up when I first ran into it because I did not realize right away that VIR_PCI_CONNECT_TYPES_ENDPOINT was not a single flag, but rather a mask including both VIR_PCI_CONNECT_TYPE_PCI_DEVICE and VIR_PCI_CONNECT_TYPE_PCIE_DEVICE. In order to save the next distracted traveler in PCI Address Land some time, document this fact with a comment. Add a test case for the behavior as well.
2016-10-12 18:02:37 +03:00
-smp 2,sockets=2,cores=1,threads=1 \
-uuid 11dbdcdd-4c3b-482b-8903-9bdb8c0a2774 \
qemu: deprecate QEMU_CAPS_DISPLAY Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko <jtomko@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
2018-03-29 13:51:55 +03:00
-display none \
qemu: deprecate QEMU_CAPS_NO_USER_CONFIG Implied by QEMU >= 1.2.0. Delete this one first, because QEMU_CAPS_NODEFCONFIG is only used when QEMU_CAPS_NO_USER_CONFIG is unsupported. Signed-off-by: Ján Tomko <jtomko@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
2018-03-29 13:51:55 +03:00
-no-user-config \
conf: Explain some code in more detail The code is entirely correct, but it still managed to trip me up when I first ran into it because I did not realize right away that VIR_PCI_CONNECT_TYPES_ENDPOINT was not a single flag, but rather a mask including both VIR_PCI_CONNECT_TYPE_PCI_DEVICE and VIR_PCI_CONNECT_TYPE_PCIE_DEVICE. In order to save the next distracted traveler in PCI Address Land some time, document this fact with a comment. Add a test case for the behavior as well.
2016-10-12 18:02:37 +03:00
-nodefaults \
qemu: Always assume QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE All qemu versions now support FD passing either directly or via FDset. Assume that we always have this capability so that we can simplify chardev handling in many cases. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2022-02-03 15:31:28 +03:00
-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \
qemu: deprecate QEMU_CAPS_MONITOR_JSON We require QEMU >= 1.5.0, assume every QEMU supports it. Sadly that does not let us trivially drop qemuMonitor's priv->monJSON bool, because of qemuDomainQemuAttach. Signed-off-by: Ján Tomko <jtomko@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
2018-03-29 01:04:58 +03:00
-mon chardev=charmonitor,id=monitor,mode=control \
qemu: deprecate QEMU_CAPS_RTC Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko <jtomko@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
2018-03-29 13:51:55 +03:00
-rtc base=utc \
qemu: deprecate QEMU_CAPS_NO_SHUTDOWN Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko <jtomko@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
2018-03-29 13:51:55 +03:00
-no-shutdown \
qemu: command: Always assume 'QEMU_CAPS_BOOT_STRICT' Added by c8a6ae8bb9 in qemu-v1.5.0 and can't be compiled out. Assume that it's present and fix all fake-caps tests. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-09-20 17:22:59 +03:00
-boot strict=on \
qemuxml2argvtest: Enable JSON syntax for -device, -object, and -netdev for all fake-caps tests To minimize upcoming churn in test data when they will be converted to latest capabilities enable JSON syntax for -device, -object, and -netdev for all fake caps test files. Doing this should also help git track renames of the files better as there will be more of consistent context present. We can do this safely as internally we generate JSON first and then back-convert it into the old-style commandline if given qemu doesn't support it. This means that all generated content will be the same. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-08-31 11:56:28 +03:00
-device '{"driver":"i82801b11-bridge","id":"pci.1","bus":"pcie.0","addr":"0x1e"}' \
-device '{"driver":"pci-bridge","chassis_nr":2,"id":"pci.2","bus":"pci.1","addr":"0x0"}' \
qemuxml2argvtest: Assume QEMU_CAPS_DEVICE_PCIE_ROOT_PORT for fake-caps tests Assume the support for the 'pcie-root-port' all modern qemus have to bring the test data closer to the 'latest' real-caps versions. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-09-05 15:42:04 +03:00
-device '{"driver":"pcie-root-port","port":8,"chassis":3,"id":"pci.3","bus":"pcie.0","addr":"0x1"}' \
qemuxml2argvtest: Enable JSON syntax for -device, -object, and -netdev for all fake-caps tests To minimize upcoming churn in test data when they will be converted to latest capabilities enable JSON syntax for -device, -object, and -netdev for all fake caps test files. Doing this should also help git track renames of the files better as there will be more of consistent context present. We can do this safely as internally we generate JSON first and then back-convert it into the old-style commandline if given qemu doesn't support it. This means that all generated content will be the same. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-08-31 11:56:28 +03:00
-netdev '{"type":"user","id":"hostnet0"}' \
-device '{"driver":"e1000e","netdev":"hostnet0","id":"net0","mac":"52:54:00:aa:bf:ef","bus":"pci.2","addr":"0x1"}' \
qemu: command: Always assume QEMU_CAPS_AUDIODEV Generate only new version of the '-audiodev' commandline. The leftover old code and validation will be removed in subsequent patches. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2022-06-22 16:36:23 +03:00
-audiodev '{"id":"audio1","driver":"none"}' \
qemuxml2argvtest: Enable JSON syntax for -device, -object, and -netdev for all fake-caps tests To minimize upcoming churn in test data when they will be converted to latest capabilities enable JSON syntax for -device, -object, and -netdev for all fake caps test files. Doing this should also help git track renames of the files better as there will be more of consistent context present. We can do this safely as internally we generate JSON first and then back-convert it into the old-style commandline if given qemu doesn't support it. This means that all generated content will be the same. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-08-31 11:56:28 +03:00
-device '{"driver":"intel-hda","id":"sound0","bus":"pci.3","addr":"0x0"}' \
-device '{"driver":"hda-duplex","id":"sound0-codec0","bus":"sound0.0","cad":0,"audiodev":"audio1"}' \
qemu: Add implicit watchdog for q35 machine types The iTCO watchdog is part of the q35 machine type since its inception, we just did not add it implicitly. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2137346 Signed-off-by: Martin Kletzander <mkletzan@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
2023-01-20 13:22:22 +03:00
-global ICH9-LPC.noreboot=off \
-watchdog-action reset \
qemuxml2argvtest: Enable 'seccomp' sandbox in all fake caps tests In order to minimize further churn, make all fake-caps test assume that the seccomp sandbox is supported. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2023-08-31 12:43:43 +03:00
-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \
qemu: command: Always assume support for '-msg timestamp=on' All supported QEMU versions have this option so there's no need for us to base it on the capability. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Martin Kletzander <mkletzan@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2021-08-10 18:07:10 +03:00
-msg timestamp=on
Copy Permalink