2006-05-09 19:35:46 +04:00
/*
2007-01-19 23:30:05 +03:00
* testutils . c : basic test utils
2006-05-09 19:35:46 +04:00
*
2015-04-27 20:43:06 +03:00
* Copyright ( C ) 2005 - 2015 Red Hat , Inc .
2006-05-09 19:35:46 +04:00
*
2012-07-27 13:39:53 +04:00
* This library is free software ; you can redistribute it and / or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation ; either
* version 2.1 of the License , or ( at your option ) any later version .
*
* This library is distributed in the hope that it will be useful ,
* but WITHOUT ANY WARRANTY ; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE . See the GNU
* Lesser General Public License for more details .
*
* You should have received a copy of the GNU Lesser General Public
2012-09-21 02:30:55 +04:00
* License along with this library . If not , see
2012-07-27 13:39:53 +04:00
* < http : //www.gnu.org/licenses/>.
2006-05-09 19:35:46 +04:00
*
* Karel Zak < kzak @ redhat . com >
*/
2008-01-29 21:15:54 +03:00
# include <config.h>
2007-12-07 13:08:06 +03:00
2006-05-09 19:35:46 +04:00
# include <stdio.h>
# include <stdlib.h>
2016-05-20 17:27:00 +03:00
# include <stdarg.h>
2006-05-09 19:35:46 +04:00
# include <sys/time.h>
2006-08-24 19:05:19 +04:00
# include <sys/types.h>
# include <sys/stat.h>
2013-02-12 02:12:16 +04:00
# include <sys/wait.h>
# include <regex.h>
2006-08-24 19:05:19 +04:00
# include <unistd.h>
2008-04-18 19:05:29 +04:00
# include <string.h>
2006-08-25 01:46:28 +04:00
# include <fcntl.h>
# include <limits.h>
2006-05-09 19:35:46 +04:00
# include "testutils.h"
2008-04-30 16:30:55 +04:00
# include "internal.h"
2012-12-12 22:06:53 +04:00
# include "viralloc.h"
2012-12-13 21:44:57 +04:00
# include "virutil.h"
2012-12-13 19:49:48 +04:00
# include "virthread.h"
2012-12-13 22:21:53 +04:00
# include "virerror.h"
2012-12-04 16:04:07 +04:00
# include "virbuffer.h"
2012-12-12 21:59:27 +04:00
# include "virlog.h"
2012-12-12 20:27:01 +04:00
# include "vircommand.h"
2012-01-25 19:17:46 +04:00
# include "virrandom.h"
2012-05-25 06:34:16 +04:00
# include "dirname.h"
2012-09-24 21:10:37 +04:00
# include "virprocess.h"
2013-04-03 14:36:23 +04:00
# include "virstring.h"
2008-05-29 19:21:45 +04:00
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
# ifdef TEST_OOM
# ifdef TEST_OOM_TRACE
# include <dlfcn.h>
# include <execinfo.h>
# endif
# endif
2012-05-09 18:18:56 +04:00
# define VIR_FROM_THIS VIR_FROM_NONE
2014-02-28 16:16:17 +04:00
VIR_LOG_INIT ( " tests.testutils " ) ;
2011-07-19 22:32:58 +04:00
# include "virfile.h"
2010-11-09 23:48:48 +03:00
2009-10-16 19:37:36 +04:00
static unsigned int testDebug = - 1 ;
2009-11-30 22:01:31 +03:00
static unsigned int testVerbose = - 1 ;
2013-08-03 01:43:07 +04:00
static unsigned int testExpensive = - 1 ;
2015-12-10 15:30:37 +03:00
static unsigned int testRegenerate = - 1 ;
2009-09-10 14:07:20 +04:00
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
# ifdef TEST_OOM
2014-10-28 21:38:04 +03:00
static unsigned int testOOM ;
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
static unsigned int testOOMStart = - 1 ;
static unsigned int testOOMEnd = - 1 ;
2014-10-28 21:38:04 +03:00
static unsigned int testOOMTrace ;
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
# ifdef TEST_OOM_TRACE
void * testAllocStack [ 30 ] ;
int ntestAllocStack ;
# endif
# endif
2014-10-28 21:38:04 +03:00
static bool testOOMActive ;
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
2014-10-28 21:38:04 +03:00
static size_t testCounter ;
static size_t testStart ;
static size_t testEnd ;
2008-05-29 19:21:45 +04:00
2011-04-29 20:21:20 +04:00
char * progname ;
2016-05-26 18:01:56 +03:00
bool virTestOOMActive ( void )
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
{
return testOOMActive ;
}
2016-05-26 18:01:59 +03:00
static int virTestUseTerminalColors ( void )
2015-09-29 18:28:15 +03:00
{
return isatty ( STDIN_FILENO ) ;
}
2015-04-23 21:02:57 +03:00
static unsigned int
virTestGetFlag ( const char * name )
{
char * flagStr ;
unsigned int flag ;
if ( ( flagStr = getenv ( name ) ) = = NULL )
return 0 ;
if ( virStrToLong_ui ( flagStr , NULL , 10 , & flag ) < 0 )
return 0 ;
return flag ;
}
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
# ifdef TEST_OOM_TRACE
static void virTestAllocHook ( int nalloc ATTRIBUTE_UNUSED ,
void * opaque ATTRIBUTE_UNUSED )
{
ntestAllocStack = backtrace ( testAllocStack , ARRAY_CARDINALITY ( testAllocStack ) ) ;
}
# endif
# ifdef TEST_OOM_TRACE
static void
virTestShowTrace ( void )
{
size_t j ;
for ( j = 2 ; j < ntestAllocStack ; j + + ) {
Dl_info info ;
char * cmd ;
dladdr ( testAllocStack [ j ] , & info ) ;
if ( info . dli_fname & &
strstr ( info . dli_fname , " .so " ) ) {
if ( virAsprintf ( & cmd , ADDR2LINE " -f -e %s %p " ,
info . dli_fname ,
( ( void * ) ( ( unsigned long long ) testAllocStack [ j ]
- ( unsigned long long ) info . dli_fbase ) ) ) < 0 )
continue ;
} else {
if ( virAsprintf ( & cmd , ADDR2LINE " -f -e %s %p " ,
( char * ) ( info . dli_fname ? info . dli_fname : " <unknown> " ) ,
testAllocStack [ j ] ) < 0 )
continue ;
}
ignore_value ( system ( cmd ) ) ;
VIR_FREE ( cmd ) ;
}
}
# endif
2007-01-19 23:30:05 +03:00
/*
2013-09-20 22:13:35 +04:00
* Runs test
2007-01-19 23:30:05 +03:00
*
* returns : - 1 = error , 0 = success
2006-05-09 19:35:46 +04:00
*/
int
2016-05-26 18:01:50 +03:00
virTestRun ( const char * title ,
int ( * body ) ( const void * data ) , const void * data )
2006-05-09 19:35:46 +04:00
{
Convert 'int i' to 'size_t i' in tests/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
int ret = 0 ;
2008-04-18 19:05:29 +04:00
2016-04-18 15:10:33 +03:00
/* Some test are fragile about environ settings. If that's
* the case , don ' t poison it . */
if ( getenv ( " VIR_TEST_MOCK_PROGNAME " ) )
setenv ( " VIR_TEST_MOCK_TESTNAME " , title , 1 ) ;
2011-07-09 13:50:38 +04:00
if ( testCounter = = 0 & & ! virTestGetVerbose ( ) )
fprintf ( stderr , " " ) ;
2008-05-29 19:21:45 +04:00
testCounter + + ;
2008-04-18 19:05:29 +04:00
2013-07-18 18:02:19 +04:00
/* Skip tests if out of range */
if ( ( testStart ! = 0 ) & &
( testCounter < testStart | |
testCounter > testEnd ) )
return 0 ;
2013-09-20 22:11:02 +04:00
if ( virTestGetVerbose ( ) )
fprintf ( stderr , " %2zu) %-65s ... " , testCounter , title ) ;
2007-01-19 23:30:05 +03:00
2013-09-20 22:13:35 +04:00
virResetLastError ( ) ;
ret = body ( data ) ;
virErrorPtr err = virGetLastError ( ) ;
if ( err ) {
if ( virTestGetVerbose ( ) | | virTestGetDebug ( ) )
virDispatchError ( NULL ) ;
2007-01-19 23:30:05 +03:00
}
2013-09-20 22:13:35 +04:00
2013-09-20 22:11:02 +04:00
if ( virTestGetVerbose ( ) ) {
2013-09-20 22:13:35 +04:00
if ( ret = = 0 )
2016-05-26 18:01:59 +03:00
if ( virTestUseTerminalColors ( ) )
2015-09-29 18:28:15 +03:00
fprintf ( stderr , " \ e[32mOK \ e[0m \n " ) ; /* green */
else
fprintf ( stderr , " OK \n " ) ;
2013-09-20 22:11:02 +04:00
else if ( ret = = EXIT_AM_SKIP )
2016-05-26 18:01:59 +03:00
if ( virTestUseTerminalColors ( ) )
2015-09-29 18:28:15 +03:00
fprintf ( stderr , " \ e[34m \ e[1mSKIP \ e[0m \n " ) ; /* bold blue */
else
fprintf ( stderr , " SKIP \n " ) ;
2013-09-20 22:11:02 +04:00
else
2016-05-26 18:01:59 +03:00
if ( virTestUseTerminalColors ( ) )
2015-09-29 18:28:15 +03:00
fprintf ( stderr , " \ e[31m \ e[1mFAILED \ e[0m \n " ) ; /* bold red */
else
fprintf ( stderr , " FAILED \n " ) ;
2013-09-20 22:11:02 +04:00
} else {
if ( testCounter ! = 1 & &
! ( ( testCounter - 1 ) % 40 ) ) {
fprintf ( stderr , " %-3zu \n " , ( testCounter - 1 ) ) ;
fprintf ( stderr , " " ) ;
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
}
2013-09-20 22:11:02 +04:00
if ( ret = = 0 )
2009-11-30 22:01:31 +03:00
fprintf ( stderr , " . " ) ;
2013-09-20 22:11:02 +04:00
else if ( ret = = EXIT_AM_SKIP )
fprintf ( stderr , " _ " ) ;
else
fprintf ( stderr , " ! " ) ;
2008-05-29 19:21:45 +04:00
}
2007-01-19 23:30:05 +03:00
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
# ifdef TEST_OOM
if ( testOOM & & ret ! = EXIT_AM_SKIP ) {
int nalloc ;
int oomret ;
int start , end ;
size_t i ;
virResetLastError ( ) ;
virAllocTestInit ( ) ;
# ifdef TEST_OOM_TRACE
virAllocTestHook ( virTestAllocHook , NULL ) ;
# endif
oomret = body ( data ) ;
nalloc = virAllocTestCount ( ) ;
fprintf ( stderr , " Test OOM for nalloc=%d " , nalloc ) ;
if ( testOOMStart = = - 1 | |
testOOMEnd = = - 1 ) {
start = 0 ;
end = nalloc ;
} else {
start = testOOMStart ;
end = testOOMEnd + 1 ;
}
testOOMActive = true ;
for ( i = start ; i < end ; i + + ) {
bool missingFail = false ;
# ifdef TEST_OOM_TRACE
memset ( testAllocStack , 0 , ARRAY_CARDINALITY ( testAllocStack ) ) ;
ntestAllocStack = 0 ;
# endif
virAllocTestOOM ( i + 1 , 1 ) ;
oomret = body ( data ) ;
/* fprintf() disabled because XML parsing APIs don't allow
* distinguish between element / attribute not present
* in the XML ( which is non - fatal ) , vs OOM / malformed
* which should be fatal . Thus error reporting for
* optionally present XML is mostly broken .
*/
if ( oomret = = 0 ) {
missingFail = true ;
# if 0
fprintf ( stderr , " alloc %zu failed but no err status \n " , i + 1 ) ;
# endif
} else {
virErrorPtr lerr = virGetLastError ( ) ;
if ( ! lerr ) {
# if 0
fprintf ( stderr , " alloc %zu failed but no error report \n " , i + 1 ) ;
# endif
missingFail = true ;
}
}
if ( ( missingFail & & testOOMTrace ) | | ( testOOMTrace > 1 ) ) {
fprintf ( stderr , " %s " , " ! " ) ;
# ifdef TEST_OOM_TRACE
virTestShowTrace ( ) ;
# endif
ret = - 1 ;
} else {
fprintf ( stderr , " %s " , " . " ) ;
}
}
testOOMActive = false ;
if ( ret = = 0 )
fprintf ( stderr , " OK \n " ) ;
else
fprintf ( stderr , " FAILED \n " ) ;
virAllocTestInit ( ) ;
}
# endif /* TEST_OOM */
2016-04-18 15:10:33 +03:00
unsetenv ( " VIR_TEST_MOCK_TESTNAME " ) ;
2007-01-19 23:30:05 +03:00
return ret ;
2006-05-09 19:35:46 +04:00
}
2006-08-24 19:05:19 +04:00
2011-04-25 02:25:10 +04:00
/* Allocate BUF to the size of FILE. Read FILE into buffer BUF.
Upon any failure , diagnose it and return - 1 , but don ' t bother trying
to preserve errno . Otherwise , return the number of bytes copied into BUF . */
int
2016-05-26 18:01:52 +03:00
virTestLoadFile ( const char * file , char * * buf )
2011-04-25 02:25:10 +04:00
{
2009-02-02 23:35:14 +03:00
FILE * fp = fopen ( file , " r " ) ;
2006-08-24 19:05:19 +04:00
struct stat st ;
2011-04-25 02:25:10 +04:00
char * tmp ;
int len , tmplen , buflen ;
2007-01-19 23:30:05 +03:00
2009-02-02 23:35:14 +03:00
if ( ! fp ) {
2012-10-17 13:23:12 +04:00
fprintf ( stderr , " %s: failed to open: %s \n " , file , strerror ( errno ) ) ;
2006-08-24 19:05:19 +04:00
return - 1 ;
2009-02-02 23:35:14 +03:00
}
2006-08-24 19:05:19 +04:00
if ( fstat ( fileno ( fp ) , & st ) < 0 ) {
2012-10-17 13:23:12 +04:00
fprintf ( stderr , " %s: failed to fstat: %s \n " , file , strerror ( errno ) ) ;
2010-11-17 05:13:29 +03:00
VIR_FORCE_FCLOSE ( fp ) ;
2006-08-24 19:05:19 +04:00
return - 1 ;
}
2011-04-25 02:25:10 +04:00
tmplen = buflen = st . st_size + 1 ;
if ( VIR_ALLOC_N ( * buf , buflen ) < 0 ) {
2010-11-17 05:13:29 +03:00
VIR_FORCE_FCLOSE ( fp ) ;
2006-08-24 19:05:19 +04:00
return - 1 ;
}
2011-04-25 02:25:10 +04:00
tmp = * buf ;
2011-01-31 14:42:57 +03:00
( * buf ) [ 0 ] = ' \0 ' ;
2007-01-19 23:30:05 +03:00
if ( st . st_size ) {
2011-01-31 14:42:57 +03:00
/* read the file line by line */
while ( fgets ( tmp , tmplen , fp ) ! = NULL ) {
len = strlen ( tmp ) ;
2011-04-25 02:25:10 +04:00
/* stop on an empty line */
if ( len = = 0 )
break ;
2011-01-31 14:42:57 +03:00
/* remove trailing backslash-newline pair */
if ( len > = 2 & & tmp [ len - 2 ] = = ' \\ ' & & tmp [ len - 1 ] = = ' \n ' ) {
len - = 2 ;
tmp [ len ] = ' \0 ' ;
}
/* advance the temporary buffer pointer */
tmp + = len ;
tmplen - = len ;
}
if ( ferror ( fp ) ) {
2012-10-17 13:23:12 +04:00
fprintf ( stderr , " %s: read failed: %s \n " , file , strerror ( errno ) ) ;
2010-11-17 05:13:29 +03:00
VIR_FORCE_FCLOSE ( fp ) ;
2012-02-03 03:16:43 +04:00
VIR_FREE ( * buf ) ;
2007-01-19 23:30:05 +03:00
return - 1 ;
}
2006-08-24 19:05:19 +04:00
}
2010-11-17 05:13:29 +03:00
VIR_FORCE_FCLOSE ( fp ) ;
2011-01-31 14:42:57 +03:00
return strlen ( * buf ) ;
2006-08-24 19:05:19 +04:00
}
2008-06-26 13:37:51 +04:00
# ifndef WIN32
2006-08-25 01:46:28 +04:00
static
2016-05-26 18:02:03 +03:00
void virTestCaptureProgramExecChild ( const char * const argv [ ] ,
int pipefd )
2014-03-18 12:13:43 +04:00
{
Convert 'int i' to 'size_t i' in tests/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
size_t i ;
2007-01-19 23:30:05 +03:00
int open_max ;
int stdinfd = - 1 ;
const char * const env [ ] = {
" LANG=C " ,
2010-03-09 21:22:22 +03:00
# if WITH_DRIVER_MODULES
2008-11-21 15:16:08 +03:00
" LIBVIRT_DRIVER_DIR= " TEST_DRIVER_DIR ,
2010-03-09 21:22:22 +03:00
# endif
2007-01-19 23:30:05 +03:00
NULL
} ;
2008-12-17 21:04:55 +03:00
if ( ( stdinfd = open ( " /dev/null " , O_RDONLY ) ) < 0 )
2007-01-19 23:30:05 +03:00
goto cleanup ;
2012-10-17 13:23:12 +04:00
open_max = sysconf ( _SC_OPEN_MAX ) ;
2013-07-11 15:22:20 +04:00
if ( open_max < 0 )
goto cleanup ;
2007-01-19 23:30:05 +03:00
for ( i = 0 ; i < open_max ; i + + ) {
if ( i ! = stdinfd & &
2010-11-09 23:48:48 +03:00
i ! = pipefd ) {
Convert 'int i' to 'size_t i' in tests/ files
Convert the type of loop iterators named 'i', 'j', k',
'ii', 'jj', 'kk', to be 'size_t' instead of 'int' or
'unsigned int', also santizing 'ii', 'jj', 'kk' to use
the normal 'i', 'j', 'k' naming
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-07-08 18:09:33 +04:00
int tmpfd ;
tmpfd = i ;
2010-11-09 23:48:48 +03:00
VIR_FORCE_CLOSE ( tmpfd ) ;
}
2007-01-19 23:30:05 +03:00
}
if ( dup2 ( stdinfd , STDIN_FILENO ) ! = STDIN_FILENO )
goto cleanup ;
if ( dup2 ( pipefd , STDOUT_FILENO ) ! = STDOUT_FILENO )
goto cleanup ;
2009-07-06 18:03:31 +04:00
if ( dup2 ( pipefd , STDERR_FILENO ) ! = STDERR_FILENO )
2007-01-19 23:30:05 +03:00
goto cleanup ;
/* SUS is crazy here, hence the cast */
execve ( argv [ 0 ] , ( char * const * ) argv , ( char * const * ) env ) ;
2006-08-25 01:46:28 +04:00
cleanup :
2010-11-09 23:48:48 +03:00
VIR_FORCE_CLOSE ( stdinfd ) ;
2006-08-25 01:46:28 +04:00
}
2011-04-25 02:25:10 +04:00
int
2016-05-26 18:02:05 +03:00
virTestCaptureProgramOutput ( const char * const argv [ ] , char * * buf , int maxlen )
2011-04-25 02:25:10 +04:00
{
2007-01-19 23:30:05 +03:00
int pipefd [ 2 ] ;
2011-04-25 02:25:10 +04:00
int len ;
2007-01-19 23:30:05 +03:00
if ( pipe ( pipefd ) < 0 )
return - 1 ;
build: use correct type for pid and similar types
No thanks to 64-bit windows, with 64-bit pid_t, we have to avoid
constructs like 'int pid'. Our API in libvirt-qemu cannot be
changed without breaking ABI; but then again, libvirt-qemu can
only be used on systems that support UNIX sockets, which rules
out Windows (even if qemu could be compiled there) - so for all
points on the call chain that interact with this API decision,
we require a different variable name to make it clear that we
audited the use for safety.
Adding a syntax-check rule only solves half the battle; anywhere
that uses printf on a pid_t still needs to be converted, but that
will be a separate patch.
* cfg.mk (sc_correct_id_types): New syntax check.
* src/libvirt-qemu.c (virDomainQemuAttach): Document why we didn't
use pid_t for pid, and validate for overflow.
* include/libvirt/libvirt-qemu.h (virDomainQemuAttach): Tweak name
for syntax check.
* src/vmware/vmware_conf.c (vmwareExtractPid): Likewise.
* src/driver.h (virDrvDomainQemuAttach): Likewise.
* tools/virsh.c (cmdQemuAttach): Likewise.
* src/remote/qemu_protocol.x (qemu_domain_attach_args): Likewise.
* src/qemu_protocol-structs (qemu_domain_attach_args): Likewise.
* src/util/cgroup.c (virCgroupPidCode, virCgroupKillInternal):
Likewise.
* src/qemu/qemu_command.c(qemuParseProcFileStrings): Likewise.
(qemuParseCommandLinePid): Use pid_t for pid.
* daemon/libvirtd.c (daemonForkIntoBackground): Likewise.
* src/conf/domain_conf.h (_virDomainObj): Likewise.
* src/probes.d (rpc_socket_new): Likewise.
* src/qemu/qemu_command.h (qemuParseCommandLinePid): Likewise.
* src/qemu/qemu_driver.c (qemudGetProcessInfo, qemuDomainAttach):
Likewise.
* src/qemu/qemu_process.c (qemuProcessAttach): Likewise.
* src/qemu/qemu_process.h (qemuProcessAttach): Likewise.
* src/uml/uml_driver.c (umlGetProcessInfo): Likewise.
* src/util/virnetdev.h (virNetDevSetNamespace): Likewise.
* src/util/virnetdev.c (virNetDevSetNamespace): Likewise.
* tests/testutils.c (virtTestCaptureProgramOutput): Likewise.
* src/conf/storage_conf.h (_virStoragePerms): Use mode_t, uid_t,
and gid_t rather than int.
* src/security/security_dac.c (virSecurityDACSetOwnership): Likewise.
* src/conf/storage_conf.c (virStorageDefParsePerms): Avoid
compiler warning.
2012-02-11 03:08:11 +04:00
pid_t pid = fork ( ) ;
2007-01-19 23:30:05 +03:00
switch ( pid ) {
2006-08-25 01:46:28 +04:00
case 0 :
2010-11-09 23:48:48 +03:00
VIR_FORCE_CLOSE ( pipefd [ 0 ] ) ;
2016-05-26 18:02:03 +03:00
virTestCaptureProgramExecChild ( argv , pipefd [ 1 ] ) ;
2007-01-19 23:30:05 +03:00
2010-11-09 23:48:48 +03:00
VIR_FORCE_CLOSE ( pipefd [ 1 ] ) ;
2013-02-23 02:42:39 +04:00
_exit ( EXIT_FAILURE ) ;
2007-01-19 23:30:05 +03:00
2006-08-25 01:46:28 +04:00
case - 1 :
return - 1 ;
2007-01-19 23:30:05 +03:00
2006-08-25 01:46:28 +04:00
default :
2011-04-25 02:25:10 +04:00
VIR_FORCE_CLOSE ( pipefd [ 1 ] ) ;
len = virFileReadLimFD ( pipefd [ 0 ] , maxlen , buf ) ;
VIR_FORCE_CLOSE ( pipefd [ 0 ] ) ;
2014-02-20 07:23:44 +04:00
if ( virProcessWait ( pid , NULL , false ) < 0 )
2011-10-21 21:09:23 +04:00
return - 1 ;
2006-08-25 01:46:28 +04:00
2011-04-25 02:25:10 +04:00
return len ;
2007-01-19 23:30:05 +03:00
}
2006-08-25 01:46:28 +04:00
}
2010-03-17 02:36:07 +03:00
# else /* !WIN32 */
2011-04-25 02:25:10 +04:00
int
2016-05-26 18:02:05 +03:00
virTestCaptureProgramOutput ( const char * const argv [ ] ATTRIBUTE_UNUSED ,
char * * buf ATTRIBUTE_UNUSED ,
int maxlen ATTRIBUTE_UNUSED )
2011-04-25 02:25:10 +04:00
{
2010-03-17 02:36:07 +03:00
return - 1 ;
}
2008-06-26 13:37:51 +04:00
# endif /* !WIN32 */
2008-04-18 19:05:29 +04:00
2016-01-13 04:26:00 +03:00
static int
virTestRewrapFile ( const char * filename )
{
int ret = - 1 ;
char * outbuf = NULL ;
char * script = NULL ;
virCommandPtr cmd = NULL ;
if ( virAsprintf ( & script , " %s/test-wrap-argv.pl " , abs_srcdir ) < 0 )
goto cleanup ;
cmd = virCommandNewArgList ( script , filename , NULL ) ;
virCommandSetOutputBuffer ( cmd , & outbuf ) ;
if ( virCommandRun ( cmd , NULL ) < 0 )
goto cleanup ;
if ( virFileWriteStr ( filename , outbuf , 0666 ) < 0 )
goto cleanup ;
ret = 0 ;
cleanup :
VIR_FREE ( script ) ;
virCommandFree ( cmd ) ;
VIR_FREE ( outbuf ) ;
return ret ;
}
2008-04-18 19:05:29 +04:00
/**
2015-04-28 18:43:12 +03:00
* @ param stream : output stream to write differences to
2008-04-18 19:05:29 +04:00
* @ param expect : expected output text
2014-10-29 17:53:36 +03:00
* @ param expectName : name designator of the expected text
2008-04-18 19:05:29 +04:00
* @ param actual : actual output text
2014-10-29 17:53:36 +03:00
* @ param actualName : name designator of the actual text
2015-12-10 15:40:54 +03:00
* @ param regenerate : enable or disable regenerate functionality
2008-04-18 19:05:29 +04:00
*
2014-10-29 17:53:36 +03:00
* Display expected and actual output text , trimmed to first and last
* characters at which differences occur . Displays names of the text strings if
* non - NULL .
2008-04-18 19:05:29 +04:00
*/
2015-12-10 15:40:54 +03:00
static int
2016-05-26 18:02:02 +03:00
virTestDifferenceFullInternal ( FILE * stream ,
const char * expect ,
const char * expectName ,
const char * actual ,
const char * actualName ,
bool regenerate )
2008-04-18 19:05:29 +04:00
{
2013-03-04 20:30:40 +04:00
const char * expectStart ;
const char * expectEnd ;
const char * actualStart ;
const char * actualEnd ;
if ( ! expect )
expect = " " ;
if ( ! actual )
actual = " " ;
expectStart = expect ;
expectEnd = expect + ( strlen ( expect ) - 1 ) ;
actualStart = actual ;
actualEnd = actual + ( strlen ( actual ) - 1 ) ;
2008-04-18 19:05:29 +04:00
2016-01-12 18:55:08 +03:00
if ( expectName & & regenerate & & ( virTestGetRegenerate ( ) > 0 ) ) {
2016-01-13 04:26:00 +03:00
if ( virFileWriteStr ( expectName , actual , 0666 ) < 0 ) {
virDispatchError ( NULL ) ;
2016-01-04 22:31:58 +03:00
return - 1 ;
2016-01-13 04:26:00 +03:00
}
2016-01-04 22:31:58 +03:00
2016-01-13 04:26:00 +03:00
if ( virTestRewrapFile ( expectName ) < 0 ) {
virDispatchError ( NULL ) ;
2015-12-10 15:40:54 +03:00
return - 1 ;
2016-01-04 22:31:58 +03:00
}
2015-12-10 15:40:54 +03:00
}
2009-11-30 22:01:31 +03:00
if ( ! virTestGetDebug ( ) )
2008-05-29 19:21:45 +04:00
return 0 ;
2009-11-30 22:01:31 +03:00
if ( virTestGetDebug ( ) < 2 ) {
2008-04-30 16:30:55 +04:00
/* Skip to first character where they differ */
while ( * expectStart & & * actualStart & &
* actualStart = = * expectStart ) {
actualStart + + ;
expectStart + + ;
}
2008-04-18 19:05:29 +04:00
2008-04-30 16:30:55 +04:00
/* Work backwards to last character where they differ */
while ( actualEnd > actualStart & &
expectEnd > expectStart & &
* actualEnd = = * expectEnd ) {
actualEnd - - ;
expectEnd - - ;
}
2008-04-18 19:05:29 +04:00
}
/* Show the trimmed differences */
2014-10-29 17:53:36 +03:00
if ( expectName )
fprintf ( stream , " \n In '%s': " , expectName ) ;
2011-09-17 17:57:26 +04:00
fprintf ( stream , " \n Offset %d \n Expect [ " , ( int ) ( expectStart - expect ) ) ;
2008-04-18 19:05:29 +04:00
if ( ( expectEnd - expectStart + 1 ) & &
fwrite ( expectStart , ( expectEnd - expectStart + 1 ) , 1 , stream ) ! = 1 )
return - 1 ;
fprintf ( stream , " ] \n " ) ;
2014-10-29 17:53:36 +03:00
if ( actualName )
fprintf ( stream , " In '%s': \n " , actualName ) ;
2008-04-18 19:05:29 +04:00
fprintf ( stream , " Actual [ " ) ;
if ( ( actualEnd - actualStart + 1 ) & &
fwrite ( actualStart , ( actualEnd - actualStart + 1 ) , 1 , stream ) ! = 1 )
return - 1 ;
fprintf ( stream , " ] \n " ) ;
/* Pad to line up with test name ... in virTestRun */
fprintf ( stream , " ... " ) ;
return 0 ;
}
2008-05-29 19:21:45 +04:00
2015-12-10 15:40:54 +03:00
/**
* @ param stream : output stream to write differences to
* @ param expect : expected output text
* @ param expectName : name designator of the expected text
* @ param actual : actual output text
* @ param actualName : name designator of the actual text
*
* Display expected and actual output text , trimmed to first and last
* characters at which differences occur . Displays names of the text strings if
* non - NULL . If VIR_TEST_REGENERATE_OUTPUT is used , this function will
* regenerate the expected file .
*/
int
2016-05-26 18:01:54 +03:00
virTestDifferenceFull ( FILE * stream ,
const char * expect ,
const char * expectName ,
const char * actual ,
const char * actualName )
2015-12-10 15:40:54 +03:00
{
2016-05-26 18:02:02 +03:00
return virTestDifferenceFullInternal ( stream , expect , expectName ,
actual , actualName , true ) ;
2015-12-10 15:40:54 +03:00
}
/**
* @ param stream : output stream to write differences to
* @ param expect : expected output text
* @ param expectName : name designator of the expected text
* @ param actual : actual output text
* @ param actualName : name designator of the actual text
*
* Display expected and actual output text , trimmed to first and last
* characters at which differences occur . Displays names of the text strings if
* non - NULL . If VIR_TEST_REGENERATE_OUTPUT is used , this function will not
* regenerate the expected file .
*/
int
2016-05-26 18:02:01 +03:00
virTestDifferenceFullNoRegenerate ( FILE * stream ,
const char * expect ,
const char * expectName ,
const char * actual ,
const char * actualName )
2015-12-10 15:40:54 +03:00
{
2016-05-26 18:02:02 +03:00
return virTestDifferenceFullInternal ( stream , expect , expectName ,
actual , actualName , false ) ;
2015-12-10 15:40:54 +03:00
}
2014-10-29 17:53:36 +03:00
/**
2015-04-28 18:43:12 +03:00
* @ param stream : output stream to write differences to
2014-10-29 17:53:36 +03:00
* @ param expect : expected output text
* @ param actual : actual output text
*
* Display expected and actual output text , trimmed to
* first and last characters at which differences occur
*/
2015-12-10 15:40:54 +03:00
int
2016-05-26 18:01:51 +03:00
virTestDifference ( FILE * stream ,
const char * expect ,
const char * actual )
2014-10-29 17:53:36 +03:00
{
2016-05-26 18:02:01 +03:00
return virTestDifferenceFullNoRegenerate ( stream ,
expect , NULL ,
actual , NULL ) ;
2014-10-29 17:53:36 +03:00
}
2010-12-06 20:03:22 +03:00
/**
2015-04-28 18:43:12 +03:00
* @ param stream : output stream to write differences to
2010-12-06 20:03:22 +03:00
* @ param expect : expected output text
* @ param actual : actual output text
*
* Display expected and actual output text , trimmed to
* first and last characters at which differences occur
*/
2016-05-26 18:02:04 +03:00
int virTestDifferenceBin ( FILE * stream ,
const char * expect ,
const char * actual ,
size_t length )
2010-12-06 20:03:22 +03:00
{
size_t start = 0 , end = length ;
ssize_t i ;
if ( ! virTestGetDebug ( ) )
return 0 ;
if ( virTestGetDebug ( ) < 2 ) {
/* Skip to first character where they differ */
2013-05-21 11:53:48 +04:00
for ( i = 0 ; i < length ; i + + ) {
2010-12-06 20:03:22 +03:00
if ( expect [ i ] ! = actual [ i ] ) {
start = i ;
break ;
}
}
/* Work backwards to last character where they differ */
2013-05-21 11:53:48 +04:00
for ( i = ( length - 1 ) ; i > = 0 ; i - - ) {
2010-12-06 20:03:22 +03:00
if ( expect [ i ] ! = actual [ i ] ) {
end = i ;
break ;
}
}
}
2011-06-24 18:01:10 +04:00
/* Round to nearest boundary of 4, except that last word can be short */
2010-12-06 20:03:22 +03:00
start - = ( start % 4 ) ;
end + = 4 - ( end % 4 ) ;
if ( end > = length )
end = length - 1 ;
/* Show the trimmed differences */
fprintf ( stream , " \n Expect [ Region %d-%d " , ( int ) start , ( int ) end ) ;
2013-05-21 11:53:48 +04:00
for ( i = start ; i < end ; i + + ) {
2010-12-06 20:03:22 +03:00
if ( ( i % 4 ) = = 0 )
fprintf ( stream , " \n " ) ;
fprintf ( stream , " 0x%02x, " , ( ( int ) expect [ i ] ) & 0xff ) ;
}
fprintf ( stream , " ] \n " ) ;
fprintf ( stream , " Actual [ Region %d-%d " , ( int ) start , ( int ) end ) ;
2013-05-21 11:53:48 +04:00
for ( i = start ; i < end ; i + + ) {
2010-12-06 20:03:22 +03:00
if ( ( i % 4 ) = = 0 )
fprintf ( stream , " \n " ) ;
fprintf ( stream , " 0x%02x, " , ( ( int ) actual [ i ] ) & 0xff ) ;
}
fprintf ( stream , " ] \n " ) ;
/* Pad to line up with test name ... in virTestRun */
fprintf ( stream , " ... " ) ;
return 0 ;
}
2015-04-23 18:14:26 +03:00
/*
* @ param strcontent : String input content
* @ param filename : File to compare strcontent against
*/
int
2016-05-26 18:01:53 +03:00
virTestCompareToFile ( const char * strcontent ,
const char * filename )
2015-04-23 18:14:26 +03:00
{
int ret = - 1 ;
char * filecontent = NULL ;
char * fixedcontent = NULL ;
2016-05-26 18:01:52 +03:00
if ( virTestLoadFile ( filename , & filecontent ) < 0 & & ! virTestGetRegenerate ( ) )
2015-04-23 18:14:26 +03:00
goto failure ;
2015-04-23 21:02:57 +03:00
if ( filecontent & &
filecontent [ strlen ( filecontent ) - 1 ] = = ' \n ' & &
2015-04-23 18:14:26 +03:00
strcontent [ strlen ( strcontent ) - 1 ] ! = ' \n ' ) {
if ( virAsprintf ( & fixedcontent , " %s \n " , strcontent ) < 0 )
goto failure ;
}
2015-04-23 21:02:57 +03:00
if ( STRNEQ_NULLABLE ( fixedcontent ? fixedcontent : strcontent ,
filecontent ) ) {
2016-05-26 18:01:54 +03:00
virTestDifferenceFull ( stderr ,
filecontent , filename ,
strcontent , NULL ) ;
2015-04-23 18:14:26 +03:00
goto failure ;
}
ret = 0 ;
failure :
VIR_FREE ( fixedcontent ) ;
VIR_FREE ( filecontent ) ;
return ret ;
}
2008-05-29 19:21:45 +04:00
static void
virtTestErrorFuncQuiet ( void * data ATTRIBUTE_UNUSED ,
virErrorPtr err ATTRIBUTE_UNUSED )
{ }
2013-09-17 17:20:24 +04:00
/* register an error handler in tests when using connections */
void
2016-05-26 18:02:00 +03:00
virTestQuiesceLibvirtErrors ( bool always )
2013-09-17 17:20:24 +04:00
{
if ( always | | ! virTestGetVerbose ( ) )
virSetErrorFunc ( NULL , virtTestErrorFuncQuiet ) ;
}
2008-05-29 19:21:45 +04:00
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
struct virtTestLogData {
virBuffer buf ;
} ;
static struct virtTestLogData testLog = { VIR_BUFFER_INITIALIZER } ;
2012-09-20 22:24:00 +04:00
static void
2014-02-27 21:44:53 +04:00
virtTestLogOutput ( virLogSourcePtr source ATTRIBUTE_UNUSED ,
2012-09-27 16:58:58 +04:00
virLogPriority priority ATTRIBUTE_UNUSED ,
2012-09-27 17:28:44 +04:00
const char * filename ATTRIBUTE_UNUSED ,
int lineno ATTRIBUTE_UNUSED ,
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
const char * funcname ATTRIBUTE_UNUSED ,
2011-09-28 17:20:07 +04:00
const char * timestamp ,
2012-10-17 22:17:15 +04:00
virLogMetadataPtr metadata ATTRIBUTE_UNUSED ,
2012-05-09 18:18:56 +04:00
unsigned int flags ,
2012-09-27 15:45:33 +04:00
const char * rawstr ATTRIBUTE_UNUSED ,
2011-09-28 17:20:07 +04:00
const char * str ,
void * data )
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
{
struct virtTestLogData * log = data ;
2012-09-20 22:24:00 +04:00
virCheckFlags ( VIR_LOG_STACK_TRACE , ) ;
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
if ( ! testOOMActive )
virBufferAsprintf ( & log - > buf , " %s: %s " , timestamp , str ) ;
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
}
static void
virtTestLogClose ( void * data )
{
struct virtTestLogData * log = data ;
virBufferFreeAndReset ( & log - > buf ) ;
}
/* Return a malloc'd string (possibly with strlen of 0) of all data
* logged since the last call to this function , or NULL on failure . */
char *
2016-05-26 18:01:58 +03:00
virTestLogContentAndReset ( void )
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
{
char * ret ;
if ( virBufferError ( & testLog . buf ) )
return NULL ;
ret = virBufferContentAndReset ( & testLog . buf ) ;
2013-05-03 16:52:21 +04:00
if ( ! ret )
ignore_value ( VIR_STRDUP ( ret , " " ) ) ;
return ret ;
tests: silence qemuargv2xmltest noise
Before this patch, the testsuite was noisy:
TEST: qemuargv2xmltest
........................................ 40
................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
. 57 OK
PASS: qemuargv2xmltest
It's not a real failure (which is why the test was completing
successfully), so much as an intentional warning to the user that use
of the qemu namespace has the potential for undefined effects that
leaked through the default logging behavior. After this patch series,
all tests can access any logged data, and this particular test can
explicitly check for the presence or absence of the warning, such that
the test output becomes:
TEST: qemuargv2xmltest
........................................ 40
................. 57 OK
PASS: qemuargv2xmltest
* tests/testutils.h (virtTestLogContentAndReset): New prototype.
* tests/testutils.c (struct virtTestLogData): New struct.
(virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
New functions.
(virtTestMain): Always capture log data emitted during tests.
* tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
Use flag to mark which tests expect noisy stderr.
(testCompareXMLToArgvFiles): Add parameter to test whether stderr
was appropriately silent.
2010-09-10 20:25:49 +04:00
}
2008-05-29 19:21:45 +04:00
2009-11-30 22:01:31 +03:00
unsigned int
2014-03-18 12:13:43 +04:00
virTestGetDebug ( void )
{
2009-11-30 22:01:31 +03:00
if ( testDebug = = - 1 )
testDebug = virTestGetFlag ( " VIR_TEST_DEBUG " ) ;
2009-10-16 19:37:36 +04:00
return testDebug ;
}
2008-05-29 19:21:45 +04:00
2009-11-30 22:01:31 +03:00
unsigned int
2014-03-18 12:13:43 +04:00
virTestGetVerbose ( void )
{
2009-11-30 22:01:31 +03:00
if ( testVerbose = = - 1 )
testVerbose = virTestGetFlag ( " VIR_TEST_VERBOSE " ) ;
return testVerbose | | virTestGetDebug ( ) ;
}
2013-08-03 01:43:07 +04:00
unsigned int
2014-03-18 12:13:43 +04:00
virTestGetExpensive ( void )
{
2013-08-03 01:43:07 +04:00
if ( testExpensive = = - 1 )
testExpensive = virTestGetFlag ( " VIR_TEST_EXPENSIVE " ) ;
return testExpensive ;
}
2015-12-10 15:30:37 +03:00
unsigned int
virTestGetRegenerate ( void )
{
if ( testRegenerate = = - 1 )
testRegenerate = virTestGetFlag ( " VIR_TEST_REGENERATE_OUTPUT " ) ;
return testRegenerate ;
}
tests: Set PATH in each test
Currently we spawn couple of binaries in our test suite.
Moreover, we provide some spoofed versions of system binaries
hoping that those will be executed instead of the system ones.
For instance, for testing SSH socket we have written our own ssh
binary for producing predictable results. We certainly don't want
to execute the system ssh binary.
However, in order to prefer our binaries over system ones, we
need to set PATH environment variable. But this is done only at
the Makefile level. So if anybody runs a test by hand that
expects our spoofed binary, the test ends up executing real
system binaries. This is not good. In fact, it's terribly wrong.
The fix lies in a small trick - putting our build directory at
the beginning of the PATH environment variable in each test.
Hopefully, since every test has this VIRT_TEST_MAIN* wrapper, we
can fix this at a single place.
Moreover, while this removes setting PATH for our tests written
in bash, it's safe as we are not calling anything ours that would
require PATH change there.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2016-03-17 15:30:42 +03:00
static int
virTestSetEnvPath ( void )
{
int ret = - 1 ;
const char * path = getenv ( " PATH " ) ;
char * new_path = NULL ;
2016-03-24 16:57:42 +03:00
if ( path ) {
if ( strstr ( path , abs_builddir ) ! = path & &
virAsprintf ( & new_path , " %s:%s " , abs_builddir , path ) < 0 )
goto cleanup ;
} else {
if ( VIR_STRDUP ( new_path , abs_builddir ) < 0 )
goto cleanup ;
}
2016-03-25 12:20:28 +03:00
if ( new_path & &
setenv ( " PATH " , new_path , 1 ) < 0 )
tests: Set PATH in each test
Currently we spawn couple of binaries in our test suite.
Moreover, we provide some spoofed versions of system binaries
hoping that those will be executed instead of the system ones.
For instance, for testing SSH socket we have written our own ssh
binary for producing predictable results. We certainly don't want
to execute the system ssh binary.
However, in order to prefer our binaries over system ones, we
need to set PATH environment variable. But this is done only at
the Makefile level. So if anybody runs a test by hand that
expects our spoofed binary, the test ends up executing real
system binaries. This is not good. In fact, it's terribly wrong.
The fix lies in a small trick - putting our build directory at
the beginning of the PATH environment variable in each test.
Hopefully, since every test has this VIRT_TEST_MAIN* wrapper, we
can fix this at a single place.
Moreover, while this removes setting PATH for our tests written
in bash, it's safe as we are not calling anything ours that would
require PATH change there.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2016-03-17 15:30:42 +03:00
goto cleanup ;
ret = 0 ;
cleanup :
VIR_FREE ( new_path ) ;
return ret ;
}
2016-04-18 15:10:33 +03:00
# define TEST_MOCK (abs_builddir " / .libs / virtestmock.so")
2008-05-29 19:21:45 +04:00
int virtTestMain ( int argc ,
char * * argv ,
2016-05-20 17:27:00 +03:00
int ( * func ) ( void ) ,
. . . )
2008-05-29 19:21:45 +04:00
{
2016-05-20 17:27:00 +03:00
const char * lib ;
va_list ap ;
2008-05-29 19:21:45 +04:00
int ret ;
2013-07-18 18:02:19 +04:00
char * testRange = NULL ;
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
# ifdef TEST_OOM
char * oomstr ;
# endif
2008-07-09 14:27:17 +04:00
2016-04-18 15:10:33 +03:00
if ( getenv ( " VIR_TEST_FILE_ACCESS " ) )
VIRT_TEST_PRELOAD ( TEST_MOCK ) ;
2016-05-20 17:27:00 +03:00
va_start ( ap , func ) ;
while ( ( lib = va_arg ( ap , const char * ) ) )
2016-04-18 15:10:33 +03:00
VIRT_TEST_PRELOAD ( lib ) ;
2016-05-20 17:27:00 +03:00
va_end ( ap ) ;
2016-04-18 15:10:33 +03:00
progname = last_component ( argv [ 0 ] ) ;
if ( STRPREFIX ( progname , " lt- " ) )
progname + = 3 ;
setenv ( " VIR_TEST_MOCK_PROGNAME " , progname , 1 ) ;
2014-04-24 18:57:36 +04:00
virFileActivateDirOverride ( argv [ 0 ] ) ;
tests: Set PATH in each test
Currently we spawn couple of binaries in our test suite.
Moreover, we provide some spoofed versions of system binaries
hoping that those will be executed instead of the system ones.
For instance, for testing SSH socket we have written our own ssh
binary for producing predictable results. We certainly don't want
to execute the system ssh binary.
However, in order to prefer our binaries over system ones, we
need to set PATH environment variable. But this is done only at
the Makefile level. So if anybody runs a test by hand that
expects our spoofed binary, the test ends up executing real
system binaries. This is not good. In fact, it's terribly wrong.
The fix lies in a small trick - putting our build directory at
the beginning of the PATH environment variable in each test.
Hopefully, since every test has this VIRT_TEST_MAIN* wrapper, we
can fix this at a single place.
Moreover, while this removes setting PATH for our tests written
in bash, it's safe as we are not calling anything ours that would
require PATH change there.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
2016-03-17 15:30:42 +03:00
if ( virTestSetEnvPath ( ) < 0 )
return EXIT_AM_HARDFAIL ;
2013-11-28 01:31:53 +04:00
if ( ! virFileExists ( abs_srcdir ) )
2013-02-23 02:42:39 +04:00
return EXIT_AM_HARDFAIL ;
2011-04-29 20:21:20 +04:00
if ( argc > 1 ) {
fprintf ( stderr , " Usage: %s \n " , argv [ 0 ] ) ;
2012-05-08 21:46:45 +04:00
fputs ( " effective environment variables: \n "
" VIR_TEST_VERBOSE set to show names of individual tests \n "
" VIR_TEST_DEBUG set to show information for debugging failures \n " ,
stderr ) ;
2011-04-29 20:21:20 +04:00
return EXIT_FAILURE ;
}
fprintf ( stderr , " TEST: %s \n " , progname ) ;
2009-11-30 22:01:31 +03:00
2009-01-29 00:53:48 +03:00
if ( virThreadInitialize ( ) < 0 | |
2012-08-04 03:15:00 +04:00
virErrorInitialize ( ) < 0 )
2013-02-23 02:42:39 +04:00
return EXIT_FAILURE ;
2009-01-29 00:53:48 +03:00
2010-10-13 12:41:47 +04:00
virLogSetFromEnv ( ) ;
2010-12-06 20:03:35 +03:00
if ( ! getenv ( " LIBVIRT_DEBUG " ) & & ! virLogGetNbOutputs ( ) ) {
if ( virLogDefineOutput ( virtTestLogOutput , virtTestLogClose , & testLog ,
2012-09-27 17:04:21 +04:00
VIR_LOG_DEBUG , VIR_LOG_TO_STDERR , NULL , 0 ) < 0 )
2013-02-23 02:42:39 +04:00
return EXIT_FAILURE ;
2010-12-06 20:03:35 +03:00
}
2008-05-29 19:21:45 +04:00
2013-07-18 18:02:19 +04:00
if ( ( testRange = getenv ( " VIR_TEST_RANGE " ) ) ! = NULL ) {
char * end = NULL ;
2013-07-19 16:07:41 +04:00
unsigned int iv ;
if ( virStrToLong_ui ( testRange , & end , 10 , & iv ) < 0 ) {
2013-07-18 18:02:19 +04:00
fprintf ( stderr , " Cannot parse range %s \n " , testRange ) ;
return EXIT_FAILURE ;
}
2013-07-19 16:07:41 +04:00
testStart = testEnd = iv ;
2013-07-18 18:02:19 +04:00
if ( end & & * end ) {
if ( * end ! = ' - ' ) {
fprintf ( stderr , " Cannot parse range %s \n " , testRange ) ;
return EXIT_FAILURE ;
}
end + + ;
2013-07-19 16:07:41 +04:00
if ( virStrToLong_ui ( end , NULL , 10 , & iv ) < 0 ) {
2013-07-18 18:02:19 +04:00
fprintf ( stderr , " Cannot parse range %s \n " , testRange ) ;
return EXIT_FAILURE ;
}
2013-07-19 16:07:41 +04:00
testEnd = iv ;
2013-07-18 18:02:19 +04:00
if ( testEnd < testStart ) {
fprintf ( stderr , " Test range end %zu must be >= %zu \n " , testEnd , testStart ) ;
return EXIT_FAILURE ;
}
}
}
Introduce new OOM testing support
The previous OOM testing support would re-run the entire "main"
method each iteration, failing a different malloc each time.
When a test suite has 'n' allocations, the number of repeats
requires is (n * (n + 1) ) / 2. This gets very large, very
quickly.
This new OOM testing support instead integrates at the
virtTestRun level, so each individual test case gets repeated,
instead of the entire test suite. This means the values of
'n' are orders of magnitude smaller.
The simple usage is
$ VIR_TEST_OOM=1 ./qemuxml2argvtest
...
29) QEMU XML-2-ARGV clock-utc ... OK
Test OOM for nalloc=36 .................................... OK
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 .................................... OK
31) QEMU XML-2-ARGV clock-france ... OK
Test OOM for nalloc=38 ...................................... OK
...
the second lines reports how many mallocs have to be failed, and thus
how many repeats of the test will be run.
If it crashes, then running under valgrind will often show the problem
$ VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When debugging problems it is also helpful to select an individual
test case
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1 ../run valgrind ./qemuxml2argvtest
When things get really tricky, it is possible to request that just
specific allocs are failed. eg to fail allocs 5 -> 12, use
$ VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-12 ../run valgrind ./qemuxml2argvtest
In the worse case, you might want to know the stack trace of the
alloc which was failed then VIR_TEST_OOM_TRACE can be set. If it
is set to 1 then it will only print if it thinks a mistake happened.
This is often not reliable, so setting it to 2 will make it print
the stack trace for every alloc that is failed.
$ VIR_TEST_OOM_TRACE=2 VIR_TEST_RANGE=30 VIR_TEST_OOM=1:5-5 ../run valgrind ./qemuxml2argvtest
30) QEMU XML-2-ARGV clock-localtime ... OK
Test OOM for nalloc=36 !virAllocN
/home/berrange/src/virt/libvirt/src/util/viralloc.c:180
virHashCreateFull
/home/berrange/src/virt/libvirt/src/util/virhash.c:144
virDomainDefParseXML
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:11745
virDomainDefParseNode
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12646
virDomainDefParse
/home/berrange/src/virt/libvirt/src/conf/domain_conf.c:12590
testCompareXMLToArgvFiles
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:106
virtTestRun
/home/berrange/src/virt/libvirt/tests/testutils.c:250
mymain
/home/berrange/src/virt/libvirt/tests/qemuxml2argvtest.c:418 (discriminator 2)
virtTestMain
/home/berrange/src/virt/libvirt/tests/testutils.c:750
??
??:0
_start
??:?
FAILED
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2013-09-23 17:21:52 +04:00
# ifdef TEST_OOM
if ( ( oomstr = getenv ( " VIR_TEST_OOM " ) ) ! = NULL ) {
char * next ;
if ( testDebug = = - 1 )
testDebug = 1 ;
testOOM = 1 ;
if ( oomstr [ 0 ] ! = ' \0 ' & &
oomstr [ 1 ] = = ' : ' ) {
if ( virStrToLong_ui ( oomstr + 2 , & next , 10 , & testOOMStart ) < 0 ) {
fprintf ( stderr , " Cannot parse range %s \n " , oomstr ) ;
return EXIT_FAILURE ;
}
if ( * next = = ' \0 ' ) {
testOOMEnd = testOOMStart ;
} else {
if ( * next ! = ' - ' ) {
fprintf ( stderr , " Cannot parse range %s \n " , oomstr ) ;
return EXIT_FAILURE ;
}
if ( virStrToLong_ui ( next + 1 , NULL , 10 , & testOOMEnd ) < 0 ) {
fprintf ( stderr , " Cannot parse range %s \n " , oomstr ) ;
return EXIT_FAILURE ;
}
}
} else {
testOOMStart = - 1 ;
testOOMEnd = - 1 ;
}
}
# ifdef TEST_OOM_TRACE
if ( ( oomstr = getenv ( " VIR_TEST_OOM_TRACE " ) ) ! = NULL ) {
if ( virStrToLong_ui ( oomstr , NULL , 10 , & testOOMTrace ) < 0 ) {
fprintf ( stderr , " Cannot parse oom trace %s \n " , oomstr ) ;
return EXIT_FAILURE ;
}
}
# else
if ( getenv ( " VIR_TEST_OOM_TRACE " ) ) {
fprintf ( stderr , " %s " , " OOM test tracing not enabled in this build \n " ) ;
return EXIT_FAILURE ;
}
# endif
# else /* TEST_OOM */
if ( getenv ( " VIR_TEST_OOM " ) ) {
fprintf ( stderr , " %s " , " OOM testing not enabled in this build \n " ) ;
return EXIT_FAILURE ;
}
if ( getenv ( " VIR_TEST_OOM_TRACE " ) ) {
fprintf ( stderr , " %s " , " OOM test tracing not enabled in this build \n " ) ;
return EXIT_FAILURE ;
}
# endif /* TEST_OOM */
2011-04-29 20:21:20 +04:00
ret = ( func ) ( ) ;
2009-01-29 00:53:48 +03:00
virResetLastError ( ) ;
2011-07-09 13:50:38 +04:00
if ( ! virTestGetVerbose ( ) & & ret ! = EXIT_AM_SKIP ) {
2011-07-11 19:19:11 +04:00
if ( testCounter = = 0 | | testCounter % 40 )
2013-07-18 18:02:19 +04:00
fprintf ( stderr , " %*s " , 40 - ( int ) ( testCounter % 40 ) , " " ) ;
fprintf ( stderr , " %-3zu %s \n " , testCounter , ret = = 0 ? " OK " : " FAIL " ) ;
2009-11-30 22:01:31 +03:00
}
2009-01-29 00:53:48 +03:00
return ret ;
2008-05-29 19:21:45 +04:00
}
2009-05-21 18:22:51 +04:00
2014-03-20 14:30:44 +04:00
/*
* @ cmdset contains a list of command line args , eg
*
* " /usr/sbin/iptables --table filter --insert INPUT --in-interface virbr0 --protocol tcp --destination-port 53 --jump ACCEPT
* / usr / sbin / iptables - - table filter - - insert INPUT - - in - interface virbr0 - - protocol udp - - destination - port 53 - - jump ACCEPT
* / usr / sbin / iptables - - table filter - - insert FORWARD - - in - interface virbr0 - - jump REJECT
* / usr / sbin / iptables - - table filter - - insert FORWARD - - out - interface virbr0 - - jump REJECT
* / usr / sbin / iptables - - table filter - - insert FORWARD - - in - interface virbr0 - - out - interface virbr0 - - jump ACCEPT "
*
* And we ' re munging it in - place to strip the path component
* of the command line , to produce
*
* " iptables --table filter --insert INPUT --in-interface virbr0 --protocol tcp --destination-port 53 --jump ACCEPT
* iptables - - table filter - - insert INPUT - - in - interface virbr0 - - protocol udp - - destination - port 53 - - jump ACCEPT
* iptables - - table filter - - insert FORWARD - - in - interface virbr0 - - jump REJECT
* iptables - - table filter - - insert FORWARD - - out - interface virbr0 - - jump REJECT
* iptables - - table filter - - insert FORWARD - - in - interface virbr0 - - out - interface virbr0 - - jump ACCEPT "
*/
2016-05-26 18:01:55 +03:00
void virTestClearCommandPath ( char * cmdset )
2014-03-20 14:30:44 +04:00
{
size_t offset = 0 ;
char * lineStart = cmdset ;
char * lineEnd = strchr ( lineStart , ' \n ' ) ;
while ( lineStart ) {
char * dirsep ;
char * movestart ;
size_t movelen ;
dirsep = strchr ( lineStart , ' ' ) ;
if ( dirsep ) {
while ( dirsep > lineStart & & * dirsep ! = ' / ' )
dirsep - - ;
if ( * dirsep = = ' / ' )
dirsep + + ;
movestart = dirsep ;
} else {
movestart = lineStart ;
}
movelen = lineEnd ? lineEnd - movestart : strlen ( movestart ) ;
if ( movelen ) {
memmove ( cmdset + offset , movestart , movelen + 1 ) ;
offset + = movelen + 1 ;
}
lineStart = lineEnd ? lineEnd + 1 : NULL ;
lineEnd = lineStart ? strchr ( lineStart , ' \n ' ) : NULL ;
}
cmdset [ offset ] = ' \0 ' ;
}
2013-11-12 15:57:56 +04:00
virCapsPtr virTestGenericCapsInit ( void )
{
virCapsPtr caps ;
virCapsGuestPtr guest ;
if ( ( caps = virCapabilitiesNew ( VIR_ARCH_X86_64 ,
2014-07-14 16:56:13 +04:00
false , false ) ) = = NULL )
2013-11-12 15:57:56 +04:00
return NULL ;
2015-04-18 01:09:16 +03:00
if ( ( guest = virCapabilitiesAddGuest ( caps , VIR_DOMAIN_OSTYPE_HVM , VIR_ARCH_I686 ,
2013-11-12 15:57:56 +04:00
" /usr/bin/acme-virt " , NULL ,
0 , NULL ) ) = = NULL )
goto error ;
2015-04-18 01:38:10 +03:00
if ( ! virCapabilitiesAddGuestDomain ( guest , VIR_DOMAIN_VIRT_TEST , NULL , NULL , 0 , NULL ) )
2013-11-12 15:57:56 +04:00
goto error ;
2015-04-18 01:09:16 +03:00
if ( ( guest = virCapabilitiesAddGuest ( caps , VIR_DOMAIN_OSTYPE_HVM , VIR_ARCH_X86_64 ,
2013-11-12 15:57:56 +04:00
" /usr/bin/acme-virt " , NULL ,
0 , NULL ) ) = = NULL )
goto error ;
2015-04-18 01:38:10 +03:00
if ( ! virCapabilitiesAddGuestDomain ( guest , VIR_DOMAIN_VIRT_TEST , NULL , NULL , 0 , NULL ) )
2013-11-12 15:57:56 +04:00
goto error ;
if ( virTestGetDebug ( ) ) {
char * caps_str ;
caps_str = virCapabilitiesFormatXML ( caps ) ;
if ( ! caps_str )
goto error ;
2015-04-23 20:38:00 +03:00
VIR_TEST_DEBUG ( " Generic driver capabilities: \n %s " , caps_str ) ;
2013-11-12 15:57:56 +04:00
VIR_FREE ( caps_str ) ;
}
return caps ;
2014-03-25 10:53:44 +04:00
error :
2013-11-12 15:57:56 +04:00
virObjectUnref ( caps ) ;
return NULL ;
}
static virDomainDefParserConfig virTestGenericDomainDefParserConfig ;
static virDomainXMLPrivateDataCallbacks virTestGenericPrivateDataCallbacks ;
virDomainXMLOptionPtr virTestGenericDomainXMLConfInit ( void )
{
return virDomainXMLOptionNew ( & virTestGenericDomainDefParserConfig ,
& virTestGenericPrivateDataCallbacks ,
NULL ) ;
}
2015-01-15 13:44:58 +03:00
2016-01-08 23:55:44 +03:00
int
testCompareDomXML2XMLFiles ( virCapsPtr caps , virDomainXMLOptionPtr xmlopt ,
2016-01-27 23:55:01 +03:00
const char * infile , const char * outfile , bool live ,
testCompareDomXML2XMLPreFormatCallback cb ,
2016-04-08 19:04:10 +03:00
const void * opaque , unsigned int parseFlags ,
testCompareDomXML2XMLResult expectResult )
2016-01-08 23:55:44 +03:00
{
char * actual = NULL ;
int ret = - 1 ;
2016-04-08 19:04:10 +03:00
testCompareDomXML2XMLResult result ;
2016-01-08 23:55:44 +03:00
virDomainDefPtr def = NULL ;
unsigned int parse_flags = live ? 0 : VIR_DOMAIN_DEF_PARSE_INACTIVE ;
unsigned int format_flags = VIR_DOMAIN_DEF_FORMAT_SECURE ;
2016-02-25 17:17:14 +03:00
parse_flags | = parseFlags ;
2016-01-08 23:55:44 +03:00
if ( ! live )
format_flags | = VIR_DOMAIN_DEF_FORMAT_INACTIVE ;
2016-04-08 19:04:10 +03:00
if ( ! ( def = virDomainDefParseFile ( infile , caps , xmlopt , parse_flags ) ) ) {
result = TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_PARSE ;
goto out ;
}
2016-01-08 23:55:44 +03:00
if ( ! virDomainDefCheckABIStability ( def , def ) ) {
VIR_TEST_DEBUG ( " ABI stability check failed on %s " , infile ) ;
2016-04-08 19:04:10 +03:00
result = TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_STABILITY ;
goto out ;
2016-01-08 23:55:44 +03:00
}
2016-04-08 19:04:10 +03:00
if ( cb & & cb ( def , opaque ) < 0 ) {
result = TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_CB ;
goto out ;
}
2016-01-27 23:55:01 +03:00
2016-04-08 19:04:10 +03:00
if ( ! ( actual = virDomainDefFormat ( def , caps , format_flags ) ) ) {
result = TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_FORMAT ;
goto out ;
}
2016-01-08 23:55:44 +03:00
2016-05-26 18:01:53 +03:00
if ( virTestCompareToFile ( actual , outfile ) < 0 ) {
2016-04-08 19:04:10 +03:00
result = TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_COMPARE ;
goto out ;
}
result = TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS ;
out :
if ( result = = expectResult ) {
ret = 0 ;
if ( expectResult ! = TEST_COMPARE_DOM_XML2XML_RESULT_SUCCESS ) {
VIR_TEST_DEBUG ( " Got expected failure code=%d msg=%s " ,
result , virGetLastErrorMessage ( ) ) ;
}
} else {
ret = - 1 ;
VIR_TEST_DEBUG ( " Expected result code=%d but received code=%d " ,
expectResult , result ) ;
}
2016-01-08 23:55:44 +03:00
VIR_FREE ( actual ) ;
virDomainDefFree ( def ) ;
return ret ;
}
2015-01-15 13:44:58 +03:00
static int virtTestCounter ;
static char virtTestCounterStr [ 128 ] ;
static char * virtTestCounterPrefixEndOffset ;
/**
2016-05-26 18:01:57 +03:00
* virTestCounterReset :
2015-01-15 13:44:58 +03:00
* @ prefix : name of the test group
*
* Resets the counter and sets up the test group name to use with
2016-05-26 18:02:06 +03:00
* virTestCounterNext ( ) . This function is not thread safe .
2015-01-15 13:44:58 +03:00
*
* Note : The buffer for the assembled message is 128 bytes long . Longer test
* case names ( including the number index ) will be silently truncated .
*/
void
2016-05-26 18:01:57 +03:00
virTestCounterReset ( const char * prefix )
2015-01-15 13:44:58 +03:00
{
virtTestCounter = 0 ;
ignore_value ( virStrcpyStatic ( virtTestCounterStr , prefix ) ) ;
virtTestCounterPrefixEndOffset = strchrnul ( virtTestCounterStr , ' \0 ' ) ;
}
/**
2016-05-26 18:02:06 +03:00
* virTestCounterNext :
2015-01-15 13:44:58 +03:00
*
* This function is designed to ease test creation and reordering by adding
* a way to do automagic test case numbering .
*
* Returns string consisting of test name prefix configured via
2016-05-26 18:01:57 +03:00
* virTestCounterReset ( ) and a number that increments in every call of this
2015-01-15 13:44:58 +03:00
* function . This function is not thread safe .
*
* Note : The buffer for the assembled message is 128 bytes long . Longer test
* case names ( including the number index ) will be silently truncated .
*/
const char
2016-05-26 18:02:06 +03:00
* virTestCounterNext ( void )
2015-01-15 13:44:58 +03:00
{
size_t len = ARRAY_CARDINALITY ( virtTestCounterStr ) ;
/* calculate length of the rest of the string */
len - = ( virtTestCounterPrefixEndOffset - virtTestCounterStr ) ;
snprintf ( virtTestCounterPrefixEndOffset , len , " %d " , + + virtTestCounter ) ;
return virtTestCounterStr ;
}