shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-26 03:21:44 +03:00
Code Releases Activity

qemu: Use correct domain xml flag

Browse Source 
Although VIR_DOMAIN_DEF_FORMAT_INACTIVE and VIR_DOMAIN_XML_INACTIVE
happen to have the same value (1<<1), they come from different enums;
and it is nicer to reason about a 'flags' variable if all uses of
that variable are compared against the same enum type.  Messed up in
commit 06f75ff2 (3.8.0).

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
Eric Blake 2019-02-14 12:53:36 -06:00
parent 27c8fd7490
commit 022eeddf29
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_driver.c
View File

@ -7357,7 +7357,7 @@ static char
* ignore the VIR_DOMAIN_XML_UPDATE_CPU flag. * ignore the VIR_DOMAIN_XML_UPDATE_CPU flag.
*/ */
if (virDomainObjIsActive(vm) && if (virDomainObjIsActive(vm) &&
!(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE)) !(flags & VIR_DOMAIN_XML_INACTIVE))
flags &= ~VIR_DOMAIN_XML_UPDATE_CPU; flags &= ~VIR_DOMAIN_XML_UPDATE_CPU;
ret = qemuDomainFormatXML(driver, vm, flags); ret = qemuDomainFormatXML(driver, vm, flags);