mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 21:34:54 +03:00
conf: report no NUMA nodes when attaching memory device
Error message reports that the guest has '0' NUMA nodes configured when trying to attach a memory device to a guest with no NUMA nodes. This may be a little misleading because '0' can also be node's id. A more friendly way is to directly report that the guest has no NUMA nodes. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2142519 Signed-off-by: Kristina Hanicova <khanicov@redhat.com> Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
parent
7159fb8524
commit
02b113b282
@ -2257,6 +2257,12 @@ virDomainMemoryDefValidate(const virDomainMemoryDef *mem,
|
||||
if (mem->targetNode != -1) {
|
||||
const size_t nodeCount = virDomainNumaGetNodeCount(def->numa);
|
||||
|
||||
if (nodeCount == 0) {
|
||||
virReportError(VIR_ERR_XML_DETAIL, "%s",
|
||||
_("can't add memory backend as guest has no NUMA nodes configured"));
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (mem->targetNode >= nodeCount) {
|
||||
virReportError(VIR_ERR_XML_DETAIL,
|
||||
_("can't add memory backend for guest node '%d' as the guest has only '%zu' NUMA nodes configured"),
|
||||
|
Loading…
Reference in New Issue
Block a user