mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 17:34:18 +03:00
virNetDevOpenvswitchGetVhostuserIfname: Actually use @path to lookup interface
In v6.10.0-rc1~221 I wanted to make virNetDevOpenvswitchGetVhostuserIfname()
lookup interface name even for vhostuser interfaces with mode='server'. For
these, we are given a socket path which is then created by QEMU and to which
OpenVSwitch connects to and creates an interface. Because of this, we don't
know the name of the interface upfront (when starting QEMU) and have to use
the path to query OpenVSwitch later (using ovs-vsctl). What I intended to use
was:
ovs-vsctl --no-headings --columns=name find Interface options:vhost-server-path=$path
But what my code does is:
ovs-vsctl --no-headings --columns=name find Interface options:vhost-server-path=path
and it's all because the argument to the function is named "path"
which I then enclosed in double quotes while it should have been
used as a variable.
Fixes: e4c29e2904
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1767013
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
This commit is contained in:
parent
4252318bb3
commit
0dd029b7f2
@ -494,7 +494,7 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path,
|
||||
if (server) {
|
||||
virCommandAddArgList(cmd, "--no-headings", "--columns=name", "find",
|
||||
"Interface", NULL);
|
||||
virCommandAddArgPair(cmd, "options:vhost-server-path", "path");
|
||||
virCommandAddArgPair(cmd, "options:vhost-server-path", path);
|
||||
} else {
|
||||
const char *tmpIfname = NULL;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user