shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-24 06:03:52 +03:00
Code Releases Activity

vshReadlineParse: Use g_auto*()

Browse Source 
Instead of freeing @partial and @buf explicitly, we can use
g_auto*() to do that automatically.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik 2021-01-26 10:23:32 +01:00
parent e19ecee54c
commit 100052135f
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tools/vsh.c
View File

@ -739,6 +739,8 @@ vshCommandFree(vshCmd *cmd)
}
}
G_DEFINE_AUTOPTR_CLEANUP_FUNC(vshCmd, vshCommandFree);
/**
* vshCommandOpt:
* @cmd: parsed command line to search
@ -2704,10 +2706,10 @@ vshReadlineParse(const char *text, int state)
* initialize those static variables above. On subsequent
* calls @state is non zero. */
if (!state) {
vshCmd *partial = NULL;
g_autoptr(vshCmd) partial = NULL;
const vshCmdDef *cmd = NULL;
const vshCmdOptDef *opt = NULL;
char *buf = g_strdup(rl_line_buffer);
g_autofree char *buf = g_strdup(rl_line_buffer);
g_strfreev(list);
list = NULL;
@ -2717,8 +2719,6 @@ vshReadlineParse(const char *text, int state)
vshCommandStringParse(NULL, buf, &partial);
VIR_FREE(buf);
if (partial) {
cmd = partial->def;
partial->skipChecks = true;
@ -2759,12 +2759,10 @@ vshReadlineParse(const char *text, int state)
(vshCompleterFilter(&completer_list, text) < 0 ||
virStringListMerge(&list, &completer_list) < 0)) {
g_strfreev(completer_list);
vshCommandFree(partial);
goto cleanup;
}
}
}
vshCommandFree(partial);
}
if (list) {