shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-29 15:21:50 +03:00
Code Releases Activity

getstats: prepare for dynamic block.count stat

Browse Source 
A coming patch will make it optionally possible to list backing
chain block stats; in this mode of operation, block.counts is no
longer the number of <disks> in the domain, but the number of
blocks in the array being reported.  We still want block.count
listed first, but rather than iterate the tree twice (once to
count, and once to list stats), it's easier to just touch things
up after the fact.

* src/qemu/qemu_driver.c (qemuDomainGetStatsBlock): Compute count
after the fact.

Signed-off-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Eric Blake 2014-12-05 16:19:00 -07:00
parent 596a137134
commit 14ef1f62e3
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/qemu/qemu_driver.c
View File

@ -18566,6 +18566,7 @@ qemuDomainGetStatsBlock(virQEMUDriverPtr driver,
qemuDomainObjPrivatePtr priv = dom->privateData;
bool abbreviated = false;
virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
int count_index = -1;
if (!HAVE_JOB(privflags) || !virDomainObjIsActive(dom)) {
abbreviated = true; /* it's ok, just go ahead silently */
@ -18582,7 +18583,11 @@ qemuDomainGetStatsBlock(virQEMUDriverPtr driver,
}
}
QEMU_ADD_COUNT_PARAM(record, maxparams, "block", dom->def->ndisks);
/* When listing backing chains, it's easier to fix up the count
* after the iteration than it is to iterate twice; but we still
* want count listed first. */
count_index = record->nparams;
QEMU_ADD_COUNT_PARAM(record, maxparams, "block", 0);
for (i = 0; i < dom->def->ndisks; i++) {
qemuBlockStats *entry;
@ -18640,6 +18645,7 @@ qemuDomainGetStatsBlock(virQEMUDriverPtr driver,
}
record->params[count_index].value.ui = i;
ret = 0;
cleanup: