mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 17:34:18 +03:00
qemu: backup: Write TLS cert and secret object aliases into status XML
We've put the aliases into the backup job definition after the status
XML was already written so they didn't appear in the on-disk state.
Move the code putting them into the private definition earlier, so that
the status XML update done by saving blockjobs already writes them out.
Also add a note notifying that the block job status update writes the
status XML.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1870488
Fixes: 423576679a
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
parent
5058062b5d
commit
1a5f35dbd2
@ -825,6 +825,9 @@ qemuBackupBegin(virDomainObjPtr vm,
|
||||
goto endjob;
|
||||
|
||||
job_started = true;
|
||||
priv->backup->tlsAlias = g_steal_pointer(&tlsAlias);
|
||||
priv->backup->tlsSecretAlias = g_steal_pointer(&tlsSecretAlias);
|
||||
/* qemuBackupDiskStarted saves the status XML */
|
||||
qemuBackupDiskStarted(vm, dd, ndd);
|
||||
|
||||
if (chk) {
|
||||
@ -848,9 +851,6 @@ qemuBackupBegin(virDomainObjPtr vm,
|
||||
}
|
||||
}
|
||||
|
||||
priv->backup->tlsAlias = g_steal_pointer(&tlsAlias);
|
||||
priv->backup->tlsSecretAlias = g_steal_pointer(&tlsSecretAlias);
|
||||
|
||||
ret = 0;
|
||||
|
||||
endjob:
|
||||
|
Loading…
Reference in New Issue
Block a user