shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-04 21:47:16 +03:00
Code Releases Activity

qemuBuildMachineCommandLine: use a switch for virDomainVirtType

Browse Source 
Enumerate all the cases and use virReportEnumRangeError.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
Ján Tomko 2018-05-03 10:05:51 +02:00
parent a34f18cde0
commit 1c533759e1
1 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/qemu/qemu_command.c
View File

@ -7005,15 +7005,38 @@ qemuBuildMachineCommandLine(virCommandPtr cmd,
virCommandAddArg(cmd, "-machine"); virCommandAddArg(cmd, "-machine");
virBufferAdd(&buf, def->os.machine, -1); virBufferAdd(&buf, def->os.machine, -1);
if (def->virtType == VIR_DOMAIN_VIRT_QEMU) { switch (def->virtType) {
case VIR_DOMAIN_VIRT_QEMU:
virBufferAddLit(&buf, ",accel=tcg"); virBufferAddLit(&buf, ",accel=tcg");
} else if (def->virtType == VIR_DOMAIN_VIRT_KVM) { break;
case VIR_DOMAIN_VIRT_KVM:
virBufferAddLit(&buf, ",accel=kvm"); virBufferAddLit(&buf, ",accel=kvm");
} else { break;
case VIR_DOMAIN_VIRT_KQEMU:
case VIR_DOMAIN_VIRT_XEN:
case VIR_DOMAIN_VIRT_LXC:
case VIR_DOMAIN_VIRT_UML:
case VIR_DOMAIN_VIRT_OPENVZ:
case VIR_DOMAIN_VIRT_TEST:
case VIR_DOMAIN_VIRT_VMWARE:
case VIR_DOMAIN_VIRT_HYPERV:
case VIR_DOMAIN_VIRT_VBOX:
case VIR_DOMAIN_VIRT_PHYP:
case VIR_DOMAIN_VIRT_PARALLELS:
case VIR_DOMAIN_VIRT_BHYVE:
case VIR_DOMAIN_VIRT_VZ:
case VIR_DOMAIN_VIRT_NONE:
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("the QEMU binary does not support %s"), _("the QEMU binary does not support %s"),
virDomainVirtTypeToString(def->virtType)); virDomainVirtTypeToString(def->virtType));
return -1; return -1;
case VIR_DOMAIN_VIRT_LAST:
default:
virReportEnumRangeError(virDomainVirtType, def->virtType);
return -1;
} }
/* To avoid the collision of creating USB controllers when calling /* To avoid the collision of creating USB controllers when calling