shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 21:34:54 +03:00
Code Releases Activity

tests: stop static linking to libvirt code in tests

Browse Source 
If we static link to libvirt_util.la then we can't override functions in
this file by simply implementing them in the test code. Any tests should
dynamic link to the main libvirt.la and ensure symbols are exported.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2019-11-27 17:11:20 +00:00
parent 4560013b6e
commit 1fbd80c42a
2 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/libvirt_private.syms
View File

@ -915,6 +915,8 @@ virDomainSnapshotDefFormat;
virDomainSnapshotDefIsExternal; virDomainSnapshotDefIsExternal;
virDomainSnapshotDefNew; virDomainSnapshotDefNew;
virDomainSnapshotDefParseString; virDomainSnapshotDefParseString;
virDomainSnapshotDiskDefFree;
virDomainSnapshotDiskDefParseXML;
virDomainSnapshotFormatConvertXMLFlags; virDomainSnapshotFormatConvertXMLFlags;
virDomainSnapshotIsExternal; virDomainSnapshotIsExternal;
virDomainSnapshotLocationTypeFromString; virDomainSnapshotLocationTypeFromString;

11
tests/Makefile.am
View File

@ -655,8 +655,7 @@ qemublocktest_SOURCES = \
$(NULL) $(NULL)
qemublocktest_LDADD = \ qemublocktest_LDADD = \
libqemumonitortestutils.la \ libqemumonitortestutils.la \
../src/libvirt_conf.la \ ../src/libvirt.la \
../src/libvirt_util.la \
$(qemu_LDADDS) \ $(qemu_LDADDS) \
$(NULL) $(NULL)
@ -930,8 +929,7 @@ storagevolxml2argvtest_SOURCES = \
storagevolxml2argvtest_LDADD = \ storagevolxml2argvtest_LDADD = \
$(LIBXML_LIBS) \ $(LIBXML_LIBS) \
../src/libvirt_driver_storage_impl.la \ ../src/libvirt_driver_storage_impl.la \
../src/libvirt_conf.la \ ../src/libvirt.la \
../src/libvirt_util.la \
$(LDADDS) $(LDADDS)
storagepoolxml2argvtest_SOURCES = \ storagepoolxml2argvtest_SOURCES = \
@ -940,8 +938,7 @@ storagepoolxml2argvtest_SOURCES = \
storagepoolxml2argvtest_LDADD = \ storagepoolxml2argvtest_LDADD = \
$(LIBXML_LIBS) \ $(LIBXML_LIBS) \
../src/libvirt_driver_storage_impl.la \ ../src/libvirt_driver_storage_impl.la \
../src/libvirt_conf.la \ ../src/libvirt.la \
../src/libvirt_util.la \
$(LDADDS) $(LDADDS)
storagepoolxml2xmltest_SOURCES = \ storagepoolxml2xmltest_SOURCES = \
@ -1141,8 +1138,6 @@ virstoragetest_SOURCES = \
virstoragetest.c testutils.h testutils.c virstoragetest.c testutils.h testutils.c
virstoragetest_LDADD = $(LDADDS) \ virstoragetest_LDADD = $(LDADDS) \
../src/libvirt.la \ ../src/libvirt.la \
../src/libvirt_conf.la \
../src/libvirt_util.la \
../src/libvirt_driver_storage_impl.la \ ../src/libvirt_driver_storage_impl.la \
../gnulib/lib/libgnu.la \ ../gnulib/lib/libgnu.la \
$(NULL) $(NULL)