shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 09:17:52 +03:00
Code Releases Activity

parallels: split parallelsStorageOpen function

Browse Source 
Move code for loading inforation about pools to a separate
function - parallelsLoadPools.

Signed-off-by: Dmitry Guryanov <dguryanov@parallels.com>
This commit is contained in:
Dmitry Guryanov 2012-12-04 17:43:03 +04:00 committed by Daniel Veillard
parent 45e6317158
commit 21e1bdeb3d
1 changed files with 40 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
src/parallels/parallels_storage.c
View File

@ -114,33 +114,14 @@ cleanup:
}
static virDrvOpenStatus
parallelsStorageOpen(virConnectPtr conn,
virConnectAuthPtr auth ATTRIBUTE_UNUSED,
unsigned int flags)
static int parallelsLoadPools(virConnectPtr conn)
{
char *base = NULL;
virStorageDriverStatePtr storageState;
bool privileged = (geteuid() == 0);
parallelsConnPtr privconn = conn->privateData;
virStorageDriverStatePtr storageState = conn->storagePrivateData;
bool privileged = (geteuid() == 0);
char *base = NULL;
size_t i;
virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR);
if (STRNEQ(conn->driver->name, "Parallels"))
return VIR_DRV_OPEN_DECLINED;
if (VIR_ALLOC(storageState) < 0) {
virReportOOMError();
return VIR_DRV_OPEN_ERROR;
}
if (virMutexInit(&storageState->lock) < 0) {
VIR_FREE(storageState);
return VIR_DRV_OPEN_ERROR;
}
parallelsStorageLock(storageState);
if (privileged) {
if ((base = strdup(SYSCONFDIR "/libvirt")) == NULL)
goto out_of_memory;
@ -194,16 +175,47 @@ parallelsStorageOpen(virConnectPtr conn,
virStoragePoolObjUnlock(privconn->pools.objs[i]);
}
parallelsStorageUnlock(storageState);
conn->storagePrivateData = storageState;
return VIR_DRV_OPEN_SUCCESS;
return 0;
out_of_memory:
virReportOOMError();
error:
VIR_FREE(base);
return -1;
}
static virDrvOpenStatus
parallelsStorageOpen(virConnectPtr conn,
virConnectAuthPtr auth ATTRIBUTE_UNUSED,
unsigned int flags)
{
virStorageDriverStatePtr storageState;
virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR);
if (STRNEQ(conn->driver->name, "Parallels"))
return VIR_DRV_OPEN_DECLINED;
if (VIR_ALLOC(storageState) < 0) {
virReportOOMError();
return VIR_DRV_OPEN_ERROR;
}
if (virMutexInit(&storageState->lock) < 0) {
VIR_FREE(storageState);
return VIR_DRV_OPEN_ERROR;
}
conn->storagePrivateData = storageState;
parallelsStorageLock(storageState);
if (parallelsLoadPools(conn))
goto error;
parallelsStorageUnlock(storageState);
return VIR_DRV_OPEN_SUCCESS;
error:
parallelsStorageUnlock(storageState);
parallelsStorageClose(conn);
return -1;