shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-10-22 19:34:08 +03:00
Code Releases Activity

storagepoolxml2argvtest: Avoid double free

Browse Source 
A double free may occur in testCompareXMLToArgvFiles() when @def
is freed right after virStoragePoolObjNew() failed and the second
time at cleanup label.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Michal Privoznik
2019-05-14 10:42:42 +02:00
parent cb0c3a7066
commit 230243594e
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tests/storagepoolxml2argvtest.c
View File

@@ -39,7 +39,6 @@ testCompareXMLToArgvFiles(bool shouldFail,
case VIR_STORAGE_POOL_NETFS: case VIR_STORAGE_POOL_NETFS:
if (!(pool = virStoragePoolObjNew())) { if (!(pool = virStoragePoolObjNew())) {
VIR_TEST_DEBUG("pool type '%s' alloc pool obj fails\n", defTypeStr); VIR_TEST_DEBUG("pool type '%s' alloc pool obj fails\n", defTypeStr);
virStoragePoolDefFree(def);
goto cleanup; goto cleanup;
} }
virStoragePoolObjSetDef(pool, def); virStoragePoolObjSetDef(pool, def);