shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 06:50:22 +03:00
Code Releases Activity

conf: change virDomainDefAddImplicitControllers() to return void

Browse Source 
It can't fail.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Laine Stump 2025-02-11 22:59:46 -05:00
parent fd6cfeeeea
commit 25270737d3
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/conf/domain_conf.c
View File

@ -22346,7 +22346,7 @@ virDomainDefMaybeAddSmartcardController(virDomainDef *def)
* in the XML. This is for compat with existing apps which will
* not know/care about <controller> info in the XML
*/
static int
static void
virDomainDefAddImplicitControllers(virDomainDef *def)
{
virDomainDefAddDiskControllersForType(def, VIR_DOMAIN_CONTROLLER_TYPE_SCSI,
@ -22361,8 +22361,6 @@ virDomainDefAddImplicitControllers(virDomainDef *def)
virDomainDefMaybeAddVirtioSerialController(def);
virDomainDefMaybeAddSmartcardController(def);
virDomainDefMaybeAddHostdevSCSIcontroller(def);
return 0;
}
static int
@ -22389,8 +22387,7 @@ virDomainDefAddImplicitDevices(virDomainDef *def, virDomainXMLOption *xmlopt)
if (virDomainDefAddConsoleCompat(def) < 0)
return -1;
}
if (virDomainDefAddImplicitControllers(def) < 0)
return -1;
virDomainDefAddImplicitControllers(def);
if (virDomainDefAddImplicitVideo(def, xmlopt) < 0)
return -1;