From 2c48e84b7566eab1676400d73a7934f93a7ec831 Mon Sep 17 00:00:00 2001 From: Laine Stump Date: Wed, 13 Feb 2019 10:57:57 -0500 Subject: [PATCH] util: fix memory leak in virFirewallDInterfaceSetZone() commit 3bba4825 added the new function virFirewallDInterfaceSetZone() which calledsends virDBUSCallMethod a DBusMessage** for the reply message, but doesn't use the reply, and also doesn't free it. Since this arg is allowed to be NULL, this patch simply sets it to NULL so we don't have to deal with it. Signed-off-by: Laine Stump Reviewed-by: Andrea Bolognani --- src/util/virfirewalld.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c index 47bacdcf4a..f8965eea09 100644 --- a/src/util/virfirewalld.c +++ b/src/util/virfirewalld.c @@ -351,13 +351,12 @@ virFirewallDInterfaceSetZone(const char *iface, const char *zone) { DBusConnection *sysbus = virDBusGetSystemBus(); - DBusMessage *reply = NULL; if (!sysbus) return -1; return virDBusCallMethod(sysbus, - &reply, + NULL, NULL, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1",