shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 06:50:22 +03:00
Code Releases Activity

conf: change virDomainShmemDefInsert() to return void

Browse Source 
It can't fail.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Laine Stump 2025-02-11 16:55:33 -05:00
parent 1456fe2c54
commit 2f8fde6680
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/conf/domain_conf.c
View File

@ -15981,13 +15981,11 @@ virDomainRedirdevDefRemove(virDomainDef *def, size_t idx)
}
int
void
virDomainShmemDefInsert(virDomainDef *def,
virDomainShmemDef *shmem)
{
VIR_APPEND_ELEMENT(def->shmems, def->nshmems, shmem);
return 0;
}

4
src/conf/domain_conf.h
View File

@ -4210,8 +4210,8 @@ virDomainMemoryFindByDeviceAlias(virDomainDef *def,
const char *alias)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) G_GNUC_WARN_UNUSED_RESULT;
int virDomainShmemDefInsert(virDomainDef *def, virDomainShmemDef *shmem)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) G_GNUC_WARN_UNUSED_RESULT;
void virDomainShmemDefInsert(virDomainDef *def, virDomainShmemDef *shmem)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
bool virDomainShmemDefEquals(virDomainShmemDef *src, virDomainShmemDef *dst)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) G_GNUC_WARN_UNUSED_RESULT;
ssize_t virDomainShmemDefFind(virDomainDef *def, virDomainShmemDef *shmem)

3
src/qemu/qemu_driver.c
View File

@ -6806,8 +6806,7 @@ qemuDomainAttachDeviceConfig(virDomainDef *vmdef,
_("device is already in the domain configuration"));
return -1;
}
if (virDomainShmemDefInsert(vmdef, shmem) < 0)
return -1;
virDomainShmemDefInsert(vmdef, shmem);
dev->data.shmem = NULL;
break;