From 35e1547870c7a0c9bfb2bb6ff6ead359da69c951 Mon Sep 17 00:00:00 2001 From: Mao Zhongyi Date: Thu, 17 Oct 2019 11:19:33 +0800 Subject: [PATCH] qemu/qemu_migration_params: use virStringParseYesNo helper A function virStringParseYesNo was added to convert string 'yes' to true and 'no' to false, so use this helper to replace 'STREQ(.*, \"yes\")' and 'STREQ(.*, \"no\")' as it allows us to drop several repetitive if-then-else string->bool conversion blocks. Reviewed-by: Cole Robinson Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Shengju --- src/qemu/qemu_migration_params.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index dca12033c0..c28814bc5b 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -1319,12 +1319,7 @@ qemuMigrationParamsParse(xmlXPathContextPtr ctxt, break; case QEMU_MIGRATION_PARAM_TYPE_BOOL: - if (STREQ(value, "yes")) - pv->value.b = true; - else if (STREQ(value, "no")) - pv->value.b = false; - else - rc = -1; + rc = virStringParseYesNo(value, &pv->value.b); break; case QEMU_MIGRATION_PARAM_TYPE_STRING: