mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-09 01:18:00 +03:00
meson: Drop support for -Wl,-M
This was originally introduced inc2fb8bfee3
, reportedly to support symbol versioning on Solaris; more recently,30b301c6ea
ported it to meson. Up until the previous commit this has resulted in passing -M .../libvirt/build/src/libvirt.syms to the linker on macOS, but the implementation of the -M option on that platform's linker is literally else if ( strcmp(arg, "-M") == 0 ) { // FIX FIX } so in practice we've been providing an additional input file, which the linker understandably ignores after printing a warning since it's not in any format that it recognizes. Considering that LLVM's linker, which is now used by default on FreeBSD, supports the same --version-script option as the GNU linker, that we have introduced special handling for macOS, and that we don't target Solaris, we can simply drop the branch at this point. Signed-off-by: Andrea Bolognani <abologna@redhat.com> Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
parent
b05dfcdfcb
commit
3866a40a95
@ -517,8 +517,6 @@ else
|
||||
test_file = '@0@/src/libvirt_qemu.syms'.format(meson.source_root())
|
||||
if cc.has_link_argument('-Wl,--version-script=@0@'.format(test_file))
|
||||
version_script_flags = '-Wl,--version-script='
|
||||
elif cc.has_link_argument('-Wl,-M,')
|
||||
version_script_flags = '-Wl,-M,'
|
||||
else
|
||||
error('No supported version script link argument found.')
|
||||
endif
|
||||
|
Loading…
Reference in New Issue
Block a user