1
0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 17:34:18 +03:00

Add virshAllocpagesPagesizeCompleter

Returns list of host page sizes from capabilities XML.

Signed-off-by: Roland Schulz <schullzroll@gmail.com>
This commit is contained in:
Roland Schulz 2018-05-21 13:53:44 +02:00 committed by Martin Kletzander
parent 47a1ca6e2c
commit 3b90c3c463
3 changed files with 76 additions and 0 deletions

View File

@ -27,6 +27,7 @@
#include "virsh-pool.h"
#include "virsh-util.h"
#include "internal.h"
#include "virutil.h"
#include "viralloc.h"
#include "virstring.h"
#include "virxml.h"
@ -570,3 +571,73 @@ virshSnapshotNameCompleter(vshControl *ctl,
virshDomainFree(dom);
return NULL;
}
char **
virshAllocpagesPagesizeCompleter(vshControl *ctl,
const vshCmd *cmd ATTRIBUTE_UNUSED,
unsigned int flags)
{
unsigned long long byteval = 0;
xmlXPathContextPtr ctxt = NULL;
virshControlPtr priv = ctl->privData;
unsigned int npages = 0;
xmlNodePtr *pages = NULL;
double size = 0;
size_t i = 0;
const char *suffix = NULL;
char *pagesize = NULL;
char *cap_xml = NULL;
char **ret = NULL;
char *unit = NULL;
virCheckFlags(0, NULL);
if (!priv->conn || virConnectIsAlive(priv->conn) <= 0)
goto error;
if (!(cap_xml = virConnectGetCapabilities(priv->conn)))
goto error;
if (!(virXMLParseStringCtxt(cap_xml, _("capabilities"), &ctxt)))
goto error;
npages = virXPathNodeSet("/capabilities/host/cpu/pages", ctxt, &pages);
if (npages <= 0)
goto error;
if (VIR_ALLOC_N(ret, npages + 1) < 0)
goto error;
for (i = 0; i < npages; i++) {
VIR_FREE(pagesize);
VIR_FREE(unit);
pagesize = virXMLPropString(pages[i], "size");
unit = virXMLPropString(pages[i], "unit");
if (virStrToLong_ull(pagesize, NULL, 10, &byteval) < 0)
goto error;
if (virScaleInteger(&byteval, unit, 1024, UINT_MAX) < 0)
goto error;
size = vshPrettyCapacity(byteval, &suffix);
if (virAsprintf(&ret[i], "%.0f%s", size, suffix) < 0)
goto error;
}
cleanup:
xmlXPathFreeContext(ctxt);
for (i = 0; i < npages; i++)
VIR_FREE(pages[i]);
VIR_FREE(pages);
VIR_FREE(cap_xml);
VIR_FREE(pagesize);
VIR_FREE(unit);
return ret;
error:
if (ret) {
for (i = 0; i < npages; i++)
VIR_FREE(ret[i]);
}
VIR_FREE(ret);
goto cleanup;
}

View File

@ -74,4 +74,8 @@ char ** virshSnapshotNameCompleter(vshControl *ctl,
const vshCmd *cmd,
unsigned int flags);
char ** virshAllocpagesPagesizeCompleter(vshControl *ctl,
const vshCmd *cmd,
unsigned int flags);
#endif

View File

@ -472,6 +472,7 @@ static const vshCmdOptDef opts_allocpages[] = {
{.name = "pagesize",
.type = VSH_OT_INT,
.flags = VSH_OFLAG_REQ,
.completer = virshAllocpagesPagesizeCompleter,
.help = N_("page size (in kibibytes)")
},
{.name = "pagecount",