shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-03 17:47:15 +03:00
Code Releases Activity

qemu: Make qemuMigrationParamsFree follow common pattern

Browse Source 
Our *Free functions usually do not take a double pointer and the caller
has to make sure it doesn't use the stale pointer after the *Free
function returns.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Jiri Denemark 2018-02-21 15:56:18 +01:00
parent 1b100b74a9
commit 3bc416018b
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_driver.c
View File

@ -12759,7 +12759,7 @@ qemuDomainMigratePerform3Params(virDomainPtr dom,
flags, dname, bandwidth, true);
cleanup:
VIR_FREE(compression);
qemuMigrationParamsFree(&migParams);
qemuMigrationParamsFree(migParams);
VIR_FREE(migrate_disks);
return ret;
}

10
src/qemu/qemu_migration_params.c
View File

@ -50,13 +50,13 @@ qemuMigrationParamsClear(qemuMonitorMigrationParamsPtr migParams)
void
qemuMigrationParamsFree(qemuMonitorMigrationParamsPtr *migParams)
qemuMigrationParamsFree(qemuMonitorMigrationParamsPtr migParams)
{
if (!*migParams)
if (!migParams)
return;
qemuMigrationParamsClear(*migParams);
VIR_FREE(*migParams);
qemuMigrationParamsClear(migParams);
VIR_FREE(migParams);
}
@ -101,7 +101,7 @@ qemuMigrationParamsFromFlags(virTypedParameterPtr params,
return migParams;
error:
qemuMigrationParamsFree(&migParams);
qemuMigrationParamsFree(migParams);
return NULL;
}

2
src/qemu/qemu_migration_params.h
View File

@ -37,7 +37,7 @@ void
qemuMigrationParamsClear(qemuMonitorMigrationParamsPtr migParams);
void
qemuMigrationParamsFree(qemuMonitorMigrationParamsPtr *migParams);
qemuMigrationParamsFree(qemuMonitorMigrationParamsPtr migParams);
int
qemuMigrationParamsSet(virQEMUDriverPtr driver,