qemu_capabilities: Stop detecting QEMU_CAPS_DUMP_COMPLETED

All supported QEMUs have this capability. Stop detecting it. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
2025-01-11 09:17:52 +03:00 · 2022-11-07 14:45:31 +01:00 · 2022-11-07 14:45:31 +01:00 · 45d0015d86
commit 45d0015d86
parent ac02c09dd8
29 changed files with 0 additions and 41 deletions
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@ -1231,11 +1231,6 @@ struct virQEMUCapsStringFlags virQEMUCapsMigration[] = {
    { "rdma-pin-all", QEMU_CAPS_MIGRATE_RDMA },
 };

-/* Use virQEMUCapsQMPSchemaQueries for querying parameters of events */
-struct virQEMUCapsStringFlags virQEMUCapsEvents[] = {
-    { "DUMP_COMPLETED", QEMU_CAPS_DUMP_COMPLETED },
-};
-
 struct virQEMUCapsStringFlags virQEMUCapsObjectTypes[] = {
    { "hda-duplex", QEMU_CAPS_HDA_DUPLEX },
    { "hda-micro", QEMU_CAPS_HDA_MICRO },
@ -5291,14 +5286,6 @@ virQEMUCapsProbeQMPSchemaCapabilities(virQEMUCaps *qemuCaps,
            virQEMUCapsSet(qemuCaps, entry->flag);
    }

-    /* probe also for basic event support */
-    for (i = 0; i < G_N_ELEMENTS(virQEMUCapsEvents); i++) {
-        entry = virQEMUCapsEvents + i;
-
-        if (virQEMUQAPISchemaPathExists(entry->value, schema))
-            virQEMUCapsSet(qemuCaps, entry->flag);
-    }
-
    return 0;
 }

--- a/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
@ -84,7 +84,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='pl011'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.ppc64.xml
@ -82,7 +82,6 @@
  <flag name='spapr-vty'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml
@ -48,7 +48,6 @@
  <flag name='virtio-blk.num-queues'/>
  <flag name='sclplmconsole'/>
  <flag name='disk-share-rw'/>
-  <flag name='dump-completed'/>
  <flag name='virtio-gpu-ccw'/>
  <flag name='virtio-keyboard-ccw'/>
  <flag name='virtio-mouse-ccw'/>
--- a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
@ -113,7 +113,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
@ -86,7 +86,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='pl011'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
@ -84,7 +84,6 @@
  <flag name='spapr-vty'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.riscv64.xml
@ -83,7 +83,6 @@
  <flag name='vxhs'/>
  <flag name='virtio-blk.num-queues'/>
  <flag name='disk-share-rw'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
@ -113,7 +113,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml
+++ b/tests/qemucapabilitiesdata/caps_5.1.0.sparc.xml
@ -23,7 +23,6 @@
  <flag name='chardev-reconnect'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
  <flag name='pr-manager-helper'/>
--- a/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.1.0.x86_64.xml
@ -112,7 +112,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.2.0.aarch64.xml
@ -85,7 +85,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='pl011'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.2.0.ppc64.xml
@ -82,7 +82,6 @@
  <flag name='spapr-vty'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.2.0.riscv64.xml
@ -81,7 +81,6 @@
  <flag name='chardev-reconnect'/>
  <flag name='virtio-blk.num-queues'/>
  <flag name='disk-share-rw'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_5.2.0.s390x.xml
@ -46,7 +46,6 @@
  <flag name='virtio-blk.num-queues'/>
  <flag name='sclplmconsole'/>
  <flag name='disk-share-rw'/>
-  <flag name='dump-completed'/>
  <flag name='virtio-gpu-ccw'/>
  <flag name='virtio-keyboard-ccw'/>
  <flag name='virtio-mouse-ccw'/>
--- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml
@ -112,7 +112,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_6.0.0.aarch64.xml
@ -86,7 +86,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='pl011'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml
+++ b/tests/qemucapabilitiesdata/caps_6.0.0.s390x.xml
@ -46,7 +46,6 @@
  <flag name='virtio-blk.num-queues'/>
  <flag name='sclplmconsole'/>
  <flag name='disk-share-rw'/>
-  <flag name='dump-completed'/>
  <flag name='virtio-gpu-ccw'/>
  <flag name='virtio-keyboard-ccw'/>
  <flag name='virtio-mouse-ccw'/>
--- a/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_6.0.0.x86_64.xml
@ -111,7 +111,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml
@ -110,7 +110,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_6.2.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_6.2.0.aarch64.xml
@ -93,7 +93,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='pl011'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_6.2.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_6.2.0.ppc64.xml
@ -82,7 +82,6 @@
  <flag name='spapr-vty'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_6.2.0.x86_64.xml
@ -110,7 +110,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_7.0.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_7.0.0.aarch64.xml
@ -93,7 +93,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='pl011'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_7.0.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_7.0.0.ppc64.xml
@ -88,7 +88,6 @@
  <flag name='spapr-vty'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml
@ -110,7 +110,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_7.1.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_7.1.0.ppc64.xml
@ -87,7 +87,6 @@
  <flag name='spapr-vty'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml
@ -110,7 +110,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>
--- a/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml
@ -110,7 +110,6 @@
  <flag name='vmcoreinfo'/>
  <flag name='disk-share-rw'/>
  <flag name='isa-serial'/>
-  <flag name='dump-completed'/>
  <flag name='pcie-pci-bridge'/>
  <flag name='disk-write-cache'/>
  <flag name='nbd-tls'/>