shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-26 03:21:44 +03:00
Code Releases Activity

storage: Don't lie about path used to look up in error message

Browse Source 
In storageVolLookupByPath the provided path is "sanitized" at first.
This removes some extra slashes and stuff. When the lookup of the volume
fails the original path is used which makes it hard to trace errors in
some cases.

Improve the error message to print the sanitized path along with the
user provided path if they are not equal.
This commit is contained in:
Peter Krempa 2014-02-24 16:07:40 +01:00
parent 7fb3902b0f
commit 46446313e8
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/storage/storage_driver.c
View File

@ -1508,9 +1508,16 @@ storageVolLookupByPath(virConnectPtr conn,
virStoragePoolObjUnlock(pool); virStoragePoolObjUnlock(pool);
} }
if (!ret) if (!ret) {
if (STREQ(path, cleanpath)) {
virReportError(VIR_ERR_NO_STORAGE_VOL, virReportError(VIR_ERR_NO_STORAGE_VOL,
_("no storage vol with matching path %s"), path); _("no storage vol with matching path '%s'"), path);
} else {
virReportError(VIR_ERR_NO_STORAGE_VOL,
_("no storage vol with matching path '%s' (%s)"),
path, cleanpath);
}
}
cleanup: cleanup:
VIR_FREE(cleanpath); VIR_FREE(cleanpath);