shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-04 21:47:16 +03:00
Code Releases Activity

Remove some C99 variable decls in parallels driver

Browse Source 
The parallels storage driver declared some loop variables
inside the for(;;). This is not allowed by libvirt coding
standards

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2013-02-26 17:52:40 +00:00
parent 02b9097274
commit 464c92c051
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/parallels/parallels_storage.c
View File

@ -129,9 +129,11 @@ static char *parallelsMakePoolName(virConnectPtr conn, const char *path)
{ {
parallelsConnPtr privconn = conn->privateData; parallelsConnPtr privconn = conn->privateData;
char *name; char *name;
unsigned int i;
for (unsigned int i = 0; i < UINT_MAX; i++) { for (i = 0; i < UINT_MAX; i++) {
bool found = false; bool found = false;
int j;
if (!(name = strdup(path))) { if (!(name = strdup(path))) {
virReportOOMError(); virReportOOMError();
@ -148,11 +150,11 @@ static char *parallelsMakePoolName(virConnectPtr conn, const char *path)
return 0; return 0;
} }
for (int j = 0; j < strlen(name); j++) for (j = 0; j < strlen(name); j++)
if (name[j] == '/') if (name[j] == '/')
name[j] = '-'; name[j] = '-';
for (int j = 0; j < privconn->pools.count; j++) { for (j = 0; j < privconn->pools.count; j++) {
if (STREQ(name, privconn->pools.objs[j]->def->name)) { if (STREQ(name, privconn->pools.objs[j]->def->name)) {
found = true; found = true;
break; break;
@ -226,6 +228,7 @@ parallelsPoolAddByDomain(virConnectPtr conn, virDomainObjPtr dom)
virStoragePoolObjListPtr pools = &privconn->pools; virStoragePoolObjListPtr pools = &privconn->pools;
char *poolPath; char *poolPath;
virStoragePoolObjPtr pool = NULL; virStoragePoolObjPtr pool = NULL;
int j;
if (!(poolPath = strdup(pdom->home))) { if (!(poolPath = strdup(pdom->home))) {
virReportOOMError(); virReportOOMError();
@ -234,7 +237,7 @@ parallelsPoolAddByDomain(virConnectPtr conn, virDomainObjPtr dom)
poolPath = dirname(poolPath); poolPath = dirname(poolPath);
for (int j = 0; j < pools->count; j++) { for (j = 0; j < pools->count; j++) {
if (STREQ(poolPath, pools->objs[j]->def->target.path)) { if (STREQ(poolPath, pools->objs[j]->def->target.path)) {
pool = pools->objs[j]; pool = pools->objs[j];
break; break;