mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-22 17:34:18 +03:00
domaincapsmock: mock virHostCPUGetMicrocodeVersion()
Previous patch handled the runtime case where a non-x86 host is fetching /proc/cpuinfo data for a microcode info that we know it doesn't exist. This change alone speeded everything by a bit for non-x86, but there is at least one major culprit left. qemuxml2argvtest does several arch-specific tests, and a good chunk of them are x86 exclusive. This means that 'hostArch' will be seen as x86 for these tests, even when running in non-x86 hosts. In a Power 9 server with 128 CPUs, qemuxml2argvtest takes 298 seconds to complete in average, and 'perf record' indicates that 95% of the time is spent in virHostCPUGetMicrocodeVersion(). This patch mocks virHostCPUGetMicrocodeVersion() to always return 0 in the tests, avoiding /proc/cpuinfo reads. This will make all tests behave arch-agnostic, and the microcode value being 0 has no impact on any existing test. This is a CI speed across the board for all archs, including x86, given that we're not reading /proc/cpuinfo in the tests. For a Thinkpad T480 laptop with 8 Intel i7 CPUs, qemuxml2argvtest went from 15.50 sec to 12.50 seconds. The performance gain is even more noticeable for huge servers with lots of CPUs. For the Power 9 server mentioned above, this patch speeds qemuxml2argvtest to 9 seconds, down from 298 sec. Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> Reviewed-by: Ján Tomko <jtomko@redhat.com> Signed-off-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
parent
2ba0b7497c
commit
46d88d8dba
@ -75,7 +75,8 @@ virBitmapPtr virHostCPUGetSiblingsList(unsigned int cpu);
|
||||
|
||||
int virHostCPUGetOnline(unsigned int cpu, bool *online);
|
||||
|
||||
unsigned int virHostCPUGetMicrocodeVersion(virArch hostArch);
|
||||
unsigned int
|
||||
virHostCPUGetMicrocodeVersion(virArch hostArch) G_GNUC_NO_INLINE;
|
||||
|
||||
int virHostCPUGetMSR(unsigned long index,
|
||||
uint64_t *msr);
|
||||
|
@ -34,3 +34,9 @@ virHostCPUGetKVMMaxVCPUs(void)
|
||||
{
|
||||
return INT_MAX;
|
||||
}
|
||||
|
||||
unsigned int
|
||||
virHostCPUGetMicrocodeVersion(virArch hostArch G_GNUC_UNUSED)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user