From 4c53267b70fc5c548b6530113c3f96870d8d7fc1 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Fri, 6 Dec 2019 10:27:08 +0100 Subject: [PATCH] qemu_monitor_text: Drop unused variable and avoid crash In v5.8.0-rc1~122 we've removed the only use of @safename in qemuMonitorTextLoadSnapshot(). What we are left with is an declared but not initialized variable that is passed to VIR_FREE(). Caught by libvirt-php test suite. Signed-off-by: Michal Privoznik --- src/qemu/qemu_monitor_text.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index 9054682d60..b387235821 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -161,7 +161,6 @@ int qemuMonitorTextLoadSnapshot(qemuMonitorPtr mon, const char *name) char *cmd = NULL; char *reply = NULL; int ret = -1; - char *safename; cmd = g_strdup_printf("loadvm \"%s\"", name); @@ -194,7 +193,6 @@ int qemuMonitorTextLoadSnapshot(qemuMonitorPtr mon, const char *name) ret = 0; cleanup: - VIR_FREE(safename); VIR_FREE(cmd); VIR_FREE(reply); return ret;