diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 5913026026..dabfe10c02 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -3617,11 +3617,13 @@ qemuMigrationRun(virQEMUDriverPtr driver, if (persist_xml) { persistDef = qemuMigrationPrepareDef(driver, persist_xml, NULL, NULL); - if (!persistDef) - goto cleanup; } else { - persistDef = vm->newDef; + persistDef = qemuDomainDefCopy(driver, vm->newDef, + VIR_DOMAIN_XML_SECURE | + VIR_DOMAIN_XML_MIGRATABLE); } + if (!persistDef) + goto cleanup; } mig = qemuMigrationEatCookie(driver, vm, cookiein, cookieinlen, @@ -3868,14 +3870,13 @@ qemuMigrationRun(virQEMUDriverPtr driver, QEMU_MIGRATION_COOKIE_STATS; if (ret == 0 && - (qemuMigrationCookieAddPersistent(mig, persistDef) < 0 || + (qemuMigrationCookieAddPersistent(mig, &persistDef) < 0 || qemuMigrationBakeCookie(mig, driver, vm, cookieout, cookieoutlen, cookieFlags) < 0)) { VIR_WARN("Unable to encode migration cookie"); } - if (persistDef != vm->newDef) - virDomainDefFree(persistDef); + virDomainDefFree(persistDef); qemuMigrationCookieFree(mig); if (events) @@ -5365,10 +5366,7 @@ qemuMigrationFinish(virQEMUDriverPtr driver, qemuMonitorSetDomainLog(priv->mon, NULL, NULL, NULL); VIR_FREE(priv->origname); virDomainObjEndAPI(&vm); - if (mig) { - virDomainDefFree(qemuMigrationCookieGetPersistent(mig)); - qemuMigrationCookieFree(mig); - } + qemuMigrationCookieFree(mig); if (orig_err) { virSetError(orig_err); virFreeError(orig_err); diff --git a/src/qemu/qemu_migration_cookie.c b/src/qemu/qemu_migration_cookie.c index 0f4bcaddcc..bd12f11246 100644 --- a/src/qemu/qemu_migration_cookie.c +++ b/src/qemu/qemu_migration_cookie.c @@ -99,6 +99,7 @@ qemuMigrationCookieFree(qemuMigrationCookiePtr mig) return; qemuMigrationCookieGraphicsFree(mig->graphics); + virDomainDefFree(mig->persistent); qemuMigrationCookieNetworkFree(mig->network); qemuMigrationCookieNBDFree(mig->nbd); @@ -385,7 +386,7 @@ qemuMigrationCookieAddLockstate(qemuMigrationCookiePtr mig, int qemuMigrationCookieAddPersistent(qemuMigrationCookiePtr mig, - virDomainDefPtr def) + virDomainDefPtr *def) { if (mig->flags & QEMU_MIGRATION_COOKIE_PERSISTENT) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -393,10 +394,11 @@ qemuMigrationCookieAddPersistent(qemuMigrationCookiePtr mig, return -1; } - if (!def) + if (!def || !*def) return 0; - mig->persistent = def; + mig->persistent = *def; + *def = NULL; mig->flags |= QEMU_MIGRATION_COOKIE_PERSISTENT; mig->flagsMandatory |= QEMU_MIGRATION_COOKIE_PERSISTENT; return 0; diff --git a/src/qemu/qemu_migration_cookie.h b/src/qemu/qemu_migration_cookie.h index 0ef9d454a4..b009d5bf5d 100644 --- a/src/qemu/qemu_migration_cookie.h +++ b/src/qemu/qemu_migration_cookie.h @@ -145,7 +145,7 @@ qemuMigrationCookieFree(qemuMigrationCookiePtr mig); int qemuMigrationCookieAddPersistent(qemuMigrationCookiePtr mig, - virDomainDefPtr def); + virDomainDefPtr *def); virDomainDefPtr qemuMigrationCookieGetPersistent(qemuMigrationCookiePtr mig);