From 5feb9f9420f4f336b87089e9e7ea1f9917999f7f Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Tue, 3 Jul 2018 16:51:31 +0200 Subject: [PATCH] esx: Report error in esxVI_LookupVirtualMachineByName When reviewing 00d9edfe2f39f60b40 I've changed proposed patch and made it to not report error if no domain is found. This is wrong and the original patch was okay. Thing is, both callers pass occurrence = OptionalItem so no error message overwriting is done as I thought initially. Signed-off-by: Michal Privoznik --- src/esx/esx_vi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/esx/esx_vi.c b/src/esx/esx_vi.c index 0bdfc5a8be..25fbdc7e44 100644 --- a/src/esx/esx_vi.c +++ b/src/esx/esx_vi.c @@ -3014,8 +3014,11 @@ esxVI_LookupVirtualMachineByName(esxVI_Context *ctx, const char *name, break; } - if (!(*virtualMachine) && occurrence != esxVI_Occurrence_OptionalItem) + if (!(*virtualMachine) && occurrence != esxVI_Occurrence_OptionalItem) { + virReportError(VIR_ERR_NO_DOMAIN, + _("Could not find domain with name '%s'"), name); goto cleanup; + } result = 0;