shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-26 03:21:44 +03:00
Code Releases Activity

storage: Fix error retval for getDeviceType

Browse Source 
On error from virAsprintf we would erroneously return 0 with
the @*type not being set. Change to a return -1 on error like
we should have been doing.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
John Ferlan 2019-02-12 07:00:38 -05:00
parent b330600a69
commit 65fc17d2f6
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/storage/storage_util.c
View File

@ -4044,8 +4044,10 @@ getDeviceType(uint32_t host,
int retval = 0; int retval = 0;
if (virAsprintf(&type_path, "/sys/bus/scsi/devices/%u:%u:%u:%u/type", if (virAsprintf(&type_path, "/sys/bus/scsi/devices/%u:%u:%u:%u/type",
host, bus, target, lun) < 0) host, bus, target, lun) < 0) {
retval = -1;
goto out; goto out;
}
typefile = fopen(type_path, "r"); typefile = fopen(type_path, "r");
if (typefile == NULL) { if (typefile == NULL) {