shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-26 03:21:44 +03:00
Code Releases Activity

qemu_capabilities: Resolve Coverity RESOURCE_LEAK

Browse Source 
In function virQEMUCapsParseMachineTypesStr, VIR_STRNDUP allocates
memory for 'name' in {do,while} loop. If 'name' isn't freed before
'continue', its memory will be allocated again in the next loop.
In this case the memory allocated for 'name' in privious loop is
useless and not freed. Free it before continue this loop to fix that.

Signed-off-by: Wang Rui <moon.wangrui@huawei.com>
This commit is contained in:
Wang Rui 2014-08-28 18:20:58 +08:00 committed by Ján Tomko
parent 64cef432aa
commit 6781d5b5a8
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/qemu/qemu_capabilities.c
View File

@ -433,8 +433,10 @@ virQEMUCapsParseMachineTypesStr(const char *output,
if ((t = strstr(p, "(alias of ")) && (!next || t < next)) { if ((t = strstr(p, "(alias of ")) && (!next || t < next)) {
p = t + strlen("(alias of "); p = t + strlen("(alias of ");
if (!(t = strchr(p, ')')) || (next && t >= next)) if (!(t = strchr(p, ')')) || (next && t >= next)) {
VIR_FREE(name);
continue; continue;
}
if (VIR_STRNDUP(canonical, p, t - p) < 0) { if (VIR_STRNDUP(canonical, p, t - p) < 0) {
VIR_FREE(name); VIR_FREE(name);