diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c655bcf2bc..0569f66013 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -18219,6 +18219,7 @@ virDomainObjListLoadAllConfigs(virDomainObjListPtr doms, { DIR *dir; struct dirent *entry; + int ret = -1; VIR_INFO("Scanning for configs in %s", configDir); @@ -18233,7 +18234,7 @@ virDomainObjListLoadAllConfigs(virDomainObjListPtr doms, virObjectLock(doms); - while ((entry = readdir(dir))) { + while ((ret = virDirRead(dir, &entry, configDir)) > 0) { virDomainObjPtr dom; if (entry->d_name[0] == '.') @@ -18273,7 +18274,7 @@ virDomainObjListLoadAllConfigs(virDomainObjListPtr doms, closedir(dir); virObjectUnlock(doms); - return 0; + return ret; } int diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 41465c2fcb..b6312b5946 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -3153,6 +3153,7 @@ virNetworkLoadAllState(virNetworkObjListPtr nets, { DIR *dir; struct dirent *entry; + int ret = -1; if (!(dir = opendir(stateDir))) { if (errno == ENOENT) @@ -3162,7 +3163,7 @@ virNetworkLoadAllState(virNetworkObjListPtr nets, return -1; } - while ((entry = readdir(dir))) { + while ((ret = virDirRead(dir, &entry, stateDir)) > 0) { virNetworkObjPtr net; if (entry->d_name[0] == '.') @@ -3176,7 +3177,7 @@ virNetworkLoadAllState(virNetworkObjListPtr nets, } closedir(dir); - return 0; + return ret; } @@ -3186,6 +3187,7 @@ int virNetworkLoadAllConfigs(virNetworkObjListPtr nets, { DIR *dir; struct dirent *entry; + int ret = -1; if (!(dir = opendir(configDir))) { if (errno == ENOENT) @@ -3196,7 +3198,7 @@ int virNetworkLoadAllConfigs(virNetworkObjListPtr nets, return -1; } - while ((entry = readdir(dir))) { + while ((ret = virDirRead(dir, &entry, configDir)) > 0) { virNetworkObjPtr net; if (entry->d_name[0] == '.') @@ -3216,8 +3218,7 @@ int virNetworkLoadAllConfigs(virNetworkObjListPtr nets, } closedir(dir); - - return 0; + return ret; } int virNetworkDeleteConfig(const char *configDir, diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index b332f0fa13..90da0b5837 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -3097,6 +3097,7 @@ virNWFilterLoadAllConfigs(virNWFilterObjListPtr nwfilters, { DIR *dir; struct dirent *entry; + int ret = -1; if (!(dir = opendir(configDir))) { if (errno == ENOENT) { @@ -3107,7 +3108,7 @@ virNWFilterLoadAllConfigs(virNWFilterObjListPtr nwfilters, return -1; } - while ((entry = readdir(dir))) { + while ((ret = virDirRead(dir, &entry, configDir)) > 0) { char *path; virNWFilterObjPtr nwfilter; @@ -3128,8 +3129,7 @@ virNWFilterLoadAllConfigs(virNWFilterObjListPtr nwfilters, } closedir(dir); - - return 0; + return ret; } diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index ebd42c2ecf..9769b19149 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -1862,6 +1862,7 @@ virStoragePoolLoadAllConfigs(virStoragePoolObjListPtr pools, { DIR *dir; struct dirent *entry; + int ret; if (!(dir = opendir(configDir))) { if (errno == ENOENT) @@ -1871,7 +1872,7 @@ virStoragePoolLoadAllConfigs(virStoragePoolObjListPtr pools, return -1; } - while ((entry = readdir(dir))) { + while ((ret = virDirRead(dir, &entry, configDir)) > 0) { char *path; char *autostartLink; virStoragePoolObjPtr pool; @@ -1901,8 +1902,7 @@ virStoragePoolLoadAllConfigs(virStoragePoolObjListPtr pools, } closedir(dir); - - return 0; + return ret; } int