shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-10 05:17:59 +03:00
Code Releases Activity

virhashtest: testHashGetItems: Remove test case for sorting by value

Browse Source 
Upcoming patch will rewrite virHashGetItems to remove the sorting
function since the prevalent mode is to order by keys.

Remove the test for it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Matt Coleman <matt@datto.com>
This commit is contained in:
Peter Krempa 2020-10-22 17:41:26 +02:00
parent ef164fb3f9
commit 6e29698037
1 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/virhashtest.c
View File

@ -368,13 +368,6 @@ testHashGetItemsCompKey(const virHashKeyValuePair *a,
return strcmp(a->key, b->key);
}
static int
testHashGetItemsCompValue(const virHashKeyValuePair *a,
const virHashKeyValuePair *b)
{
return strcmp(a->value, b->value);
}
static int
testHashGetItems(const void *data G_GNUC_UNUSED)
{
@ -416,18 +409,6 @@ testHashGetItems(const void *data G_GNUC_UNUSED)
}
VIR_FREE(array);
if (!(array = virHashGetItems(hash, testHashGetItemsCompValue)) ||
STRNEQ(array[0].key, "c") ||
STRNEQ(array[0].value, "1") ||
STRNEQ(array[1].key, "b") ||
STRNEQ(array[1].value, "2") ||
STRNEQ(array[2].key, "a") ||
STRNEQ(array[2].value, "3") ||
array[3].key || array[3].value) {
VIR_TEST_VERBOSE("\nfailed to get items with value sort");
goto cleanup;
}
ret = 0;
cleanup: