shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 17:34:18 +03:00
Code Releases Activity

domain-conf: cleanup controller insert function

Browse Source 
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Pavel Hrdina 2015-11-11 15:18:07 +01:00
parent a9a583d6df
commit 6fdbdafcd7
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/conf/domain_conf.c
View File

@ -13397,6 +13397,7 @@ void virDomainControllerInsertPreAlloced(virDomainDefPtr def,
int idx; int idx;
/* Tenatively plan to insert controller at the end. */ /* Tenatively plan to insert controller at the end. */
int insertAt = -1; int insertAt = -1;
virDomainControllerDefPtr current = NULL;
/* Then work backwards looking for controllers of /* Then work backwards looking for controllers of
* the same type. If we find a controller with a * the same type. If we find a controller with a
@ -13404,17 +13405,19 @@ void virDomainControllerInsertPreAlloced(virDomainDefPtr def,
* that position * that position
*/ */
for (idx = (def->ncontrollers - 1); idx >= 0; idx--) { for (idx = (def->ncontrollers - 1); idx >= 0; idx--) {
/* If bus matches and current controller is after current = def->controllers[idx];
* new controller, then new controller should go here */ if (current->type == controller->type) {
if (def->controllers[idx]->type == controller->type && if (current->idx > controller->idx) {
def->controllers[idx]->idx > controller->idx) { /* If bus matches and current controller is after
insertAt = idx; * new controller, then new controller should go here
} else if (def->controllers[idx]->type == controller->type && * */
insertAt == -1) { insertAt = idx;
/* Last controller with match bus is before the } else if (insertAt == -1) {
* new controller, then put new controller just after /* Last controller with match bus is before the
*/ * new controller, then put new controller just after
insertAt = idx + 1; */
insertAt = idx + 1;
}
} }
} }