From 713342e9531581183dbf85fffcca4fea1ff80d02 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Mon, 2 Apr 2018 07:13:33 -0400 Subject: [PATCH] tests: Return failure if log not fopen'd If @log is not fopen'd then, going to cleanup and calling fclose will make for an unhappy callee. So just fail immediately instead since there's nothing to clean up. Found by Coverity Signed-off-by: John Ferlan --- tests/commandhelper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/commandhelper.c b/tests/commandhelper.c index 1da2834aa4..bf91550ede 100644 --- a/tests/commandhelper.c +++ b/tests/commandhelper.c @@ -67,7 +67,7 @@ int main(int argc, char **argv) { int ret = EXIT_FAILURE; if (!log) - goto cleanup; + return ret; for (i = 1; i < argc; i++) fprintf(log, "ARG:%s\n", argv[i]);