shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 06:50:22 +03:00
Code Releases Activity

src: document that no constants are provided for custom VM stats

Browse Source 
Contrary to most APIs returning typed parameters, there are no constants
defined for the domain stats data keys. This is was because many of the
keys needs to be dynamically constructed using one or more array index
values.

It is possible to define constants while still supporting dynamic
array indexes by simply defining the prefixes and suffixes as constants.
The consuming code can then combine the constants with array index
value.

With this approach, it is practical to add constants for the domain stats
API keys.

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2025-02-28 13:42:48 +00:00
parent 5d9f73628b
commit 728b22be92
2 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
include/libvirt/libvirt-domain.h
View File

@ -3918,6 +3918,18 @@ struct _virDomainStatsRecord {
*/
# define VIR_DOMAIN_STATS_DIRTYRATE_VCPU_SUFFIX_MEGABYTES_PER_SECOND ".megabytes_per_second"
/**
* VIR_DOMAIN_STATS_VM_PREFIX:
*
* Concatenate the prefix, a hypervisor specific custom stats name and one
* of the VIR_DOMAIN_STATS_CUSTOM_TYPE_* constants to form a complete
* parameter name
*
* Since: 11.2.0
*/
# define VIR_DOMAIN_STATS_VM_PREFIX "vm."
/**
* virDomainStatsTypes:
*

12
src/libvirt-domain.c
View File

@ -12335,14 +12335,12 @@ virConnectGetDomainCapabilities(virConnectPtr conn,
*
* "vm.$NAME.$TYPE"
*
* $NAME - name of the statistics field provided by the hypervisor
* Where $NAME is an arbitrary choice of the hypervisor driver, for
* which no API constants are defined.
* The $TYPE values are defined by VIR_DOMAIN_STATS_CUSTOM_TYPE_*
* constants.
*
* $TYPE - Type of the value. The following types are returned:
* 'cur' - current instant value
* 'sum' - aggregate value
* 'max' - peak value
*
* The returned value may be either an unsigned long long or a boolean.
* The returned value may be either an unsigned long long or a boolean.
*
* WARNING:
* The stats reported in this group are runtime-collected and