shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 17:34:18 +03:00
Code Releases Activity

tools: fix variable scope in in check_guests_shutdown

Browse Source 
libvirt-guests.sh when run with more active guests than requested to
shut down in parallel will run until it times out only shutting down
the first set of guests.

This patch fixes parallel shutdown by fixing a variable scope issue
where check_guests_shutdown unintentionally reset $guests which
prevented further progress.

Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1688508

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
This commit is contained in:
Christian Ehrhardt 2018-03-19 12:44:31 +01:00 committed by Michal Privoznik
parent 677aaeb128
commit 7e476356c2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/libvirt-guests.sh.in
View File

@ -333,11 +333,11 @@ guest_count()
check_guests_shutdown() check_guests_shutdown()
{ {
uri=$1 uri=$1
guests=$2 guests_to_check=$2
guests_shutting_down= guests_shutting_down=
for guest in $guests; do for guest in $guests; do
if ! guest_is_on "$uri" "$guest" >/dev/null 2>&1; then if ! guest_is_on "$uri" "$guests_to_check" >/dev/null 2>&1; then
eval_gettext "Failed to determine state of guest: \$guest. Not tracking it anymore." eval_gettext "Failed to determine state of guest: \$guest. Not tracking it anymore."
echo echo
continue continue