shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-24 06:03:52 +03:00
Code Releases Activity

vshCmddefCheckInternals: Sanitize command alias validation

Browse Source 
We don't need to validate the real command twice, but it's better to
check that the real command name exists and it's not an alias to prevent
loops.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2021-09-16 15:44:25 +02:00
parent 1726c572a2
commit 7f72ed0707
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tools/vsh.c
View File

@ -269,11 +269,27 @@ vshCmddefCheckInternals(vshControl *ctl,
/* in order to perform the validation resolve the alias first */
if (cmd->flags & VSH_CMD_FLAG_ALIAS) {
const vshCmdDef *alias;
if (!cmd->alias) {
vshError(ctl, _("command '%s' has inconsistent alias"), cmd->name);
return -1;
}
cmd = vshCmddefSearch(cmd->alias);
if (!(alias = vshCmddefSearch(cmd->alias))) {
vshError(ctl, _("command alias '%s' is pointing to a non-existant command '%s'"),
cmd->name, cmd->alias);
return -1;
}
if (alias->flags & VSH_CMD_FLAG_ALIAS) {
vshError(ctl, _("command alias '%s' is pointing to another command alias '%s'"),
cmd->name, cmd->alias);
return -1;
}
/* we don't need to continue as the real command will be checked separately */
return 0;
}
/* Each command has to provide a non-empty help string. */