shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-10 05:17:59 +03:00
Code Releases Activity

virt-host-validate.c: check for kernel namespaces

Browse Source 
The LXC driver requires the uts, mnt, pid & ipc
namespaces, while net & user namespaces are
optional. Validate all these are present.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2015-10-07 16:58:39 +01:00
parent 44a96fe914
commit 8a6b6037f8
3 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/virt-host-validate-common.c
View File

@ -132,6 +132,26 @@ int virHostValidateDevice(const char *hvname,
} }
int virHostValidateNamespace(const char *hvname,
const char *ns_name,
virHostValidateLevel level,
const char *hint)
{
virHostMsgCheck(hvname, "for namespace %s", ns_name);
char nspath[100];
snprintf(nspath, sizeof(nspath), "/proc/self/ns/%s", ns_name);
if (access(nspath, F_OK) < 0) {
virHostMsgFail(level, hint);
return -1;
}
virHostMsgPass();
return 0;
}
bool virHostValidateHasCPUFlag(const char *name) bool virHostValidateHasCPUFlag(const char *name)
{ {
FILE *fp = fopen("/proc/cpuinfo", "r"); FILE *fp = fopen("/proc/cpuinfo", "r");

5
tools/virt-host-validate-common.h
View File

@ -54,4 +54,9 @@ extern int virHostValidateLinuxKernel(const char *hvname,
virHostValidateLevel level, virHostValidateLevel level,
const char *hint); const char *hint);
extern int virHostValidateNamespace(const char *hvname,
const char *ns_name,
virHostValidateLevel level,
const char *hint);
#endif /* __VIRT_HOST_VALIDATE_COMMON_H__ */ #endif /* __VIRT_HOST_VALIDATE_COMMON_H__ */

30
tools/virt-host-validate-lxc.c
View File

@ -33,5 +33,35 @@ int virHostValidateLXC(void)
_("Upgrade to a kernel supporting namespaces")) < 0) _("Upgrade to a kernel supporting namespaces")) < 0)
ret = -1; ret = -1;
if (virHostValidateNamespace("LXC", "ipc",
VIR_HOST_VALIDATE_FAIL,
_("IPC namespace support is required")) < 0)
ret = -1;
if (virHostValidateNamespace("LXC", "mnt",
VIR_HOST_VALIDATE_FAIL,
_("Mount namespace support is required")) < 0)
ret = -1;
if (virHostValidateNamespace("LXC", "pid",
VIR_HOST_VALIDATE_FAIL,
_("PID namespace support is required")) < 0)
ret = -1;
if (virHostValidateNamespace("LXC", "uts",
VIR_HOST_VALIDATE_FAIL,
_("UTS namespace support is required")) < 0)
ret = -1;
if (virHostValidateNamespace("LXC", "net",
VIR_HOST_VALIDATE_WARN,
_("Network namespace support is recommended")) < 0)
ret = -1;
if (virHostValidateNamespace("LXC", "user",
VIR_HOST_VALIDATE_FAIL,
_("User namespace support is recommended")) < 0)
ret = -1;
return ret; return ret;
} }