shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-10-20 11:33:43 +03:00
Code Releases Activity

lib: Prefer WITH_* prefix for #if conditionals

Browse Source 
Currently, we are mixing: #if HAVE_BLAH with #if WITH_BLAH.
Things got way better with Pavel's work on meson, but apparently,
mixing these two lead to confusing and easy to miss bugs (see
31fb929eca for instance). While we were forced to use HAVE_
prefix with autotools, we are free to chose our own prefix with
meson and since WITH_ prefix appears to be more popular let's use
it everywhere.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik
2020-09-01 13:27:44 +02:00
parent 59d896ced1
commit 95b9db4ee2
71 changed files with 367 additions and 367 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/coding-style.rst
View File

@@ -474,7 +474,7 @@ indentation to track nesting:
::
#if defined(HAVE_POSIX_FALLOCATE) && !defined(HAVE_FALLOCATE)
#if defined(WITH_POSIX_FALLOCATE) && !defined(WITH_FALLOCATE)
# define fallocate(a, ignored, b, c) posix_fallocate(a, b, c)
#endif