shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-03 17:47:15 +03:00
Code Releases Activity

Invert logic for checking for QEMU disk cache options

Browse Source 
QEMU has had two different syntax for disk cache options

 Old: on|off
 New: writeback|writethrough|none

QEMU recently added another 'unsafe' option which broke the
libvirt check. We can avoid this & future breakage, if we
do a negative check for the old syntax, instead of a positive
check for the new syntax

* src/qemu/qemu_conf.c: Invert cache option check
This commit is contained in:
Daniel P. Berrange 2010-07-27 11:21:10 +01:00
parent 4f24ca01e8
commit 9749d94f7b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/qemu/qemu_conf.c
View File

@ -1170,7 +1170,8 @@ static unsigned long long qemudComputeCmdFlags(const char *help,
flags |= QEMUD_CMD_FLAG_DOMID; flags |= QEMUD_CMD_FLAG_DOMID;
if (strstr(help, "-drive")) { if (strstr(help, "-drive")) {
flags |= QEMUD_CMD_FLAG_DRIVE; flags |= QEMUD_CMD_FLAG_DRIVE;
if (strstr(help, "cache=writethrough|writeback|none")) if (strstr(help, "cache=") &&
!strstr(help, "cache=on|off"))
flags |= QEMUD_CMD_FLAG_DRIVE_CACHE_V2; flags |= QEMUD_CMD_FLAG_DRIVE_CACHE_V2;
if (strstr(help, "format=")) if (strstr(help, "format="))
flags |= QEMUD_CMD_FLAG_DRIVE_FORMAT; flags |= QEMUD_CMD_FLAG_DRIVE_FORMAT;