shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 17:34:18 +03:00
Code Releases Activity

util: Improve macOS workaround

Browse Source 
Since the workaround is specific to macOS, only disable compiler
warnings when building on that platform.

While at it, update the comment to reflect the fact that the
workaround is needed for all versions of the OS, including the
modern ones that we currently target.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Andrea Bolognani 2022-03-28 17:24:47 +02:00
parent 3fa815f4f7
commit 9f1bd0fb97
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/util/virutil.c
View File

@ -869,9 +869,11 @@ virDoesGroupExist(const char *name)
/* Work around an incompatibility of OS X 10.11: getgrouplist
/* Work around an incompatibility of macOS: getgrouplist
accepts int *, not gid_t *, and int and gid_t differ in sign. */
# ifdef __APPLE__
VIR_WARNINGS_NO_POINTER_SIGN
# endif
/* Compute the list of primary and supplementary groups associated
* with @uid, and including @gid in the list (unless it is -1),
@ -934,7 +936,9 @@ virGetGroupList(uid_t uid, gid_t gid, gid_t **list)
return ret;
}
# ifdef __APPLE__
VIR_WARNINGS_RESET
# endif
/* Set the real and effective uid and gid to the given values, as well