shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 06:50:22 +03:00
Code Releases Activity

qemuDomainGetStatsCpuCgroup: Remove return value

Browse Source 
The function can't fail. Remove return value and refactor callers.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2025-02-17 13:51:10 +01:00
parent 3518f46cba
commit a90df14a35
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/qemu/qemu_driver.c
View File

@ -16812,7 +16812,7 @@ qemuDomainGetStatsCpuCache(virQEMUDriver *driver,
}
static int
static void
qemuDomainGetStatsCpuCgroup(virDomainObj *dom,
virTypedParamList *params)
{
@ -16822,7 +16822,7 @@ qemuDomainGetStatsCpuCgroup(virDomainObj *dom,
unsigned long long sys_time = 0;
if (!priv->cgroup)
return 0;
return;
if (virCgroupGetCpuacctUsage(priv->cgroup, &cpu_time) == 0)
virTypedParamListAddULLong(params, cpu_time, "cpu.time");
@ -16831,8 +16831,6 @@ qemuDomainGetStatsCpuCgroup(virDomainObj *dom,
virTypedParamListAddULLong(params, user_time, "cpu.user");
virTypedParamListAddULLong(params, sys_time, "cpu.system");
}
return 0;
}
@ -16955,8 +16953,7 @@ qemuDomainGetStatsCpu(virQEMUDriver *driver,
qemuDomainObjPrivate *priv = dom->privateData;
if (priv->cgroup) {
if (qemuDomainGetStatsCpuCgroup(dom, params) < 0)
return -1;
qemuDomainGetStatsCpuCgroup(dom, params);
} else {
if (qemuDomainGetStatsCpuProc(dom, params) < 0)
return -1;