shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-11 09:17:52 +03:00
Code Releases Activity

xenapi: Resolve Coverity NULL_RETURNS

Browse Source 
Coverity points out that the return from virDomainDefParseString is
not checked in xenapiDomainCreateXML like it should be which could
end up in a NULL pointer dereference
This commit is contained in:
John Ferlan 2015-03-10 18:52:07 -04:00
parent 467c905909
commit b193a1d617
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/xenapi/xenapi_driver.c
View File

@ -560,6 +560,8 @@ xenapiDomainCreateXML(virConnectPtr conn,
priv->caps, priv->xmlopt, priv->caps, priv->xmlopt,
1 << VIR_DOMAIN_VIRT_XEN, 1 << VIR_DOMAIN_VIRT_XEN,
parse_flags); parse_flags);
if (!defPtr)
return NULL;
createVMRecordFromXml(conn, defPtr, &record, &vm); createVMRecordFromXml(conn, defPtr, &record, &vm);
virDomainDefFree(defPtr); virDomainDefFree(defPtr);
if (record) { if (record) {