shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 06:50:22 +03:00
Code Releases Activity

virDomainDefSetMetadata: Avoid temporary variable for string copy

Browse Source 
Since error checking was removed when switching to g_strdup, it doesn't
make much sense to have 'tmp' around.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
This commit is contained in:
Peter Krempa 2021-02-24 10:41:00 +01:00
parent 3560f75d2d
commit b356a3ce7c
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/conf/domain_conf.c
View File

@ -30425,7 +30425,6 @@ virDomainDefSetMetadata(virDomainDefPtr def,
xmlDocPtr doc = NULL;
xmlNodePtr old;
xmlNodePtr new = NULL;
char *tmp = NULL;
int ret = -1;
if (type >= VIR_DOMAIN_METADATA_LAST) {
@ -30436,19 +30435,17 @@ virDomainDefSetMetadata(virDomainDefPtr def,
switch ((virDomainMetadataType) type) {
case VIR_DOMAIN_METADATA_DESCRIPTION:
if (STRNEQ_NULLABLE(metadata, ""))
tmp = g_strdup(metadata);
g_clear_pointer(&def->description, g_free);
VIR_FREE(def->description);
def->description = tmp;
if (STRNEQ_NULLABLE(metadata, ""))
def->description = g_strdup(metadata);
break;
case VIR_DOMAIN_METADATA_TITLE:
if (STRNEQ_NULLABLE(metadata, ""))
tmp = g_strdup(metadata);
g_clear_pointer(&def->title, g_free);
VIR_FREE(def->title);
def->title = tmp;
if (STRNEQ_NULLABLE(metadata, ""))
def->title = g_strdup(metadata);
break;
case VIR_DOMAIN_METADATA_ELEMENT: