1
0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-12 13:17:58 +03:00

qemu: do not format <usedQMP/> in qemu caps XML

Since commit a7424faff QMP is always used.

Also, commit 932534e8 removed the last use of this apart from:
* parsing/formatting this in the caps cache
* using it as a temporary variable to know when to report an error

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
Ján Tomko 2019-02-08 13:22:12 +01:00
parent 0f87356c51
commit b4a4e8f71a
37 changed files with 0 additions and 43 deletions

View File

@ -3357,7 +3357,6 @@ virQEMUCapsParseSEVInfo(virQEMUCapsPtr qemuCaps, xmlXPathContextPtr ctxt)
* <qemuctime>234235253</qemuctime> * <qemuctime>234235253</qemuctime>
* <selfctime>234235253</selfctime> * <selfctime>234235253</selfctime>
* <selfvers>1002016</selfvers> * <selfvers>1002016</selfvers>
* <usedQMP/>
* <flag name='foo'/> * <flag name='foo'/>
* <flag name='bar'/> * <flag name='bar'/>
* ... * ...
@ -3418,9 +3417,6 @@ virQEMUCapsLoadCache(virArch hostArch,
if (virXPathULong("string(./selfvers)", ctxt, &lu) == 0) if (virXPathULong("string(./selfvers)", ctxt, &lu) == 0)
qemuCaps->libvirtVersion = lu; qemuCaps->libvirtVersion = lu;
qemuCaps->usedQMP = virXPathBoolean("count(./usedQMP) > 0",
ctxt) > 0;
if ((n = virXPathNodeSet("./flag", ctxt, &nodes)) < 0) { if ((n = virXPathNodeSet("./flag", ctxt, &nodes)) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s", virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("failed to parse qemu capabilities flags")); _("failed to parse qemu capabilities flags"));
@ -3761,9 +3757,6 @@ virQEMUCapsFormatCache(virQEMUCapsPtr qemuCaps)
virBufferAsprintf(&buf, "<selfvers>%lu</selfvers>\n", virBufferAsprintf(&buf, "<selfvers>%lu</selfvers>\n",
(unsigned long)qemuCaps->libvirtVersion); (unsigned long)qemuCaps->libvirtVersion);
if (qemuCaps->usedQMP)
virBufferAddLit(&buf, "<usedQMP/>\n");
for (i = 0; i < QEMU_CAPS_LAST; i++) { for (i = 0; i < QEMU_CAPS_LAST; i++) {
if (virQEMUCapsGet(qemuCaps, i)) { if (virQEMUCapsGet(qemuCaps, i)) {
virBufferAsprintf(&buf, "<flag name='%s'/>\n", virBufferAsprintf(&buf, "<flag name='%s'/>\n",

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>
<flag name='virtio-blk-pci.ioeventfd'/> <flag name='virtio-blk-pci.ioeventfd'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>
<flag name='virtio-blk-pci.ioeventfd'/> <flag name='virtio-blk-pci.ioeventfd'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>
<flag name='virtio-blk-pci.ioeventfd'/> <flag name='virtio-blk-pci.ioeventfd'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='ccid-emulated'/> <flag name='ccid-emulated'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>
<flag name='virtio-blk-pci.ioeventfd'/> <flag name='virtio-blk-pci.ioeventfd'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>
<flag name='virtio-blk-pci.ioeventfd'/> <flag name='virtio-blk-pci.ioeventfd'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>
<flag name='virtio-blk-pci.ioeventfd'/> <flag name='virtio-blk-pci.ioeventfd'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='scsi-disk.channel'/> <flag name='scsi-disk.channel'/>
<flag name='scsi-block'/> <flag name='scsi-block'/>
<flag name='transaction'/> <flag name='transaction'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='scsi-disk.channel'/> <flag name='scsi-disk.channel'/>
<flag name='scsi-block'/> <flag name='scsi-block'/>
<flag name='transaction'/> <flag name='transaction'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>
<flag name='virtio-blk-pci.ioeventfd'/> <flag name='virtio-blk-pci.ioeventfd'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='virtio-tx-alg'/> <flag name='virtio-tx-alg'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='spice'/> <flag name='spice'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='ccid-emulated'/> <flag name='ccid-emulated'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='spice'/> <flag name='spice'/>
<flag name='hda-duplex'/> <flag name='hda-duplex'/>
<flag name='ccid-emulated'/> <flag name='ccid-emulated'/>

View File

@ -2,7 +2,6 @@
<qemuctime>0</qemuctime> <qemuctime>0</qemuctime>
<selfctime>0</selfctime> <selfctime>0</selfctime>
<selfvers>0</selfvers> <selfvers>0</selfvers>
<usedQMP/>
<flag name='kvm'/> <flag name='kvm'/>
<flag name='no-hpet'/> <flag name='no-hpet'/>
<flag name='spice'/> <flag name='spice'/>