From bac69aa1f91bd5cf361e221744637adc403b61d8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A1n=20Tomko?= <jtomko@redhat.com>
Date: Fri, 20 Nov 2020 13:39:37 +0100
Subject: [PATCH] testsutilsqemu: check return value of virQEMUCapsNewCopy
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

While for virQEMUCapsNew this should not be needed
(the possible failures in VIR_CLASS_NEW are only hit
 on bad API usage which we don't do here),
virQEMUCapsNewCopy calls into many other functions,
some of which actually fail.

Check the return value of both.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---
 tests/testutilsqemu.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c
index 906fdf5c1a..cea4f84b14 100644
--- a/tests/testutilsqemu.c
+++ b/tests/testutilsqemu.c
@@ -349,6 +349,9 @@ int qemuTestCapsCacheInsert(virFileCachePtr cache,
             tmpCaps = virQEMUCapsNew();
         }
 
+        if (!tmpCaps)
+            return -1;
+
         if (!virQEMUCapsHasMachines(tmpCaps)) {
             const char *defaultRAMid = NULL;