shaba/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-08 16:58:29 +03:00
Code Releases Activity

conf: Rename virDomainControllerIsPCIHostBridge() to IsPSeriesPHB()

Browse Source 
The original name didn't hint at the fact that PHBs are
a pSeries-specific concept.

Suggested-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
This commit is contained in:
Andrea Bolognani 2017-07-24 13:26:57 +02:00
parent 9b45cd8fab
commit bbda2883c4
6 changed files with 7 additions and 7 deletions

4
src/conf/domain_conf.c

@ -1892,7 +1892,7 @@ void virDomainControllerDefFree(virDomainControllerDefPtr def)
/**
* virDomainControllerIsPCIHostBridge:
* virDomainControllerIsPSeriesPHB:
* @cont: controller
*
* Checks whether @cont is a PCI Host Bridge (PHB), a specific type
@ -1901,7 +1901,7 @@ void virDomainControllerDefFree(virDomainControllerDefPtr def)
* Returns: true if @cont is a PHB, false otherwise.
*/
bool
virDomainControllerIsPCIHostBridge(const virDomainControllerDef *cont)
virDomainControllerIsPSeriesPHB(const virDomainControllerDef *cont)
{
virDomainControllerPCIModelName name;

2
src/conf/domain_conf.h

@ -2681,7 +2681,7 @@ virDomainDiskDefPtr virDomainDiskFindByBusAndDst(virDomainDefPtr def,
virDomainControllerDefPtr virDomainControllerDefNew(virDomainControllerType type);
void virDomainControllerDefFree(virDomainControllerDefPtr def);
bool virDomainControllerIsPCIHostBridge(const virDomainControllerDef *cont);
bool virDomainControllerIsPSeriesPHB(const virDomainControllerDef *cont);
virDomainFSDefPtr virDomainFSDefNew(void);
void virDomainFSDefFree(virDomainFSDefPtr def);

2
src/libvirt_private.syms

@ -228,7 +228,7 @@ virDomainControllerFindByType;
virDomainControllerFindUnusedIndex;
virDomainControllerInsert;
virDomainControllerInsertPreAlloced;
virDomainControllerIsPCIHostBridge;
virDomainControllerIsPSeriesPHB;
virDomainControllerModelPCITypeToString;
virDomainControllerModelSCSITypeFromString;
virDomainControllerModelSCSITypeToString;

2
src/qemu/qemu_command.c

@ -317,7 +317,7 @@ qemuBuildDeviceAddressStr(virBufferPtr buf,
if (cont->type == VIR_DOMAIN_CONTROLLER_TYPE_PCI &&
cont->idx == info->addr.pci.bus) {
contAlias = cont->info.alias;
contIsPHB = virDomainControllerIsPCIHostBridge(cont);
contIsPHB = virDomainControllerIsPSeriesPHB(cont);
contTargetIndex = cont->opts.pciopts.targetIndex;
if (!contAlias) {
virReportError(VIR_ERR_INTERNAL_ERROR,

2
src/qemu/qemu_domain.c

@ -6735,7 +6735,7 @@ qemuDomainGetMemLockLimitBytes(virDomainDefPtr def)
for (i = 0; i < def->ncontrollers; i++) {
virDomainControllerDefPtr cont = def->controllers[i];
if (!virDomainControllerIsPCIHostBridge(cont))
if (!virDomainControllerIsPSeriesPHB(cont))
continue;
nPCIHostBridges++;

2
src/qemu/qemu_domain_address.c

@ -2167,7 +2167,7 @@ qemuDomainAddressFindNewTargetIndex(virDomainDefPtr def)
virDomainControllerDefPtr cont = def->controllers[i];
/* Skip everything but PHBs */
if (!virDomainControllerIsPCIHostBridge(cont))
if (!virDomainControllerIsPSeriesPHB(cont))
continue;
/* Stop looking as soon as we find a PHB that's